[INFO] crate msql-srv 0.8.1 is already in cache [INFO] extracting crate msql-srv 0.8.1 into work/ex/clippy-test-run/sources/stable/reg/msql-srv/0.8.1 [INFO] extracting crate msql-srv 0.8.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/msql-srv/0.8.1 [INFO] validating manifest of msql-srv-0.8.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msql-srv-0.8.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msql-srv-0.8.1 [INFO] finished frobbing msql-srv-0.8.1 [INFO] frobbed toml for msql-srv-0.8.1 written to work/ex/clippy-test-run/sources/stable/reg/msql-srv/0.8.1/Cargo.toml [INFO] started frobbing msql-srv-0.8.1 [INFO] finished frobbing msql-srv-0.8.1 [INFO] frobbed toml for msql-srv-0.8.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/msql-srv/0.8.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msql-srv-0.8.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/msql-srv/0.8.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cf1d74047acab6e5a451407236ef486af32be3d8933fe194b0beed706dadbd4 [INFO] running `"docker" "start" "-a" "5cf1d74047acab6e5a451407236ef486af32be3d8933fe194b0beed706dadbd4"` [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking mysql_common v0.5.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking msql-srv v0.8.1 (/opt/crater/workdir) [INFO] [stderr] Checking mysql v12.3.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultset.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | is_bin: is_bin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_bin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultset.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultset.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:515:13 [INFO] [stderr] | [INFO] [stderr] 515 | let h = (s % (24 * 3600)) / 3600; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | let m = (s % 3600) / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:552:54 [INFO] [stderr] | [INFO] [stderr] 552 | myc::value::Value::Date(y, mo, d, h, mi, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:557:51 [INFO] [stderr] | [INFO] [stderr] 557 | myc::value::Value::Time(neg, d, h, m, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:616:47 [INFO] [stderr] | [INFO] [stderr] 616 | myc::value::Value::Date(y, mo, d, h, mi, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:616:54 [INFO] [stderr] | [INFO] [stderr] 616 | myc::value::Value::Date(y, mo, d, h, mi, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:621:48 [INFO] [stderr] | [INFO] [stderr] 621 | myc::value::Value::Time(neg, d, h, m, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:621:51 [INFO] [stderr] | [INFO] [stderr] 621 | myc::value::Value::Time(neg, d, h, m, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/value/encode.rs:598:24 [INFO] [stderr] | [INFO] [stderr] 598 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 599 | | if n <= u8::max_value() as i64 { [INFO] [stderr] 600 | | (n as u8).to_mysql_bin(w, c) [INFO] [stderr] 601 | | } else if n <= u16::max_value() as i64 { [INFO] [stderr] ... | [INFO] [stderr] 608 | | } [INFO] [stderr] 609 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 598 | } else if n <= u8::max_value() as i64 { [INFO] [stderr] 599 | (n as u8).to_mysql_bin(w, c) [INFO] [stderr] 600 | } else if n <= u16::max_value() as i64 { [INFO] [stderr] 601 | (n as u16).to_mysql_bin(w, c) [INFO] [stderr] 602 | } else if n <= u32::max_value() as i64 { [INFO] [stderr] 603 | (n as u32).to_mysql_bin(w, c) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/errorcodes.rs:2819:21 [INFO] [stderr] | [INFO] [stderr] 2819 | pub fn sqlstate(&self) -> &'static [u8; 5] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/value/encode.rs:502:18 [INFO] [stderr] | [INFO] [stderr] 502 | let us = self.subsec_nanos() / 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/value/encode.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | let us = self.subsec_nanos() / 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:553:37 [INFO] [stderr] | [INFO] [stderr] 553 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:553:47 [INFO] [stderr] | [INFO] [stderr] 553 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:553:58 [INFO] [stderr] | [INFO] [stderr] 553 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:554:36 [INFO] [stderr] | [INFO] [stderr] 554 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:554:46 [INFO] [stderr] | [INFO] [stderr] 554 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:554:57 [INFO] [stderr] | [INFO] [stderr] 554 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:564:41 [INFO] [stderr] | [INFO] [stderr] 564 | (chrono::Duration::days(d as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:565:47 [INFO] [stderr] | [INFO] [stderr] 565 | + chrono::Duration::hours(h as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:566:49 [INFO] [stderr] | [INFO] [stderr] 566 | + chrono::Duration::minutes(m as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:567:49 [INFO] [stderr] | [INFO] [stderr] 567 | + chrono::Duration::seconds(s as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:568:54 [INFO] [stderr] | [INFO] [stderr] 568 | + chrono::Duration::microseconds(us as i64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(us)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:587:29 [INFO] [stderr] | [INFO] [stderr] 587 | if n >= i8::min_value() as i64 && n <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:587:60 [INFO] [stderr] | [INFO] [stderr] 587 | if n >= i8::min_value() as i64 && n <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:589:36 [INFO] [stderr] | [INFO] [stderr] 589 | } else if n >= i16::min_value() as i64 && n <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:589:68 [INFO] [stderr] | [INFO] [stderr] 589 | } else if n >= i16::min_value() as i64 && n <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:591:36 [INFO] [stderr] | [INFO] [stderr] 591 | } else if n >= i32::min_value() as i64 && n <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:591:68 [INFO] [stderr] | [INFO] [stderr] 591 | } else if n >= i32::min_value() as i64 && n <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:599:29 [INFO] [stderr] | [INFO] [stderr] 599 | if n <= u8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:601:36 [INFO] [stderr] | [INFO] [stderr] 601 | } else if n <= u16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:603:36 [INFO] [stderr] | [INFO] [stderr] 603 | } else if n <= u32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:617:37 [INFO] [stderr] | [INFO] [stderr] 617 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:617:47 [INFO] [stderr] | [INFO] [stderr] 617 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:617:58 [INFO] [stderr] | [INFO] [stderr] 617 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:618:36 [INFO] [stderr] | [INFO] [stderr] 618 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:618:46 [INFO] [stderr] | [INFO] [stderr] 618 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:618:57 [INFO] [stderr] | [INFO] [stderr] 618 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:628:41 [INFO] [stderr] | [INFO] [stderr] 628 | (chrono::Duration::days(d as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:629:47 [INFO] [stderr] | [INFO] [stderr] 629 | + chrono::Duration::hours(h as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:630:49 [INFO] [stderr] | [INFO] [stderr] 630 | + chrono::Duration::minutes(m as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:631:49 [INFO] [stderr] | [INFO] [stderr] 631 | + chrono::Duration::seconds(s as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:632:54 [INFO] [stderr] | [INFO] [stderr] 632 | + chrono::Duration::microseconds(us as i64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(us)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:304:54 [INFO] [stderr] | [INFO] [stderr] 304 | let state = stmts.get_mut(&stmt).ok_or(io::Error::new( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 305 | | io::ErrorKind::InvalidData, [INFO] [stderr] 306 | | format!("asked to execute unknown statement {}", stmt), [INFO] [stderr] 307 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 304 | let state = stmts.get_mut(&stmt).ok_or_else(|| io::Error::new( [INFO] [stderr] 305 | io::ErrorKind::InvalidData, [INFO] [stderr] 306 | format!("asked to execute unknown statement {}", stmt), [INFO] [stderr] 307 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:318:26 [INFO] [stderr] | [INFO] [stderr] 318 | .ok_or(io::Error::new( [INFO] [stderr] | __________________________^ [INFO] [stderr] 319 | | io::ErrorKind::InvalidData, [INFO] [stderr] 320 | | format!("got long data packet for unknown statement {}", stmt), [INFO] [stderr] 321 | | ))? [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 318 | .ok_or_else(|| io::Error::new( [INFO] [stderr] 319 | io::ErrorKind::InvalidData, [INFO] [stderr] 320 | format!("got long data packet for unknown statement {}", stmt), [INFO] [stderr] 321 | ))? [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Checking mysql_async v0.14.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultset.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | is_bin: is_bin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_bin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultset.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultset.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:515:13 [INFO] [stderr] | [INFO] [stderr] 515 | let h = (s % (24 * 3600)) / 3600; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | let m = (s % 3600) / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:552:54 [INFO] [stderr] | [INFO] [stderr] 552 | myc::value::Value::Date(y, mo, d, h, mi, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:557:51 [INFO] [stderr] | [INFO] [stderr] 557 | myc::value::Value::Time(neg, d, h, m, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:616:47 [INFO] [stderr] | [INFO] [stderr] 616 | myc::value::Value::Date(y, mo, d, h, mi, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:616:54 [INFO] [stderr] | [INFO] [stderr] 616 | myc::value::Value::Date(y, mo, d, h, mi, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:621:48 [INFO] [stderr] | [INFO] [stderr] 621 | myc::value::Value::Time(neg, d, h, m, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/encode.rs:621:51 [INFO] [stderr] | [INFO] [stderr] 621 | myc::value::Value::Time(neg, d, h, m, s, us) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands.rs:132:37 [INFO] [stderr] | [INFO] [stderr] 132 | assert_eq!(handshake.maxps, 16777216); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/value/encode.rs:598:24 [INFO] [stderr] | [INFO] [stderr] 598 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 599 | | if n <= u8::max_value() as i64 { [INFO] [stderr] 600 | | (n as u8).to_mysql_bin(w, c) [INFO] [stderr] 601 | | } else if n <= u16::max_value() as i64 { [INFO] [stderr] ... | [INFO] [stderr] 608 | | } [INFO] [stderr] 609 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 598 | } else if n <= u8::max_value() as i64 { [INFO] [stderr] 599 | (n as u8).to_mysql_bin(w, c) [INFO] [stderr] 600 | } else if n <= u16::max_value() as i64 { [INFO] [stderr] 601 | (n as u16).to_mysql_bin(w, c) [INFO] [stderr] 602 | } else if n <= u32::max_value() as i64 { [INFO] [stderr] 603 | (n as u32).to_mysql_bin(w, c) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/errorcodes.rs:2819:21 [INFO] [stderr] | [INFO] [stderr] 2819 | pub fn sqlstate(&self) -> &'static [u8; 5] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/decode.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | / rt!( [INFO] [stderr] 386 | | f32_one_double, [INFO] [stderr] 387 | | f32, [INFO] [stderr] 388 | | 1.0, [INFO] [stderr] 389 | | ColumnType::MYSQL_TYPE_DOUBLE, [INFO] [stderr] 390 | | false [INFO] [stderr] 391 | | ); [INFO] [stderr] | |______^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/decode.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | / rt!( [INFO] [stderr] 386 | | f32_one_double, [INFO] [stderr] 387 | | f32, [INFO] [stderr] 388 | | 1.0, [INFO] [stderr] 389 | | ColumnType::MYSQL_TYPE_DOUBLE, [INFO] [stderr] 390 | | false [INFO] [stderr] 391 | | ); [INFO] [stderr] | |______^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/decode.rs:392:5 [INFO] [stderr] | [INFO] [stderr] 392 | rt!(f64_one, f64, 1.0, ColumnType::MYSQL_TYPE_DOUBLE, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/decode.rs:392:5 [INFO] [stderr] | [INFO] [stderr] 392 | rt!(f64_one, f64, 1.0, ColumnType::MYSQL_TYPE_DOUBLE, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/value/encode.rs:502:18 [INFO] [stderr] | [INFO] [stderr] 502 | let us = self.subsec_nanos() / 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/value/encode.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | let us = self.subsec_nanos() / 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:553:37 [INFO] [stderr] | [INFO] [stderr] 553 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:553:47 [INFO] [stderr] | [INFO] [stderr] 553 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:553:58 [INFO] [stderr] | [INFO] [stderr] 553 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:554:36 [INFO] [stderr] | [INFO] [stderr] 554 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:554:46 [INFO] [stderr] | [INFO] [stderr] 554 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:554:57 [INFO] [stderr] | [INFO] [stderr] 554 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:564:41 [INFO] [stderr] | [INFO] [stderr] 564 | (chrono::Duration::days(d as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:565:47 [INFO] [stderr] | [INFO] [stderr] 565 | + chrono::Duration::hours(h as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:566:49 [INFO] [stderr] | [INFO] [stderr] 566 | + chrono::Duration::minutes(m as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:567:49 [INFO] [stderr] | [INFO] [stderr] 567 | + chrono::Duration::seconds(s as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:568:54 [INFO] [stderr] | [INFO] [stderr] 568 | + chrono::Duration::microseconds(us as i64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(us)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:587:29 [INFO] [stderr] | [INFO] [stderr] 587 | if n >= i8::min_value() as i64 && n <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:587:60 [INFO] [stderr] | [INFO] [stderr] 587 | if n >= i8::min_value() as i64 && n <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:589:36 [INFO] [stderr] | [INFO] [stderr] 589 | } else if n >= i16::min_value() as i64 && n <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:589:68 [INFO] [stderr] | [INFO] [stderr] 589 | } else if n >= i16::min_value() as i64 && n <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:591:36 [INFO] [stderr] | [INFO] [stderr] 591 | } else if n >= i32::min_value() as i64 && n <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:591:68 [INFO] [stderr] | [INFO] [stderr] 591 | } else if n >= i32::min_value() as i64 && n <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:599:29 [INFO] [stderr] | [INFO] [stderr] 599 | if n <= u8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:601:36 [INFO] [stderr] | [INFO] [stderr] 601 | } else if n <= u16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:603:36 [INFO] [stderr] | [INFO] [stderr] 603 | } else if n <= u32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:617:37 [INFO] [stderr] | [INFO] [stderr] 617 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:617:47 [INFO] [stderr] | [INFO] [stderr] 617 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:617:58 [INFO] [stderr] | [INFO] [stderr] 617 | NaiveDate::from_ymd(y as i32, mo as u32, d as u32) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:618:36 [INFO] [stderr] | [INFO] [stderr] 618 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:618:46 [INFO] [stderr] | [INFO] [stderr] 618 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(mi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:618:57 [INFO] [stderr] | [INFO] [stderr] 618 | .and_hms_micro(h as u32, mi as u32, s as u32, us) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:628:41 [INFO] [stderr] | [INFO] [stderr] 628 | (chrono::Duration::days(d as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:629:47 [INFO] [stderr] | [INFO] [stderr] 629 | + chrono::Duration::hours(h as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:630:49 [INFO] [stderr] | [INFO] [stderr] 630 | + chrono::Duration::minutes(m as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:631:49 [INFO] [stderr] | [INFO] [stderr] 631 | + chrono::Duration::seconds(s as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/encode.rs:632:54 [INFO] [stderr] | [INFO] [stderr] 632 | + chrono::Duration::microseconds(us as i64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(us)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/encode.rs:685:9 [INFO] [stderr] | [INFO] [stderr] 685 | rt!(f32_one, f32, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/encode.rs:685:9 [INFO] [stderr] | [INFO] [stderr] 685 | rt!(f32_one, f32, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/encode.rs:686:9 [INFO] [stderr] | [INFO] [stderr] 686 | rt!(f64_one, f64, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/encode.rs:686:9 [INFO] [stderr] | [INFO] [stderr] 686 | rt!(f64_one, f64, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/encode.rs:806:9 [INFO] [stderr] | [INFO] [stderr] 806 | rt!(f32_one, f32, 1.0, ColumnType::MYSQL_TYPE_FLOAT, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/encode.rs:806:9 [INFO] [stderr] | [INFO] [stderr] 806 | rt!(f32_one, f32, 1.0, ColumnType::MYSQL_TYPE_FLOAT, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/encode.rs:807:9 [INFO] [stderr] | [INFO] [stderr] 807 | / rt!( [INFO] [stderr] 808 | | f32_one_double, [INFO] [stderr] 809 | | f32, [INFO] [stderr] 810 | | 1.0, [INFO] [stderr] 811 | | ColumnType::MYSQL_TYPE_DOUBLE, [INFO] [stderr] 812 | | false [INFO] [stderr] 813 | | ); [INFO] [stderr] | |__________^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/encode.rs:807:9 [INFO] [stderr] | [INFO] [stderr] 807 | / rt!( [INFO] [stderr] 808 | | f32_one_double, [INFO] [stderr] 809 | | f32, [INFO] [stderr] 810 | | 1.0, [INFO] [stderr] 811 | | ColumnType::MYSQL_TYPE_DOUBLE, [INFO] [stderr] 812 | | false [INFO] [stderr] 813 | | ); [INFO] [stderr] | |__________^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/encode.rs:814:9 [INFO] [stderr] | [INFO] [stderr] 814 | rt!(f64_one, f64, 1.0, ColumnType::MYSQL_TYPE_DOUBLE, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/encode.rs:814:9 [INFO] [stderr] | [INFO] [stderr] 814 | rt!(f64_one, f64, 1.0, ColumnType::MYSQL_TYPE_DOUBLE, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> examples/psql_as_mysql.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> examples/psql_as_mysql.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> examples/psql_as_mysql.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | None => Ok(results.error(ErrorKind::ER_NO, b"no such prepared statement")?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 182 | None => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:304:54 [INFO] [stderr] | [INFO] [stderr] 304 | let state = stmts.get_mut(&stmt).ok_or(io::Error::new( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 305 | | io::ErrorKind::InvalidData, [INFO] [stderr] 306 | | format!("asked to execute unknown statement {}", stmt), [INFO] [stderr] 307 | | ))?; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 304 | let state = stmts.get_mut(&stmt).ok_or_else(|| io::Error::new( [INFO] [stderr] 305 | io::ErrorKind::InvalidData, [INFO] [stderr] 306 | format!("asked to execute unknown statement {}", stmt), [INFO] [stderr] 307 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:318:26 [INFO] [stderr] | [INFO] [stderr] 318 | .ok_or(io::Error::new( [INFO] [stderr] | __________________________^ [INFO] [stderr] 319 | | io::ErrorKind::InvalidData, [INFO] [stderr] 320 | | format!("got long data packet for unknown statement {}", stmt), [INFO] [stderr] 321 | | ))? [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 318 | .ok_or_else(|| io::Error::new( [INFO] [stderr] 319 | io::ErrorKind::InvalidData, [INFO] [stderr] 320 | format!("got long data packet for unknown statement {}", stmt), [INFO] [stderr] 321 | ))? [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> examples/psql_as_mysql.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `msql-srv`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "5cf1d74047acab6e5a451407236ef486af32be3d8933fe194b0beed706dadbd4"` [INFO] running `"docker" "rm" "-f" "5cf1d74047acab6e5a451407236ef486af32be3d8933fe194b0beed706dadbd4"` [INFO] [stdout] 5cf1d74047acab6e5a451407236ef486af32be3d8933fe194b0beed706dadbd4