[INFO] crate msg-transmitter 0.3.2 is already in cache [INFO] extracting crate msg-transmitter 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/msg-transmitter/0.3.2 [INFO] extracting crate msg-transmitter 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/msg-transmitter/0.3.2 [INFO] validating manifest of msg-transmitter-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msg-transmitter-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msg-transmitter-0.3.2 [INFO] removed 0 missing examples [INFO] finished frobbing msg-transmitter-0.3.2 [INFO] frobbed toml for msg-transmitter-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/msg-transmitter/0.3.2/Cargo.toml [INFO] started frobbing msg-transmitter-0.3.2 [INFO] removed 0 missing examples [INFO] finished frobbing msg-transmitter-0.3.2 [INFO] frobbed toml for msg-transmitter-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/msg-transmitter/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msg-transmitter-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/msg-transmitter/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62295aebed945ed9d3eeae21eb4c7cae26288c1e77e1609114ab0a53eb78f4d8 [INFO] running `"docker" "start" "-a" "62295aebed945ed9d3eeae21eb4c7cae26288c1e77e1609114ab0a53eb78f4d8"` [INFO] [stderr] Checking msg-transmitter v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | MessageCodec { name: name, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | MessageCodec { name: name, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return num; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:217:40 [INFO] [stderr] | [INFO] [stderr] 217 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 218 | | if connections_inner.lock().unwrap().contains_key(&dest) { [INFO] [stderr] 219 | | connections_inner.lock().unwrap().get_mut(&dest).unwrap() [INFO] [stderr] 220 | | .try_send(Some(msg)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 217 | } else if connections_inner.lock().unwrap().contains_key(&dest) { [INFO] [stderr] 218 | connections_inner.lock().unwrap().get_mut(&dest).unwrap() [INFO] [stderr] 219 | .try_send(Some(msg)).unwrap(); [INFO] [stderr] 220 | } else { [INFO] [stderr] 221 | println!("{} doesn't register", dest); [INFO] [stderr] 222 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return num; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:217:40 [INFO] [stderr] | [INFO] [stderr] 217 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 218 | | if connections_inner.lock().unwrap().contains_key(&dest) { [INFO] [stderr] 219 | | connections_inner.lock().unwrap().get_mut(&dest).unwrap() [INFO] [stderr] 220 | | .try_send(Some(msg)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 217 | } else if connections_inner.lock().unwrap().contains_key(&dest) { [INFO] [stderr] 218 | connections_inner.lock().unwrap().get_mut(&dest).unwrap() [INFO] [stderr] 219 | .try_send(Some(msg)).unwrap(); [INFO] [stderr] 220 | } else { [INFO] [stderr] 221 | println!("{} doesn't register", dest); [INFO] [stderr] 222 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | x = x / 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x /= 256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | let num = vec[0] as u64 * 256 * 256 * 256 + vec[1] as u64 * 256 * 256 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:49 [INFO] [stderr] | [INFO] [stderr] 89 | let num = vec[0] as u64 * 256 * 256 * 256 + vec[1] as u64 * 256 * 256 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:11 [INFO] [stderr] | [INFO] [stderr] 90 | + vec[2] as u64 * 256 + vec[3] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | + vec[2] as u64 * 256 + vec[3] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | x = x / 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x /= 256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | let num = vec[0] as u64 * 256 * 256 * 256 + vec[1] as u64 * 256 * 256 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:49 [INFO] [stderr] | [INFO] [stderr] 89 | let num = vec[0] as u64 * 256 * 256 * 256 + vec[1] as u64 * 256 * 256 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:11 [INFO] [stderr] | [INFO] [stderr] 90 | + vec[2] as u64 * 256 + vec[3] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | + vec[2] as u64 * 256 + vec[3] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(vec[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::sync::mpsc` [INFO] [stderr] --> examples/master_and_slave.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | use futures::sync::mpsc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> examples/master_and_slave.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `now` [INFO] [stderr] --> examples/master_and_slave.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let now = time::Instant::now(); [INFO] [stderr] | ^^^ help: consider using `_now` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/master_and_slave.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / match msg { [INFO] [stderr] 79 | | Message::Stop() => { [INFO] [stderr] 80 | | for (_, tx) in connections.lock().unwrap().iter_mut() { [INFO] [stderr] 81 | | (*tx).try_send(Some(0)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 85 | | _ =>{} [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Message::Stop() = msg { [INFO] [stderr] 79 | for (_, tx) in connections.lock().unwrap().iter_mut() { [INFO] [stderr] 80 | (*tx).try_send(Some(0)).unwrap(); [INFO] [stderr] 81 | } [INFO] [stderr] 82 | std::process::exit(0); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.81s [INFO] running `"docker" "inspect" "62295aebed945ed9d3eeae21eb4c7cae26288c1e77e1609114ab0a53eb78f4d8"` [INFO] running `"docker" "rm" "-f" "62295aebed945ed9d3eeae21eb4c7cae26288c1e77e1609114ab0a53eb78f4d8"` [INFO] [stdout] 62295aebed945ed9d3eeae21eb4c7cae26288c1e77e1609114ab0a53eb78f4d8