[INFO] crate mrtd 0.1.0 is already in cache [INFO] extracting crate mrtd 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mrtd/0.1.0 [INFO] extracting crate mrtd 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mrtd/0.1.0 [INFO] validating manifest of mrtd-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mrtd-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mrtd-0.1.0 [INFO] finished frobbing mrtd-0.1.0 [INFO] frobbed toml for mrtd-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mrtd/0.1.0/Cargo.toml [INFO] started frobbing mrtd-0.1.0 [INFO] finished frobbing mrtd-0.1.0 [INFO] frobbed toml for mrtd-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mrtd/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mrtd-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mrtd/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 317181a781d03582d4cc1b64395afb71a1106c9b74decbf0b5d97ebf7b4989e4 [INFO] running `"docker" "start" "-a" "317181a781d03582d4cc1b64395afb71a1106c9b74decbf0b5d97ebf7b4989e4"` [INFO] [stderr] Checking mrtd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / return Ok(Document::Passport(Passport { [INFO] [stderr] 106 | | country, [INFO] [stderr] 107 | | surname, [INFO] [stderr] 108 | | given_names, [INFO] [stderr] ... | [INFO] [stderr] 113 | | expiry_date, [INFO] [stderr] 114 | | })); [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Document::Passport(Passport { [INFO] [stderr] 106 | country, [INFO] [stderr] 107 | surname, [INFO] [stderr] 108 | given_names, [INFO] [stderr] 109 | passport_number, [INFO] [stderr] 110 | nationality, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:134:57 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(passport.birth_date.month(), 08); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(passport.birth_date.month(), 8); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(passport.birth_date.month(), 0o8); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:138:58 [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(passport.expiry_date.month(), 04); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(passport.expiry_date.month(), 4); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(passport.expiry_date.month(), 0o4); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / return Ok(Document::Passport(Passport { [INFO] [stderr] 106 | | country, [INFO] [stderr] 107 | | surname, [INFO] [stderr] 108 | | given_names, [INFO] [stderr] ... | [INFO] [stderr] 113 | | expiry_date, [INFO] [stderr] 114 | | })); [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Document::Passport(Passport { [INFO] [stderr] 106 | country, [INFO] [stderr] 107 | surname, [INFO] [stderr] 108 | given_names, [INFO] [stderr] 109 | passport_number, [INFO] [stderr] 110 | nationality, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | .split("<") [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:86:10 [INFO] [stderr] | [INFO] [stderr] 86 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | .split("<") [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:86:10 [INFO] [stderr] | [INFO] [stderr] 86 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "317181a781d03582d4cc1b64395afb71a1106c9b74decbf0b5d97ebf7b4989e4"` [INFO] running `"docker" "rm" "-f" "317181a781d03582d4cc1b64395afb71a1106c9b74decbf0b5d97ebf7b4989e4"` [INFO] [stdout] 317181a781d03582d4cc1b64395afb71a1106c9b74decbf0b5d97ebf7b4989e4