[INFO] crate mrt 0.1.2 is already in cache [INFO] extracting crate mrt 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/mrt/0.1.2 [INFO] extracting crate mrt 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mrt/0.1.2 [INFO] validating manifest of mrt-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mrt-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mrt-0.1.2 [INFO] finished frobbing mrt-0.1.2 [INFO] frobbed toml for mrt-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/mrt/0.1.2/Cargo.toml [INFO] started frobbing mrt-0.1.2 [INFO] finished frobbing mrt-0.1.2 [INFO] frobbed toml for mrt-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mrt/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mrt-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mrt/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66b43ae07ebdfe3833a3cb7e542a5fa6f598bf26a5de7d2e2441d137bcec0398 [INFO] running `"docker" "start" "-a" "66b43ae07ebdfe3833a3cb7e542a5fa6f598bf26a5de7d2e2441d137bcec0398"` [INFO] [stderr] Checking mrt v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:50 [INFO] [stderr] | [INFO] [stderr] 514 | BgpAttributeValue::NOT_IMPLEMENTED { code: code }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:50 [INFO] [stderr] | [INFO] [stderr] 514 | BgpAttributeValue::NOT_IMPLEMENTED { code: code }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:647:50 [INFO] [stderr] | [INFO] [stderr] 647 | assert_eq!(message.mrt_header.timestamp, 1444842656); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_444_842_656` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:653:17 [INFO] [stderr] | [INFO] [stderr] 653 | (65000, 3232235530,"192.168.1.10", 2), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_232_235_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:654:17 [INFO] [stderr] | [INFO] [stderr] 654 | (65000, 3232235530,"2001:db8:0:1::10", 3), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_232_235_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:655:17 [INFO] [stderr] | [INFO] [stderr] 655 | (65000, 3232235622,"0.0.0.0", 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_232_235_622` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:662:42 [INFO] [stderr] | [INFO] [stderr] 662 | assert_eq!(collector_bgp_id, 3232235622); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_232_235_622` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:636:15 [INFO] [stderr] | [INFO] [stderr] 636 | while remaining.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.79s [INFO] running `"docker" "inspect" "66b43ae07ebdfe3833a3cb7e542a5fa6f598bf26a5de7d2e2441d137bcec0398"` [INFO] running `"docker" "rm" "-f" "66b43ae07ebdfe3833a3cb7e542a5fa6f598bf26a5de7d2e2441d137bcec0398"` [INFO] [stdout] 66b43ae07ebdfe3833a3cb7e542a5fa6f598bf26a5de7d2e2441d137bcec0398