[INFO] crate mrsc 0.3.1 is already in cache [INFO] extracting crate mrsc 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/mrsc/0.3.1 [INFO] extracting crate mrsc 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mrsc/0.3.1 [INFO] validating manifest of mrsc-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mrsc-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mrsc-0.3.1 [INFO] finished frobbing mrsc-0.3.1 [INFO] frobbed toml for mrsc-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/mrsc/0.3.1/Cargo.toml [INFO] started frobbing mrsc-0.3.1 [INFO] finished frobbing mrsc-0.3.1 [INFO] frobbed toml for mrsc-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mrsc/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mrsc-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mrsc/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] feb7d4443341919e19d388dbe9e084f442cd85e6751aeb73340ae6fe185641eb [INFO] running `"docker" "start" "-a" "feb7d4443341919e19d388dbe9e084f442cd85e6751aeb73340ae6fe185641eb"` [INFO] [stderr] Checking mrsc v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | rx: rx [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | rx: rx [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Server` [INFO] [stderr] --> src/lib.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn new() -> Server { [INFO] [stderr] 57 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 58 | | Server { [INFO] [stderr] 59 | | tx, [INFO] [stderr] 60 | | rx, [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for Server { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Server` [INFO] [stderr] --> src/lib.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn new() -> Server { [INFO] [stderr] 57 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 58 | | Server { [INFO] [stderr] 59 | | tx, [INFO] [stderr] 60 | | rx, [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for Server { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:347:37 [INFO] [stderr] | [INFO] [stderr] 347 | assert!(server.recv_timeout(duration.clone()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:349:39 [INFO] [stderr] | [INFO] [stderr] 349 | assert!(response.recv_timeout(duration.clone()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:351:39 [INFO] [stderr] | [INFO] [stderr] 351 | let req = server.recv_timeout(duration.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "feb7d4443341919e19d388dbe9e084f442cd85e6751aeb73340ae6fe185641eb"` [INFO] running `"docker" "rm" "-f" "feb7d4443341919e19d388dbe9e084f442cd85e6751aeb73340ae6fe185641eb"` [INFO] [stdout] feb7d4443341919e19d388dbe9e084f442cd85e6751aeb73340ae6fe185641eb