[INFO] crate mpw 0.2.1 is already in cache [INFO] extracting crate mpw 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/mpw/0.2.1 [INFO] extracting crate mpw 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mpw/0.2.1 [INFO] validating manifest of mpw-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpw-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpw-0.2.1 [INFO] finished frobbing mpw-0.2.1 [INFO] frobbed toml for mpw-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/mpw/0.2.1/Cargo.toml [INFO] started frobbing mpw-0.2.1 [INFO] finished frobbing mpw-0.2.1 [INFO] frobbed toml for mpw-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mpw/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpw-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mpw/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e29d61f012cc42705d85d7a73813be3a71238e50e4e28f9faaf54a6bf2c86ee [INFO] running `"docker" "start" "-a" "4e29d61f012cc42705d85d7a73813be3a71238e50e4e28f9faaf54a6bf2c86ee"` [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking crypto-mac v0.4.0 [INFO] [stderr] Checking hmac v0.4.2 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking mpw v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | SeedGenerator { key: key } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | SeedGenerator { key: key } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const MAGIC: &'static [u8] = b"com.lyndir.masterpassword"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | const VEC_IO_ERROR_STR: &'static str = "IO error while writing to Vec"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | pub const CHAR_CLASS_N: &'static [char] = &['0', '1', '2', '3', '4', '5', '6', '7', '8', '9']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | pub const TEMPLATES_PIN: &'static [Template] = [INFO] [stderr] | -^^^^^^^----------- help: consider removing `'static`: `&[Template]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return password; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const MAGIC: &'static [u8] = b"com.lyndir.masterpassword"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | const VEC_IO_ERROR_STR: &'static str = "IO error while writing to Vec"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | pub const CHAR_CLASS_N: &'static [char] = &['0', '1', '2', '3', '4', '5', '6', '7', '8', '9']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | pub const TEMPLATES_PIN: &'static [Template] = [INFO] [stderr] | -^^^^^^^----------- help: consider removing `'static`: `&[Template]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return password; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | const TESTS: &'static [(&'static str, &'static str, &'static str, u32, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---------------------------------------------------------------- help: consider removing `'static`: `&[(&'static str, &'static str, &'static str, u32, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | const TESTS: &'static [(&'static str, &'static str, &'static str, u32, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | const TESTS: &'static [(&'static str, &'static str, &'static str, u32, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:132:62 [INFO] [stderr] | [INFO] [stderr] 132 | const TESTS: &'static [(&'static str, &'static str, &'static str, u32, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:132:81 [INFO] [stderr] | [INFO] [stderr] 132 | const TESTS: &'static [(&'static str, &'static str, &'static str, u32, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 20.09s [INFO] running `"docker" "inspect" "4e29d61f012cc42705d85d7a73813be3a71238e50e4e28f9faaf54a6bf2c86ee"` [INFO] running `"docker" "rm" "-f" "4e29d61f012cc42705d85d7a73813be3a71238e50e4e28f9faaf54a6bf2c86ee"` [INFO] [stdout] 4e29d61f012cc42705d85d7a73813be3a71238e50e4e28f9faaf54a6bf2c86ee