[INFO] crate mpu9250-dmp 1.0.0 is already in cache [INFO] extracting crate mpu9250-dmp 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/mpu9250-dmp/1.0.0 [INFO] extracting crate mpu9250-dmp 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mpu9250-dmp/1.0.0 [INFO] validating manifest of mpu9250-dmp-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpu9250-dmp-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpu9250-dmp-1.0.0 [INFO] removed 2 missing examples [INFO] finished frobbing mpu9250-dmp-1.0.0 [INFO] frobbed toml for mpu9250-dmp-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/mpu9250-dmp/1.0.0/Cargo.toml [INFO] started frobbing mpu9250-dmp-1.0.0 [INFO] removed 2 missing examples [INFO] finished frobbing mpu9250-dmp-1.0.0 [INFO] frobbed toml for mpu9250-dmp-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mpu9250-dmp/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpu9250-dmp-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mpu9250-dmp/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0afc1848b2edc2a6b4109d9e11021d46973dc5392d158ae20f3a6c630b724abe [INFO] running `"docker" "start" "-a" "0afc1848b2edc2a6b4109d9e11021d46973dc5392d158ae20f3a6c630b724abe"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/scan.rs [INFO] [stderr] * /opt/crater/workdir/examples/scan_dmp.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking ak8963 v1.1.0 [INFO] [stderr] Checking mpu9250-dmp v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dmp.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const GYRO_SF: u32 = 46850825; [INFO] [stderr] | ^^^^^^^^ help: consider: `46_850_825` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / return match *self { [INFO] [stderr] 230 | | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 231 | | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 232 | | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 233 | | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 234 | | } / 32768.0; [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 229 | match *self { [INFO] [stderr] 230 | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 231 | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 232 | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 233 | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 234 | } / 32768.0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / return match *self { [INFO] [stderr] 242 | | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 243 | | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 244 | | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 245 | | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 246 | | } * G / 32768.0; [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 241 | match *self { [INFO] [stderr] 242 | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 243 | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 244 | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 245 | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 246 | } * G / 32768.0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / return match *self { [INFO] [stderr] 277 | | GyroFsr::Opt250 => 250.0, [INFO] [stderr] 278 | | GyroFsr::Opt500 => 500.0, [INFO] [stderr] 279 | | GyroFsr::Opt1000 => 1000.0, [INFO] [stderr] 280 | | GyroFsr::Opt2000 => 2000.0, [INFO] [stderr] 281 | | } / 32768.0; [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 276 | match *self { [INFO] [stderr] 277 | GyroFsr::Opt250 => 250.0, [INFO] [stderr] 278 | GyroFsr::Opt500 => 500.0, [INFO] [stderr] 279 | GyroFsr::Opt1000 => 1000.0, [INFO] [stderr] 280 | GyroFsr::Opt2000 => 2000.0, [INFO] [stderr] 281 | } / 32768.0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dmp.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const GYRO_SF: u32 = 46850825; [INFO] [stderr] | ^^^^^^^^ help: consider: `46_850_825` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / return match *self { [INFO] [stderr] 230 | | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 231 | | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 232 | | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 233 | | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 234 | | } / 32768.0; [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 229 | match *self { [INFO] [stderr] 230 | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 231 | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 232 | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 233 | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 234 | } / 32768.0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / return match *self { [INFO] [stderr] 242 | | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 243 | | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 244 | | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 245 | | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 246 | | } * G / 32768.0; [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 241 | match *self { [INFO] [stderr] 242 | AccelFsr::Opt2G => 2.0, [INFO] [stderr] 243 | AccelFsr::Opt4G => 4.0, [INFO] [stderr] 244 | AccelFsr::Opt8G => 8.0, [INFO] [stderr] 245 | AccelFsr::Opt16G => 16.0, [INFO] [stderr] 246 | } * G / 32768.0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / return match *self { [INFO] [stderr] 277 | | GyroFsr::Opt250 => 250.0, [INFO] [stderr] 278 | | GyroFsr::Opt500 => 500.0, [INFO] [stderr] 279 | | GyroFsr::Opt1000 => 1000.0, [INFO] [stderr] 280 | | GyroFsr::Opt2000 => 2000.0, [INFO] [stderr] 281 | | } / 32768.0; [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 276 | match *self { [INFO] [stderr] 277 | GyroFsr::Opt250 => 250.0, [INFO] [stderr] 278 | GyroFsr::Opt500 => 500.0, [INFO] [stderr] 279 | GyroFsr::Opt1000 => 1000.0, [INFO] [stderr] 280 | GyroFsr::Opt2000 => 2000.0, [INFO] [stderr] 281 | } / 32768.0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dmp.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:134:34 [INFO] [stderr] | [INFO] [stderr] 134 | if (((mem_addr & 0xFF) + (length as u16)) as usize) > MPU6500_BANK_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dmp.rs:256:22 [INFO] [stderr] | [INFO] [stderr] 256 | .map_err(|e| DmpFifoReadError::Read(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DmpFifoReadError::Read` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | q_data[0] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | q_data[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | q_data[2] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | q_data[3] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:228:30 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn get_sensitivity_g(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:238:32 [INFO] [stderr] | [INFO] [stderr] 238 | pub fn get_sensitivity_mss(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:275:23 [INFO] [stderr] | [INFO] [stderr] 275 | pub fn get_scalar(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:352:25 [INFO] [stderr] | [INFO] [stderr] 352 | let accel_fsr = self.accel_fsr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.accel_fsr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:354:24 [INFO] [stderr] | [INFO] [stderr] 354 | let gyro_fsr = self.gyro_fsr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.gyro_fsr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dmp.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:456:62 [INFO] [stderr] | [INFO] [stderr] 456 | let accel_v = accel_fsr_scalar * accel_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:457:59 [INFO] [stderr] | [INFO] [stderr] 457 | let gyro_v = gyro_fsr_scalar * gyro_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:134:34 [INFO] [stderr] | [INFO] [stderr] 134 | if (((mem_addr & 0xFF) + (length as u16)) as usize) > MPU6500_BANK_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:480:62 [INFO] [stderr] | [INFO] [stderr] 480 | let accel_v = accel_fsr_scalar * accel_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:481:59 [INFO] [stderr] | [INFO] [stderr] 481 | let gyro_v = gyro_fsr_scalar * gyro_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dmp.rs:256:22 [INFO] [stderr] | [INFO] [stderr] 256 | .map_err(|e| DmpFifoReadError::Read(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DmpFifoReadError::Read` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | q_data[0] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | q_data[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | q_data[2] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/dmp.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | q_data[3] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(q_data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:676:9 [INFO] [stderr] | [INFO] [stderr] 676 | data[0] = data[0] & 0x1f; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[0] &= 0x1f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:228:30 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn get_sensitivity_g(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:238:32 [INFO] [stderr] | [INFO] [stderr] 238 | pub fn get_sensitivity_mss(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:275:23 [INFO] [stderr] | [INFO] [stderr] 275 | pub fn get_scalar(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:352:25 [INFO] [stderr] | [INFO] [stderr] 352 | let accel_fsr = self.accel_fsr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.accel_fsr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:354:24 [INFO] [stderr] | [INFO] [stderr] 354 | let gyro_fsr = self.gyro_fsr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.gyro_fsr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:456:62 [INFO] [stderr] | [INFO] [stderr] 456 | let accel_v = accel_fsr_scalar * accel_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:457:59 [INFO] [stderr] | [INFO] [stderr] 457 | let gyro_v = gyro_fsr_scalar * gyro_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:480:62 [INFO] [stderr] | [INFO] [stderr] 480 | let accel_v = accel_fsr_scalar * accel_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:481:59 [INFO] [stderr] | [INFO] [stderr] 481 | let gyro_v = gyro_fsr_scalar * gyro_v_raw.map(|e| *e as f32); [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:676:9 [INFO] [stderr] | [INFO] [stderr] 676 | data[0] = data[0] & 0x1f; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[0] &= 0x1f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.65s [INFO] running `"docker" "inspect" "0afc1848b2edc2a6b4109d9e11021d46973dc5392d158ae20f3a6c630b724abe"` [INFO] running `"docker" "rm" "-f" "0afc1848b2edc2a6b4109d9e11021d46973dc5392d158ae20f3a6c630b724abe"` [INFO] [stdout] 0afc1848b2edc2a6b4109d9e11021d46973dc5392d158ae20f3a6c630b724abe