[INFO] crate mpegts 0.1.2 is already in cache [INFO] extracting crate mpegts 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/mpegts/0.1.2 [INFO] extracting crate mpegts 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mpegts/0.1.2 [INFO] validating manifest of mpegts-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpegts-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpegts-0.1.2 [INFO] finished frobbing mpegts-0.1.2 [INFO] frobbed toml for mpegts-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/mpegts/0.1.2/Cargo.toml [INFO] started frobbing mpegts-0.1.2 [INFO] finished frobbing mpegts-0.1.2 [INFO] frobbed toml for mpegts-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mpegts/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpegts-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mpegts/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cb8e7f8d75ab876a8b92cfea772b9fb56d947c8593f12b6edc6ec4f55f103a8 [INFO] running `"docker" "start" "-a" "8cb8e7f8d75ab876a8b92cfea772b9fb56d947c8593f12b6edc6ec4f55f103a8"` [INFO] [stderr] Checking bitstream-io v0.6.5 [INFO] [stderr] Checking mpegts v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | transport_error_indicator: transport_error_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_error_indicator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | transport_priority: transport_priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:48:7 [INFO] [stderr] | [INFO] [stderr] 48 | program_id: program_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | transport_scrambling_control: transport_scrambling_control, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_scrambling_control` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | continuity_counter: continuity_counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `continuity_counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | payload_presence: payload_presence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payload_presence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | discontinuity_indicator: discontinuity_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `discontinuity_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | random_access_indicator: random_access_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `random_access_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | elementary_stream_priority_indicator: elementary_stream_priority_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elementary_stream_priority_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pcr: pcr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pcr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | opcr: opcr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opcr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | splice_countdown: splice_countdown, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `splice_countdown` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | transport_private_data: transport_private_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_private_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | adaptation_field_extension: adaptation_field_extension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adaptation_field_extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | legal_time_window: legal_time_window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `legal_time_window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | piecewise_rate: piecewise_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piecewise_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | seamless_splice: seamless_splice, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seamless_splice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/program_clock.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/program_clock.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | extension: extension [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | program_number: program_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | transport_stream_id: transport_stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | elementary_pid: elementary_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elementary_pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | pcr_pid: pcr_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pcr_pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | programs: programs [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `programs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:246:15 [INFO] [stderr] | [INFO] [stderr] 246 | info: info [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | scrambling_control: scrambling_control, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scrambling_control` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | data_alignment_indicator: data_alignment_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_alignment_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | copyright: copyright, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copyright` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | original: original, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `original` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | pts: pts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | dts: dts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | escr: escr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `escr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | es_rate: es_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `es_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | dsm_trick_mode: dsm_trick_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dsm_trick_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | additional_copy_info: additional_copy_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additional_copy_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | previous_pes_packet_crc: previous_pes_packet_crc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_pes_packet_crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | pes_extension: pes_extension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pes_extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | pes_header_length: pes_header_length [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pes_header_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:321:9 [INFO] [stderr] | [INFO] [stderr] 321 | additional_data: additional_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additional_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:350:5 [INFO] [stderr] | [INFO] [stderr] 350 | pat: pat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | pmt: pmt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:352:5 [INFO] [stderr] | [INFO] [stderr] 352 | pes: pes [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/aac.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | profile_and_level: profile_and_level, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `profile_and_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/aac.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | aac_type: aac_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aac_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/aac.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | additional_info: additional_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additional_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/hevc.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | profile_space: profile_space, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `profile_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/continuity_pcr.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | program_id: program_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/continuity_pcr.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | pcr: pcr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pcr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/continuity_pcr.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wrapper/wrapper.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | program_number: program_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | transport_error_indicator: transport_error_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_error_indicator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | transport_priority: transport_priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:48:7 [INFO] [stderr] | [INFO] [stderr] 48 | program_id: program_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | transport_scrambling_control: transport_scrambling_control, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_scrambling_control` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | continuity_counter: continuity_counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `continuity_counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/packet.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | payload_presence: payload_presence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payload_presence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | discontinuity_indicator: discontinuity_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `discontinuity_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | random_access_indicator: random_access_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `random_access_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | elementary_stream_priority_indicator: elementary_stream_priority_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elementary_stream_priority_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pcr: pcr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pcr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | opcr: opcr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opcr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | splice_countdown: splice_countdown, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `splice_countdown` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | transport_private_data: transport_private_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_private_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | adaptation_field_extension: adaptation_field_extension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adaptation_field_extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | legal_time_window: legal_time_window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `legal_time_window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | piecewise_rate: piecewise_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piecewise_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | seamless_splice: seamless_splice, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seamless_splice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/program_clock.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/program_clock.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | extension: extension [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:47:7 [INFO] [stderr] | [INFO] [stderr] 47 | program_number: program_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | transport_stream_id: transport_stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | elementary_pid: elementary_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elementary_pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | pcr_pid: pcr_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pcr_pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | programs: programs [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `programs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:246:15 [INFO] [stderr] | [INFO] [stderr] 246 | info: info [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | scrambling_control: scrambling_control, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scrambling_control` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | data_alignment_indicator: data_alignment_indicator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_alignment_indicator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | copyright: copyright, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copyright` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | original: original, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `original` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | pts: pts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | dts: dts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | escr: escr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `escr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | es_rate: es_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `es_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | dsm_trick_mode: dsm_trick_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dsm_trick_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | additional_copy_info: additional_copy_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additional_copy_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | previous_pes_packet_crc: previous_pes_packet_crc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_pes_packet_crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | pes_extension: pes_extension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pes_extension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | pes_header_length: pes_header_length [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pes_header_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:321:9 [INFO] [stderr] | [INFO] [stderr] 321 | additional_data: additional_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additional_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:350:5 [INFO] [stderr] | [INFO] [stderr] 350 | pat: pat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | pmt: pmt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/payload.rs:352:5 [INFO] [stderr] | [INFO] [stderr] 352 | pes: pes [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/aac.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | profile_and_level: profile_and_level, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `profile_and_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/aac.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | aac_type: aac_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aac_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/aac.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | additional_info: additional_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additional_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/descriptor/hevc.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | profile_space: profile_space, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `profile_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/continuity_pcr.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | program_id: program_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/continuity_pcr.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | pcr: pcr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pcr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer/continuity_pcr.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wrapper/wrapper.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | program_number: program_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpegts/program_clock.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return self.base * 300 + self.extension as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.base * 300 + self.extension as u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/payload.rs:183:23 [INFO] [stderr] | [INFO] [stderr] 183 | ((pts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/payload.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | ((dts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/payload.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ((escr_extension as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser/stream_id.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 37 | | if (stream_id >= 0xe0) && (stream_id <= 0xef) { [INFO] [stderr] 38 | | StreamId::VideoStream{id: stream_id} [INFO] [stderr] 39 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 36 | } else if (stream_id >= 0xe0) && (stream_id <= 0xef) { [INFO] [stderr] 37 | StreamId::VideoStream{id: stream_id} [INFO] [stderr] 38 | } else { [INFO] [stderr] 39 | println!("Unknown Stream ID {:?}", stream_id); [INFO] [stderr] 40 | StreamId::Unknown [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | 01 => ProgramDescriptor::Forbidden, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 7 | 1 => ProgramDescriptor::Forbidden, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 7 | 0o1 => ProgramDescriptor::Forbidden, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | 02 => ProgramDescriptor::Video_Stream, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 8 | 2 => ProgramDescriptor::Video_Stream, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 8 | 0o2 => ProgramDescriptor::Video_Stream, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | 03 => ProgramDescriptor::Audio_Stream, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 9 | 3 => ProgramDescriptor::Audio_Stream, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 9 | 0o3 => ProgramDescriptor::Audio_Stream, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | 04 => ProgramDescriptor::Hierarchy, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 10 | 4 => ProgramDescriptor::Hierarchy, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 10 | 0o4 => ProgramDescriptor::Hierarchy, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | 05 => ProgramDescriptor::Registration, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 11 | 5 => ProgramDescriptor::Registration, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 11 | 0o5 => ProgramDescriptor::Registration, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | 06 => ProgramDescriptor::Data_Stream_Alignment, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 12 | 6 => ProgramDescriptor::Data_Stream_Alignment, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 12 | 0o6 => ProgramDescriptor::Data_Stream_Alignment, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 07 => ProgramDescriptor::Target_Background_Grid, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 13 | 7 => ProgramDescriptor::Target_Background_Grid, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 13 | 0o7 => ProgramDescriptor::Target_Background_Grid, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 08 => ProgramDescriptor::Video_Window, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 14 | 8 => ProgramDescriptor::Video_Window, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 14 | 0o8 => ProgramDescriptor::Video_Window, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | 09 => ProgramDescriptor::CA_Descriptor, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 15 | 9 => ProgramDescriptor::CA_Descriptor, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 15 | 0o9 => ProgramDescriptor::CA_Descriptor, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/program_clock.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | stream.write(6, 0b111111).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/payload.rs:202:40 [INFO] [stderr] | [INFO] [stderr] 202 | writer.write(22, es_rate & 0x3FFFFF).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/wrapper/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod wrapper; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpegts/program_clock.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return self.base * 300 + self.extension as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.base * 300 + self.extension as u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/payload.rs:183:23 [INFO] [stderr] | [INFO] [stderr] 183 | ((pts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/payload.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | ((dts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/payload.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ((escr_extension as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser/stream_id.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 37 | | if (stream_id >= 0xe0) && (stream_id <= 0xef) { [INFO] [stderr] 38 | | StreamId::VideoStream{id: stream_id} [INFO] [stderr] 39 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 36 | } else if (stream_id >= 0xe0) && (stream_id <= 0xef) { [INFO] [stderr] 37 | StreamId::VideoStream{id: stream_id} [INFO] [stderr] 38 | } else { [INFO] [stderr] 39 | println!("Unknown Stream ID {:?}", stream_id); [INFO] [stderr] 40 | StreamId::Unknown [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | 01 => ProgramDescriptor::Forbidden, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 7 | 1 => ProgramDescriptor::Forbidden, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 7 | 0o1 => ProgramDescriptor::Forbidden, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | 02 => ProgramDescriptor::Video_Stream, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 8 | 2 => ProgramDescriptor::Video_Stream, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 8 | 0o2 => ProgramDescriptor::Video_Stream, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | 03 => ProgramDescriptor::Audio_Stream, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 9 | 3 => ProgramDescriptor::Audio_Stream, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 9 | 0o3 => ProgramDescriptor::Audio_Stream, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | 04 => ProgramDescriptor::Hierarchy, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 10 | 4 => ProgramDescriptor::Hierarchy, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 10 | 0o4 => ProgramDescriptor::Hierarchy, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | 05 => ProgramDescriptor::Registration, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 11 | 5 => ProgramDescriptor::Registration, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 11 | 0o5 => ProgramDescriptor::Registration, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | 06 => ProgramDescriptor::Data_Stream_Alignment, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 12 | 6 => ProgramDescriptor::Data_Stream_Alignment, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 12 | 0o6 => ProgramDescriptor::Data_Stream_Alignment, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 07 => ProgramDescriptor::Target_Background_Grid, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 13 | 7 => ProgramDescriptor::Target_Background_Grid, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 13 | 0o7 => ProgramDescriptor::Target_Background_Grid, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 08 => ProgramDescriptor::Video_Window, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 14 | 8 => ProgramDescriptor::Video_Window, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 14 | 0o8 => ProgramDescriptor::Video_Window, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser/program_descriptor.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | 09 => ProgramDescriptor::CA_Descriptor, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 15 | 9 => ProgramDescriptor::CA_Descriptor, [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 15 | 0o9 => ProgramDescriptor::CA_Descriptor, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/program_clock.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | stream.write(6, 0b111111).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer/payload.rs:202:40 [INFO] [stderr] | [INFO] [stderr] 202 | writer.write(22, es_rate & 0x3FFFFF).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/wrapper/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod wrapper; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mpegts/packet.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if self.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mpegts::packet::Packet` [INFO] [stderr] --> src/mpegts/packet.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Packet { [INFO] [stderr] 35 | | Packet { [INFO] [stderr] 36 | | transport_error_indicator: false, [INFO] [stderr] 37 | | transport_priority: false, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mpegts/program_clock.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | return self.base * 300 + self.extension as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.extension)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:36:8 [INFO] [stderr] | [INFO] [stderr] 36 | ((splice_type as u64) << 33) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(splice_type)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | ((dts_high as u64) << 30) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:38:8 [INFO] [stderr] | [INFO] [stderr] 38 | ((dts_medium as u64) << 15) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_medium)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | dts_low as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(dts_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | let program_number = ((data[0 + i * 4] as u16) << 8) + data[1 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[0 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/parser/payload.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | let program_number = ((data[0 + i * 4] as u16) << 8) + data[1 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:43:60 [INFO] [stderr] | [INFO] [stderr] 43 | let program_number = ((data[0 + i * 4] as u16) << 8) + data[1 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[1 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let program_pid = ((data[2 + i * 4] as u16 & 0x001f) << 8) + data[3 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[2 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:44:66 [INFO] [stderr] | [INFO] [stderr] 44 | let program_pid = ((data[2 + i * 4] as u16 & 0x001f) << 8) + data[3 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[3 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | let pcr_pid = ((data[0] as u16 & 0x001f) << 8) + data[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:63:52 [INFO] [stderr] | [INFO] [stderr] 63 | let pcr_pid = ((data[0] as u16 & 0x001f) << 8) + data[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | let pi_length = ((data[2] as u16 & 0x0003) << 8) + data[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:64:54 [INFO] [stderr] | [INFO] [stderr] 64 | let pi_length = ((data[2] as u16 & 0x0003) << 8) + data[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | let elementary_pid = ((data[offset+1] as u16 & 0x001f) << 8) + data[offset+2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:79:68 [INFO] [stderr] | [INFO] [stderr] 79 | let elementary_pid = ((data[offset+1] as u16 & 0x001f) << 8) + data[offset+2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let es_info_length = ((data[offset+3] as u16 & 0x0003) << 8) + data[offset+4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:80:68 [INFO] [stderr] | [INFO] [stderr] 80 | let es_info_length = ((data[offset+3] as u16 & 0x0003) << 8) + data[offset+4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:181:30 [INFO] [stderr] | [INFO] [stderr] 181 | let pts_value = ((pts_high as u64) << 30) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(pts_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | ((pts_middle as u64) << 15) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pts_middle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:183:23 [INFO] [stderr] | [INFO] [stderr] 183 | ((pts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pts_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:197:30 [INFO] [stderr] | [INFO] [stderr] 197 | let dts_value = ((dts_high as u64) << 30) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:198:24 [INFO] [stderr] | [INFO] [stderr] 198 | ((dts_middle as u64) << 15) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_middle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | ((dts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:215:31 [INFO] [stderr] | [INFO] [stderr] 215 | let escr_value = ((escr_high as u64) << 39) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | ((escr_middle as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_middle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | ((escr_low as u64) << 9) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ((escr_extension as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_extension)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:333:39 [INFO] [stderr] | [INFO] [stderr] 333 | let mut syntax_section_length = stream.read::(8).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream.read::(8).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:335:32 [INFO] [stderr] | [INFO] [stderr] 335 | syntax_section_length += ((next & 0x03) as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(next & 0x03)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/writer/packet.rs:10:64 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn write_packets(stream: &mut W, packets: &Vec, cc: &mut ContinuityCounter) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Packet]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/writer/packet.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | let _res = stream.write(&mut fill); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/adaptation_field.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | af_writer.write_bit(af.transport_private_data.len() > 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!af.transport_private_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/adaptation_field.rs:47:8 [INFO] [stderr] | [INFO] [stderr] 47 | if af.transport_private_data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!af.transport_private_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mpegts/packet.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if self.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mpegts::packet::Packet` [INFO] [stderr] --> src/mpegts/packet.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Packet { [INFO] [stderr] 35 | | Packet { [INFO] [stderr] 36 | | transport_error_indicator: false, [INFO] [stderr] 37 | | transport_priority: false, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mpegts/program_clock.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | return self.base * 300 + self.extension as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.extension)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/payload.rs:223:8 [INFO] [stderr] | [INFO] [stderr] 223 | if pes.additional_data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pes.additional_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:36:8 [INFO] [stderr] | [INFO] [stderr] 36 | ((splice_type as u64) << 33) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(splice_type)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | ((dts_high as u64) << 30) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:38:8 [INFO] [stderr] | [INFO] [stderr] 38 | ((dts_medium as u64) << 15) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_medium)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/adaptation_field_extension.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | dts_low as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(dts_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | let program_number = ((data[0 + i * 4] as u16) << 8) + data[1 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[0 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/parser/payload.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | let program_number = ((data[0 + i * 4] as u16) << 8) + data[1 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:43:60 [INFO] [stderr] | [INFO] [stderr] 43 | let program_number = ((data[0 + i * 4] as u16) << 8) + data[1 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[1 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let program_pid = ((data[2 + i * 4] as u16 & 0x001f) << 8) + data[3 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[2 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:44:66 [INFO] [stderr] | [INFO] [stderr] 44 | let program_pid = ((data[2 + i * 4] as u16 & 0x001f) << 8) + data[3 + i * 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[3 + i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | let pcr_pid = ((data[0] as u16 & 0x001f) << 8) + data[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:63:52 [INFO] [stderr] | [INFO] [stderr] 63 | let pcr_pid = ((data[0] as u16 & 0x001f) << 8) + data[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | let pi_length = ((data[2] as u16 & 0x0003) << 8) + data[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:64:54 [INFO] [stderr] | [INFO] [stderr] 64 | let pi_length = ((data[2] as u16 & 0x0003) << 8) + data[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | let elementary_pid = ((data[offset+1] as u16 & 0x001f) << 8) + data[offset+2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:79:68 [INFO] [stderr] | [INFO] [stderr] 79 | let elementary_pid = ((data[offset+1] as u16 & 0x001f) << 8) + data[offset+2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let es_info_length = ((data[offset+3] as u16 & 0x0003) << 8) + data[offset+4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:80:68 [INFO] [stderr] | [INFO] [stderr] 80 | let es_info_length = ((data[offset+3] as u16 & 0x0003) << 8) + data[offset+4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset+4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:181:30 [INFO] [stderr] | [INFO] [stderr] 181 | let pts_value = ((pts_high as u64) << 30) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(pts_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | ((pts_middle as u64) << 15) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pts_middle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:183:23 [INFO] [stderr] | [INFO] [stderr] 183 | ((pts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pts_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:197:30 [INFO] [stderr] | [INFO] [stderr] 197 | let dts_value = ((dts_high as u64) << 30) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:198:24 [INFO] [stderr] | [INFO] [stderr] 198 | ((dts_middle as u64) << 15) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_middle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | ((dts_low as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dts_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:215:31 [INFO] [stderr] | [INFO] [stderr] 215 | let escr_value = ((escr_high as u64) << 39) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | ((escr_middle as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_middle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | ((escr_low as u64) << 9) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ((escr_extension as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(escr_extension)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:333:39 [INFO] [stderr] | [INFO] [stderr] 333 | let mut syntax_section_length = stream.read::(8).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream.read::(8).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser/payload.rs:335:32 [INFO] [stderr] | [INFO] [stderr] 335 | syntax_section_length += ((next & 0x03) as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(next & 0x03)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/writer/packet.rs:10:64 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn write_packets(stream: &mut W, packets: &Vec, cc: &mut ContinuityCounter) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Packet]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/writer/packet.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | let _res = stream.write(&mut fill); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/adaptation_field.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | af_writer.write_bit(af.transport_private_data.len() > 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!af.transport_private_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/adaptation_field.rs:47:8 [INFO] [stderr] | [INFO] [stderr] 47 | if af.transport_private_data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!af.transport_private_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/payload.rs:223:8 [INFO] [stderr] | [INFO] [stderr] 223 | if pes.additional_data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pes.additional_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/pcr_measure.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | const SYSTEM_CLOCK_FREQUENCY: usize = 27000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `27_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.71s [INFO] running `"docker" "inspect" "8cb8e7f8d75ab876a8b92cfea772b9fb56d947c8593f12b6edc6ec4f55f103a8"` [INFO] running `"docker" "rm" "-f" "8cb8e7f8d75ab876a8b92cfea772b9fb56d947c8593f12b6edc6ec4f55f103a8"` [INFO] [stdout] 8cb8e7f8d75ab876a8b92cfea772b9fb56d947c8593f12b6edc6ec4f55f103a8