[INFO] crate mp3-metadata 0.3.0 is already in cache [INFO] extracting crate mp3-metadata 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/mp3-metadata/0.3.0 [INFO] extracting crate mp3-metadata 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mp3-metadata/0.3.0 [INFO] validating manifest of mp3-metadata-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mp3-metadata-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mp3-metadata-0.3.0 [INFO] finished frobbing mp3-metadata-0.3.0 [INFO] frobbed toml for mp3-metadata-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/mp3-metadata/0.3.0/Cargo.toml [INFO] started frobbing mp3-metadata-0.3.0 [INFO] finished frobbing mp3-metadata-0.3.0 [INFO] frobbed toml for mp3-metadata-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mp3-metadata/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mp3-metadata-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mp3-metadata/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da8509aadb04ee405408d7942c58286a03b68003c90e1edddd1b05efdc503327 [INFO] running `"docker" "start" "-a" "da8509aadb04ee405408d7942c58286a03b68003c90e1edddd1b05efdc503327"` [INFO] [stderr] Checking mp3-metadata v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Compiling simplemad_sys v0.5.0 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/metadata.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | let tag_size = ((buf[x + 9] as usize) & 0xFF) | [INFO] [stderr] | ________________________^ [INFO] [stderr] 47 | | (((buf[x + 8] as usize) & 0xFF) << 7) | [INFO] [stderr] 48 | | (((buf[x + 7] as usize) & 0xFF) << 14) | [INFO] [stderr] 49 | | (((buf[x + 6] as usize) & 0xFF) << 21) + 10; [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 46 | let tag_size = ((buf[x + 9] as usize) & 0xFF) | [INFO] [stderr] 47 | (((buf[x + 8] as usize) & 0xFF) << 7) | [INFO] [stderr] 48 | (((buf[x + 7] as usize) & 0xFF) << 14) | ((((buf[x + 6] as usize) & 0xFF) << 21) + 10); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | if header & 0xffe00000 == 0xffe00000 && header & (3 << 17) != 0 && [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffe0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata.rs:285:31 [INFO] [stderr] | [INFO] [stderr] 285 | if header & 0xffe00000 == 0xffe00000 && header & (3 << 17) != 0 && [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffe0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return String::from_utf16_lossy(v.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf16_lossy(v.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | buf[x] == 'T' as u8 && buf[x + 1] == 'A' as u8 && buf[x + 2] == 'G' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'T' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | buf[x] == 'T' as u8 && buf[x + 1] == 'A' as u8 && buf[x + 2] == 'G' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:16:72 [INFO] [stderr] | [INFO] [stderr] 16 | buf[x] == 'T' as u8 && buf[x + 1] == 'A' as u8 && buf[x + 2] == 'G' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'G' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | buf[x] == 'I' as u8 && buf[x + 1] == 'D' as u8 && buf[x + 2] == '3' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'I' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:38:52 [INFO] [stderr] | [INFO] [stderr] 38 | buf[x] == 'I' as u8 && buf[x + 1] == 'D' as u8 && buf[x + 2] == '3' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'D' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:38:79 [INFO] [stderr] | [INFO] [stderr] 38 | buf[x] == 'I' as u8 && buf[x + 1] == 'D' as u8 && buf[x + 2] == '3' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'3' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | let header_size = ((buf[x] as u32) << 21) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | ((buf[x + 1] as u32) << 14) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | ((buf[x + 2] as u32) << 7) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | buf[x + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/metadata.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if skip == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `buf[i]` [INFO] [stderr] --> src/metadata.rs:89:40 [INFO] [stderr] | [INFO] [stderr] 89 | if i + 1 < tag_size && (buf[i] & 0xFF) == 0xFF && buf[i + 1] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | if buf[pos] < 'A' as u8 || buf[pos] > 'Z' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:116:51 [INFO] [stderr] | [INFO] [stderr] 116 | if buf[pos] < 'A' as u8 || buf[pos] > 'Z' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:122:54 [INFO] [stderr] | [INFO] [stderr] 122 | (create_utf8_str(&buf[pos..][..3]), (buf[pos + 5] as u32 & 0xFF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:123:45 [INFO] [stderr] | [INFO] [stderr] 123 | ((buf[pos + 4] as u32 & 0xFF) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:124:45 [INFO] [stderr] | [INFO] [stderr] 124 | ((buf[pos + 3] as u32 & 0xFF) << 16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | (create_utf8_str(&buf[pos..][..4]), (buf[pos + 7] as u32 & 0xFF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:127:45 [INFO] [stderr] | [INFO] [stderr] 127 | ((buf[pos + 6] as u32 & 0xFF) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:128:45 [INFO] [stderr] | [INFO] [stderr] 128 | ((buf[pos + 5] as u32 & 0xFF) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | ((buf[pos + 4] as u32 & 0xFF) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:160:36 [INFO] [stderr] | [INFO] [stderr] 160 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/metadata.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | if changes == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `changes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:283:18 [INFO] [stderr] | [INFO] [stderr] 283 | let header = (buf[*i as usize] as u32) << 24 | (buf[*i as usize + 1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:283:52 [INFO] [stderr] | [INFO] [stderr] 283 | let header = (buf[*i as usize] as u32) << 24 | (buf[*i as usize + 1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:284:18 [INFO] [stderr] | [INFO] [stderr] 284 | (buf[*i as usize + 2] as u32) << 8 | buf[*i as usize + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:284:55 [INFO] [stderr] | [INFO] [stderr] 284 | (buf[*i as usize + 2] as u32) << 8 | buf[*i as usize + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:351:54 [INFO] [stderr] | [INFO] [stderr] 351 | frame.size = (samples_per_frame as u64 / 8 * frame.bitrate as u64 * 1000 / [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(frame.bitrate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:352:23 [INFO] [stderr] | [INFO] [stderr] 352 | frame.sampling_freq as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(frame.sampling_freq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/metadata.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / if let Some(mut fd) = File::open(file).ok() { [INFO] [stderr] 370 | | let mut buf = Vec::new(); [INFO] [stderr] 371 | | [INFO] [stderr] 372 | | match fd.read_to_end(&mut buf) { [INFO] [stderr] ... | [INFO] [stderr] 377 | | Err(Error::FileError) [INFO] [stderr] 378 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut fd)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/metadata.rs:422:8 [INFO] [stderr] | [INFO] [stderr] 422 | if meta.frames.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `meta.frames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | Version::MPEG1 => SAMPLES_PER_FRAME[0][get_layer_value(l)] as u64 * 1_000_000_000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SAMPLES_PER_FRAME[0][get_layer_value(l)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | SAMPLES_PER_FRAME[1][get_layer_value(l)] as u64 * 1_000_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SAMPLES_PER_FRAME[1][get_layer_value(l)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | big /= sample_rate as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:53:36 [INFO] [stderr] | [INFO] [stderr] 53 | let utf16 = buf.iter().map(|c| *c as u16).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | (buf[2*i+0] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/utils.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | (buf[2*i+0] as u16) << 8 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | | (buf[2*i+1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | (buf[2*i+1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/utils.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | (buf[2*i+1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:88:15 [INFO] [stderr] | [INFO] [stderr] 88 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/utils.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/utils.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | String::from_utf8(buf.to_owned()).unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `String::from_utf8(buf.to_owned()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utils.rs:104:8 [INFO] [stderr] | [INFO] [stderr] 104 | if *changes == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*changes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/utils.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | *value = Some(Url(String::from_utf8(tmp_v).unwrap_or(String::new()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `String::from_utf8(tmp_v).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/utils.rs:122:8 [INFO] [stderr] | [INFO] [stderr] 122 | if buf.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utils.rs:143:8 [INFO] [stderr] | [INFO] [stderr] 143 | if *changes == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*changes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:152:27 [INFO] [stderr] | [INFO] [stderr] 152 | let tmp_v = tmp.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utils.rs:154:12 [INFO] [stderr] | [INFO] [stderr] 154 | if entry.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entry.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utils.rs:158:8 [INFO] [stderr] | [INFO] [stderr] 158 | if *changes == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*changes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Checking simplemad v0.8.1 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basic.rs:61:49 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(meta.duration, Duration::new(12, 408162800), "duration"); [INFO] [stderr] | ^^^^^^^^^ help: consider: `408_162_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/truncate.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(meta.duration, Duration::new(12, 120815872)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_815_872` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/metadata.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | let tag_size = ((buf[x + 9] as usize) & 0xFF) | [INFO] [stderr] | ________________________^ [INFO] [stderr] 47 | | (((buf[x + 8] as usize) & 0xFF) << 7) | [INFO] [stderr] 48 | | (((buf[x + 7] as usize) & 0xFF) << 14) | [INFO] [stderr] 49 | | (((buf[x + 6] as usize) & 0xFF) << 21) + 10; [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 46 | let tag_size = ((buf[x + 9] as usize) & 0xFF) | [INFO] [stderr] 47 | (((buf[x + 8] as usize) & 0xFF) << 7) | [INFO] [stderr] 48 | (((buf[x + 7] as usize) & 0xFF) << 14) | ((((buf[x + 6] as usize) & 0xFF) << 21) + 10); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> tests/basic.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / fn basic() { [INFO] [stderr] 10 | | let meta = mp3_metadata::read_from_file("assets/test.mp3").expect("File error"); [INFO] [stderr] 11 | | let file = File::open("assets/test.mp3").unwrap(); [INFO] [stderr] 12 | | let decoder = simplemad::Decoder::decode(file).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 70 | | assert_eq!(meta.duration, sum, "time check"); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | if header & 0xffe00000 == 0xffe00000 && header & (3 << 17) != 0 && [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffe0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata.rs:285:31 [INFO] [stderr] | [INFO] [stderr] 285 | if header & 0xffe00000 == 0xffe00000 && header & (3 << 17) != 0 && [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffe0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return String::from_utf16_lossy(v.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf16_lossy(v.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in decoder.enumerate()` or similar iterators [INFO] [stderr] --> tests/basic.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | for decoding_result in decoder { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/basic.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | if meta.frames[i].sampling_freq as u32 != frame.sample_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(meta.frames[i].sampling_freq)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/basic.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | if meta.frames[i].bitrate as u32 * 1000 != frame.bit_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(meta.frames[i].bitrate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/basic.rs:27:65 [INFO] [stderr] | [INFO] [stderr] 27 | println!("[{}] [BIT_RATE] {} != {}", i, meta.frames[i].bitrate as u32 * 1000, frame.bit_rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(meta.frames[i].bitrate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | buf[x] == 'T' as u8 && buf[x + 1] == 'A' as u8 && buf[x + 2] == 'G' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'T' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | buf[x] == 'T' as u8 && buf[x + 1] == 'A' as u8 && buf[x + 2] == 'G' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:16:72 [INFO] [stderr] | [INFO] [stderr] 16 | buf[x] == 'T' as u8 && buf[x + 1] == 'A' as u8 && buf[x + 2] == 'G' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'G' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | buf[x] == 'I' as u8 && buf[x + 1] == 'D' as u8 && buf[x + 2] == '3' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'I' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:38:52 [INFO] [stderr] | [INFO] [stderr] 38 | buf[x] == 'I' as u8 && buf[x + 1] == 'D' as u8 && buf[x + 2] == '3' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'D' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:38:79 [INFO] [stderr] | [INFO] [stderr] 38 | buf[x] == 'I' as u8 && buf[x + 1] == 'D' as u8 && buf[x + 2] == '3' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'3' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | let header_size = ((buf[x] as u32) << 21) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | ((buf[x + 1] as u32) << 14) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | ((buf[x + 2] as u32) << 7) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | buf[x + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[x + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/metadata.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if skip == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `buf[i]` [INFO] [stderr] --> src/metadata.rs:89:40 [INFO] [stderr] | [INFO] [stderr] 89 | if i + 1 < tag_size && (buf[i] & 0xFF) == 0xFF && buf[i + 1] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | if buf[pos] < 'A' as u8 || buf[pos] > 'Z' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/metadata.rs:116:51 [INFO] [stderr] | [INFO] [stderr] 116 | if buf[pos] < 'A' as u8 || buf[pos] > 'Z' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:122:54 [INFO] [stderr] | [INFO] [stderr] 122 | (create_utf8_str(&buf[pos..][..3]), (buf[pos + 5] as u32 & 0xFF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:123:45 [INFO] [stderr] | [INFO] [stderr] 123 | ((buf[pos + 4] as u32 & 0xFF) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:124:45 [INFO] [stderr] | [INFO] [stderr] 124 | ((buf[pos + 3] as u32 & 0xFF) << 16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | (create_utf8_str(&buf[pos..][..4]), (buf[pos + 7] as u32 & 0xFF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:127:45 [INFO] [stderr] | [INFO] [stderr] 127 | ((buf[pos + 6] as u32 & 0xFF) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:128:45 [INFO] [stderr] | [INFO] [stderr] 128 | ((buf[pos + 5] as u32 & 0xFF) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | ((buf[pos + 4] as u32 & 0xFF) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[pos + 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:160:36 [INFO] [stderr] | [INFO] [stderr] 160 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/metadata.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | if changes == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `changes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:283:18 [INFO] [stderr] | [INFO] [stderr] 283 | let header = (buf[*i as usize] as u32) << 24 | (buf[*i as usize + 1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:283:52 [INFO] [stderr] | [INFO] [stderr] 283 | let header = (buf[*i as usize] as u32) << 24 | (buf[*i as usize + 1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:284:18 [INFO] [stderr] | [INFO] [stderr] 284 | (buf[*i as usize + 2] as u32) << 8 | buf[*i as usize + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:284:55 [INFO] [stderr] | [INFO] [stderr] 284 | (buf[*i as usize + 2] as u32) << 8 | buf[*i as usize + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[*i as usize + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:351:54 [INFO] [stderr] | [INFO] [stderr] 351 | frame.size = (samples_per_frame as u64 / 8 * frame.bitrate as u64 * 1000 / [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(frame.bitrate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:352:23 [INFO] [stderr] | [INFO] [stderr] 352 | frame.sampling_freq as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(frame.sampling_freq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/metadata.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / if let Some(mut fd) = File::open(file).ok() { [INFO] [stderr] 370 | | let mut buf = Vec::new(); [INFO] [stderr] 371 | | [INFO] [stderr] 372 | | match fd.read_to_end(&mut buf) { [INFO] [stderr] ... | [INFO] [stderr] 377 | | Err(Error::FileError) [INFO] [stderr] 378 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut fd)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/metadata.rs:422:8 [INFO] [stderr] | [INFO] [stderr] 422 | if meta.frames.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `meta.frames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | Version::MPEG1 => SAMPLES_PER_FRAME[0][get_layer_value(l)] as u64 * 1_000_000_000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SAMPLES_PER_FRAME[0][get_layer_value(l)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | SAMPLES_PER_FRAME[1][get_layer_value(l)] as u64 * 1_000_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SAMPLES_PER_FRAME[1][get_layer_value(l)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | big /= sample_rate as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:53:36 [INFO] [stderr] | [INFO] [stderr] 53 | let utf16 = buf.iter().map(|c| *c as u16).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | (buf[2*i+0] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/utils.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | (buf[2*i+0] as u16) << 8 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | | (buf[2*i+1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | (buf[2*i+1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/utils.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | (buf[2*i+1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:88:15 [INFO] [stderr] | [INFO] [stderr] 88 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2*i+0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/utils.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | | (buf[2*i+0] as u16) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/utils.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | String::from_utf8(buf.to_owned()).unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `String::from_utf8(buf.to_owned()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utils.rs:104:8 [INFO] [stderr] | [INFO] [stderr] 104 | if *changes == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*changes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/utils.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | *value = Some(Url(String::from_utf8(tmp_v).unwrap_or(String::new()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `String::from_utf8(tmp_v).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/utils.rs:122:8 [INFO] [stderr] | [INFO] [stderr] 122 | if buf.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utils.rs:143:8 [INFO] [stderr] | [INFO] [stderr] 143 | if *changes == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*changes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:152:27 [INFO] [stderr] | [INFO] [stderr] 152 | let tmp_v = tmp.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utils.rs:154:12 [INFO] [stderr] | [INFO] [stderr] 154 | if entry.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entry.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/utils.rs:158:8 [INFO] [stderr] | [INFO] [stderr] 158 | if *changes == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*changes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused variable: `meta` [INFO] [stderr] --> tests/error_check.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let meta = mp3_metadata::read_from_file("assets/error.mp3");//.expect("File error"); [INFO] [stderr] | ^^^^ help: consider using `_meta` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/invalid_time.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if meta.frames[i].sampling_freq as u32 != frame.sample_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(meta.frames[i].sampling_freq)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/invalid_time.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | if meta.frames[i].bitrate as u32 * 1000 != frame.bit_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(meta.frames[i].bitrate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/invalid_time.rs:35:61 [INFO] [stderr] | [INFO] [stderr] 35 | println!("[{}] [BIT_RATE] {} != {}", i, meta.frames[i].bitrate as u32 * 1000, frame.bit_rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(meta.frames[i].bitrate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.43s [INFO] running `"docker" "inspect" "da8509aadb04ee405408d7942c58286a03b68003c90e1edddd1b05efdc503327"` [INFO] running `"docker" "rm" "-f" "da8509aadb04ee405408d7942c58286a03b68003c90e1edddd1b05efdc503327"` [INFO] [stdout] da8509aadb04ee405408d7942c58286a03b68003c90e1edddd1b05efdc503327