[INFO] crate mozversion 0.1.3 is already in cache
[INFO] extracting crate mozversion 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/mozversion/0.1.3
[INFO] extracting crate mozversion 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mozversion/0.1.3
[INFO] validating manifest of mozversion-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mozversion-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mozversion-0.1.3
[INFO] finished frobbing mozversion-0.1.3
[INFO] frobbed toml for mozversion-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/mozversion/0.1.3/Cargo.toml
[INFO] started frobbing mozversion-0.1.3
[INFO] finished frobbing mozversion-0.1.3
[INFO] frobbed toml for mozversion-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mozversion/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mozversion-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mozversion/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] af69426bfa45bbc5ac7fbd54ef76d1b50c9c7313e9678d9047029c1724092679
[INFO] running `"docker" "start" "-a" "af69426bfa45bbc5ac7fbd54ef76d1b50c9c7313e9678d9047029c1724092679"`
[INFO] [stderr]     Checking rust-ini v0.10.3
[INFO] [stderr]     Checking mozversion v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:92:5
[INFO] [stderr]     |
[INFO] [stderr] 92  | /     pub fn from_str(version_string: &str) -> Result<Version, Error> {
[INFO] [stderr] 93  | |         let mut version: Version = Default::default();
[INFO] [stderr] 94  | |         let version_re = Regex::new(r"^(?P<major>\d+)\.(?P<minor>\d+)(?:\.(?P<patch>\d+))?(?:(?P<pre0>[a-z]+)(?P<pre1>\d*))?$").unwrap();
[INFO] [stderr] 95  | |         if let Some(captures) = version_re.captures(version_string) {
[INFO] [stderr] ...   |
[INFO] [stderr] 126 | |         Ok(version)
[INFO] [stderr] 127 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 | /             match captures.name("patch")
[INFO] [stderr] 107 | |                 .and_then(|x| u64::from_str(x.as_str()).ok()) {
[INFO] [stderr] 108 | |                     Some(x) => version.patch = x,
[INFO] [stderr] 109 | |                     None => {}
[INFO] [stderr] 110 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 106 |             if let Some(x) = captures.name("patch")
[INFO] [stderr] 107 |                 .and_then(|x| u64::from_str(x.as_str()).ok()) { version.patch = x }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 | /         match self {
[INFO] [stderr] 216 | |             &Error::VersionError(ref x) => {
[INFO] [stderr] 217 | |                 try!("VersionError: ".fmt(f));
[INFO] [stderr] 218 | |                 x.fmt(f)
[INFO] [stderr] ...   |
[INFO] [stderr] 227 | |             }
[INFO] [stderr] 228 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 215 |         match *self {
[INFO] [stderr] 216 |             Error::VersionError(ref x) => {
[INFO] [stderr] 217 |                 try!("VersionError: ".fmt(f));
[INFO] [stderr] 218 |                 x.fmt(f)
[INFO] [stderr] 219 |             },
[INFO] [stderr] 220 |             Error::MetadataError(ref x) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 | /         match self {
[INFO] [stderr] 241 | |             &Error::VersionError(ref x) => &*x,
[INFO] [stderr] 242 | |             &Error::MetadataError(ref x) => &*x,
[INFO] [stderr] 243 | |             &Error::SemVerError(ref e) => e.description(),
[INFO] [stderr] 244 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 240 |         match *self {
[INFO] [stderr] 241 |             Error::VersionError(ref x) => &*x,
[INFO] [stderr] 242 |             Error::MetadataError(ref x) => &*x,
[INFO] [stderr] 243 |             Error::SemVerError(ref e) => e.description(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:248:9
[INFO] [stderr]     |
[INFO] [stderr] 248 | /         match self {
[INFO] [stderr] 249 | |             &Error::SemVerError(ref e) => Some(e),
[INFO] [stderr] 250 | |             _ => None,
[INFO] [stderr] 251 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 248 |         match *self {
[INFO] [stderr] 249 |             Error::SemVerError(ref e) => Some(e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:92:5
[INFO] [stderr]     |
[INFO] [stderr] 92  | /     pub fn from_str(version_string: &str) -> Result<Version, Error> {
[INFO] [stderr] 93  | |         let mut version: Version = Default::default();
[INFO] [stderr] 94  | |         let version_re = Regex::new(r"^(?P<major>\d+)\.(?P<minor>\d+)(?:\.(?P<patch>\d+))?(?:(?P<pre0>[a-z]+)(?P<pre1>\d*))?$").unwrap();
[INFO] [stderr] 95  | |         if let Some(captures) = version_re.captures(version_string) {
[INFO] [stderr] ...   |
[INFO] [stderr] 126 | |         Ok(version)
[INFO] [stderr] 127 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 | /             match captures.name("patch")
[INFO] [stderr] 107 | |                 .and_then(|x| u64::from_str(x.as_str()).ok()) {
[INFO] [stderr] 108 | |                     Some(x) => version.patch = x,
[INFO] [stderr] 109 | |                     None => {}
[INFO] [stderr] 110 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 106 |             if let Some(x) = captures.name("patch")
[INFO] [stderr] 107 |                 .and_then(|x| u64::from_str(x.as_str()).ok()) { version.patch = x }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 | /         match self {
[INFO] [stderr] 216 | |             &Error::VersionError(ref x) => {
[INFO] [stderr] 217 | |                 try!("VersionError: ".fmt(f));
[INFO] [stderr] 218 | |                 x.fmt(f)
[INFO] [stderr] ...   |
[INFO] [stderr] 227 | |             }
[INFO] [stderr] 228 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 215 |         match *self {
[INFO] [stderr] 216 |             Error::VersionError(ref x) => {
[INFO] [stderr] 217 |                 try!("VersionError: ".fmt(f));
[INFO] [stderr] 218 |                 x.fmt(f)
[INFO] [stderr] 219 |             },
[INFO] [stderr] 220 |             Error::MetadataError(ref x) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 | /         match self {
[INFO] [stderr] 241 | |             &Error::VersionError(ref x) => &*x,
[INFO] [stderr] 242 | |             &Error::MetadataError(ref x) => &*x,
[INFO] [stderr] 243 | |             &Error::SemVerError(ref e) => e.description(),
[INFO] [stderr] 244 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 240 |         match *self {
[INFO] [stderr] 241 |             Error::VersionError(ref x) => &*x,
[INFO] [stderr] 242 |             Error::MetadataError(ref x) => &*x,
[INFO] [stderr] 243 |             Error::SemVerError(ref e) => e.description(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:248:9
[INFO] [stderr]     |
[INFO] [stderr] 248 | /         match self {
[INFO] [stderr] 249 | |             &Error::SemVerError(ref e) => Some(e),
[INFO] [stderr] 250 | |             _ => None,
[INFO] [stderr] 251 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 248 |         match *self {
[INFO] [stderr] 249 |             Error::SemVerError(ref e) => Some(e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.71s
[INFO] running `"docker" "inspect" "af69426bfa45bbc5ac7fbd54ef76d1b50c9c7313e9678d9047029c1724092679"`
[INFO] running `"docker" "rm" "-f" "af69426bfa45bbc5ac7fbd54ef76d1b50c9c7313e9678d9047029c1724092679"`
[INFO] [stdout] af69426bfa45bbc5ac7fbd54ef76d1b50c9c7313e9678d9047029c1724092679