[INFO] crate mozangle 0.1.7 is already in cache [INFO] extracting crate mozangle 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/mozangle/0.1.7 [INFO] extracting crate mozangle 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mozangle/0.1.7 [INFO] validating manifest of mozangle-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mozangle-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mozangle-0.1.7 [INFO] finished frobbing mozangle-0.1.7 [INFO] frobbed toml for mozangle-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/mozangle/0.1.7/Cargo.toml [INFO] started frobbing mozangle-0.1.7 [INFO] finished frobbing mozangle-0.1.7 [INFO] frobbed toml for mozangle-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mozangle/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mozangle-0.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mozangle/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed80f77b68dace73425945213aeb119850631b2be18b6eaeed3ee480ce353dd2 [INFO] running `"docker" "start" "-a" "ed80f77b68dace73425945213aeb119850631b2be18b6eaeed3ee480ce353dd2"` [INFO] [stderr] Compiling mozangle v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:66:58 [INFO] [stderr] | [INFO] [stderr] 66 | pub const SH_REGENERATE_STRUCT_NAMES: ShCompileOptions = 131072; [INFO] [stderr] | ^^^^^^ help: consider: `131_072` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | pub const SH_DONT_PRUNE_UNUSED_FUNCTIONS: ShCompileOptions = 262144; [INFO] [stderr] | ^^^^^^ help: consider: `262_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:68:68 [INFO] [stderr] | [INFO] [stderr] 68 | pub const SH_REMOVE_POW_WITH_CONSTANT_EXPONENT: ShCompileOptions = 524288; [INFO] [stderr] | ^^^^^^ help: consider: `524_288` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:69:57 [INFO] [stderr] | [INFO] [stderr] 69 | pub const SH_REWRITE_DO_WHILE_LOOPS: ShCompileOptions = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:70:77 [INFO] [stderr] | [INFO] [stderr] 70 | pub const SH_EXPAND_SELECT_HLSL_INTEGER_POW_EXPRESSIONS: ShCompileOptions = 2097152; [INFO] [stderr] | ^^^^^^^ help: consider: `2_097_152` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:71:69 [INFO] [stderr] | [INFO] [stderr] 71 | pub const SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL: ShCompileOptions = 4194304; [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_304` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:72:73 [INFO] [stderr] | [INFO] [stderr] 72 | pub const SH_HLSL_GET_DIMENSIONS_IGNORES_BASE_LEVEL: ShCompileOptions = 8388608; [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:73:73 [INFO] [stderr] | [INFO] [stderr] 73 | pub const SH_REWRITE_TEXELFETCHOFFSET_TO_TEXELFETCH: ShCompileOptions = 16777216; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:74:65 [INFO] [stderr] | [INFO] [stderr] 74 | pub const SH_ADD_AND_TRUE_TO_LOOP_CONDITION: ShCompileOptions = 33554432; [INFO] [stderr] | ^^^^^^^^ help: consider: `33_554_432` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:75:71 [INFO] [stderr] | [INFO] [stderr] 75 | pub const SH_REWRITE_INTEGER_UNARY_MINUS_OPERATOR: ShCompileOptions = 67108864; [INFO] [stderr] | ^^^^^^^^ help: consider: `67_108_864` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:76:63 [INFO] [stderr] | [INFO] [stderr] 76 | pub const SH_EMULATE_ISNAN_FLOAT_FUNCTION: ShCompileOptions = 134217728; [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:77:68 [INFO] [stderr] | [INFO] [stderr] 77 | pub const SH_USE_UNUSED_STANDARD_SHARED_BLOCKS: ShCompileOptions = 268435456; [INFO] [stderr] | ^^^^^^^^^ help: consider: `268_435_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:78:69 [INFO] [stderr] | [INFO] [stderr] 78 | pub const SH_REWRITE_FLOAT_UNARY_MINUS_OPERATOR: ShCompileOptions = 536870912; [INFO] [stderr] | ^^^^^^^^^ help: consider: `536_870_912` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:79:63 [INFO] [stderr] | [INFO] [stderr] 79 | pub const SH_EMULATE_ATAN2_FLOAT_FUNCTION: ShCompileOptions = 1073741824; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:66:58 [INFO] [stderr] | [INFO] [stderr] 66 | pub const SH_REGENERATE_STRUCT_NAMES: ShCompileOptions = 131072; [INFO] [stderr] | ^^^^^^ help: consider: `131_072` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | pub const SH_DONT_PRUNE_UNUSED_FUNCTIONS: ShCompileOptions = 262144; [INFO] [stderr] | ^^^^^^ help: consider: `262_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:68:68 [INFO] [stderr] | [INFO] [stderr] 68 | pub const SH_REMOVE_POW_WITH_CONSTANT_EXPONENT: ShCompileOptions = 524288; [INFO] [stderr] | ^^^^^^ help: consider: `524_288` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:69:57 [INFO] [stderr] | [INFO] [stderr] 69 | pub const SH_REWRITE_DO_WHILE_LOOPS: ShCompileOptions = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:70:77 [INFO] [stderr] | [INFO] [stderr] 70 | pub const SH_EXPAND_SELECT_HLSL_INTEGER_POW_EXPRESSIONS: ShCompileOptions = 2097152; [INFO] [stderr] | ^^^^^^^ help: consider: `2_097_152` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:71:69 [INFO] [stderr] | [INFO] [stderr] 71 | pub const SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL: ShCompileOptions = 4194304; [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_304` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:72:73 [INFO] [stderr] | [INFO] [stderr] 72 | pub const SH_HLSL_GET_DIMENSIONS_IGNORES_BASE_LEVEL: ShCompileOptions = 8388608; [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:73:73 [INFO] [stderr] | [INFO] [stderr] 73 | pub const SH_REWRITE_TEXELFETCHOFFSET_TO_TEXELFETCH: ShCompileOptions = 16777216; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:74:65 [INFO] [stderr] | [INFO] [stderr] 74 | pub const SH_ADD_AND_TRUE_TO_LOOP_CONDITION: ShCompileOptions = 33554432; [INFO] [stderr] | ^^^^^^^^ help: consider: `33_554_432` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:75:71 [INFO] [stderr] | [INFO] [stderr] 75 | pub const SH_REWRITE_INTEGER_UNARY_MINUS_OPERATOR: ShCompileOptions = 67108864; [INFO] [stderr] | ^^^^^^^^ help: consider: `67_108_864` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:76:63 [INFO] [stderr] | [INFO] [stderr] 76 | pub const SH_EMULATE_ISNAN_FLOAT_FUNCTION: ShCompileOptions = 134217728; [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:77:68 [INFO] [stderr] | [INFO] [stderr] 77 | pub const SH_USE_UNUSED_STANDARD_SHARED_BLOCKS: ShCompileOptions = 268435456; [INFO] [stderr] | ^^^^^^^^^ help: consider: `268_435_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:78:69 [INFO] [stderr] | [INFO] [stderr] 78 | pub const SH_REWRITE_FLOAT_UNARY_MINUS_OPERATOR: ShCompileOptions = 536870912; [INFO] [stderr] | ^^^^^^^^^ help: consider: `536_870_912` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shaders/bindings.rs:79:63 [INFO] [stderr] | [INFO] [stderr] 79 | pub const SH_EMULATE_ATAN2_FLOAT_FUNCTION: ShCompileOptions = 1073741824; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | const SHADER: &'static str = "void main() { [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | const EXPECTED: &'static str = "void main(){ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | const SHADER: &'static str = "void main() { [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | const EXPECTED: &'static str = "void main(){ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 78 [INFO] [stderr] --> src/shaders/bindings.rs:180:1 [INFO] [stderr] | [INFO] [stderr] 180 | / fn bindgen_test_layout_ShBuiltInResources() { [INFO] [stderr] 181 | | assert_eq!( [INFO] [stderr] 182 | | ::std::mem::size_of::(), [INFO] [stderr] 183 | | 320usize, [INFO] [stderr] ... | [INFO] [stderr] 1143 | | ); [INFO] [stderr] 1144 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 03s [INFO] running `"docker" "inspect" "ed80f77b68dace73425945213aeb119850631b2be18b6eaeed3ee480ce353dd2"` [INFO] running `"docker" "rm" "-f" "ed80f77b68dace73425945213aeb119850631b2be18b6eaeed3ee480ce353dd2"` [INFO] [stdout] ed80f77b68dace73425945213aeb119850631b2be18b6eaeed3ee480ce353dd2