[INFO] crate moz_cbor 0.1.1 is already in cache [INFO] extracting crate moz_cbor 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/moz_cbor/0.1.1 [INFO] extracting crate moz_cbor 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moz_cbor/0.1.1 [INFO] validating manifest of moz_cbor-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moz_cbor-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moz_cbor-0.1.1 [INFO] finished frobbing moz_cbor-0.1.1 [INFO] frobbed toml for moz_cbor-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/moz_cbor/0.1.1/Cargo.toml [INFO] started frobbing moz_cbor-0.1.1 [INFO] finished frobbing moz_cbor-0.1.1 [INFO] frobbed toml for moz_cbor-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moz_cbor/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moz_cbor-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/moz_cbor/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd83766ee94f33147259124c08ec819e7d268bdb8e1aff9f506060df16344a30 [INFO] running `"docker" "start" "-a" "fd83766ee94f33147259124c08ec819e7d268bdb8e1aff9f506060df16344a30"` [INFO] [stderr] Checking moz_cbor v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/test_decoder.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_decoder.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | test_integer_all(bytes, 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_decoder.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | test_integer_all(bytes, 1000000000000); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_decoder.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | test_integer_all(bytes, 18446744073709551615); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_decoder.rs:172:52 [INFO] [stderr] | [INFO] [stderr] 172 | CborType::Array(vec![CborType::Integer(1234567890)])]) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_decoder.rs:201:45 [INFO] [stderr] | [INFO] [stderr] 201 | let expected = CborType::SignedInteger(-100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_decoder.rs:205:45 [INFO] [stderr] | [INFO] [stderr] 205 | let expected = CborType::SignedInteger(-1000000000000); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_serializer.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | value: -1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_serializer.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | value: -4611686018427387903, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_611_686_018_427_387_903` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_serializer.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | value: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_serializer.rs:291:20 [INFO] [stderr] | [INFO] [stderr] 291 | value: 1000000000000, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_serializer.rs:295:20 [INFO] [stderr] | [INFO] [stderr] 295 | value: 18446744073709551615, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serializer.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | fn encode_tag(output: &mut Vec, tag: &u64, val: &CborType) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serializer.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | fn encode_tag(output: &mut Vec, tag: &u64, val: &CborType) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "fd83766ee94f33147259124c08ec819e7d268bdb8e1aff9f506060df16344a30"` [INFO] running `"docker" "rm" "-f" "fd83766ee94f33147259124c08ec819e7d268bdb8e1aff9f506060df16344a30"` [INFO] [stdout] fd83766ee94f33147259124c08ec819e7d268bdb8e1aff9f506060df16344a30