[INFO] crate mouscache 0.5.2 is already in cache
[INFO] extracting crate mouscache 0.5.2 into work/ex/clippy-test-run/sources/stable/reg/mouscache/0.5.2
[INFO] extracting crate mouscache 0.5.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mouscache/0.5.2
[INFO] validating manifest of mouscache-0.5.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mouscache-0.5.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mouscache-0.5.2
[INFO] finished frobbing mouscache-0.5.2
[INFO] frobbed toml for mouscache-0.5.2 written to work/ex/clippy-test-run/sources/stable/reg/mouscache/0.5.2/Cargo.toml
[INFO] started frobbing mouscache-0.5.2
[INFO] finished frobbing mouscache-0.5.2
[INFO] frobbed toml for mouscache-0.5.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mouscache/0.5.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mouscache-0.5.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mouscache/0.5.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b63b420fec81dd821f22b65d38e51b165bc8c35662172cb9311ffbbc38c47f49
[INFO] running `"docker" "start" "-a" "b63b420fec81dd821f22b65d38e51b165bc8c35662172cb9311ffbbc38c47f49"`
[INFO] [stderr]    Compiling semver-parser v0.7.0
[INFO] [stderr]    Compiling redis v0.9.1
[INFO] [stderr]    Compiling semver v0.9.0
[INFO] [stderr]    Compiling rustc_version v0.2.3
[INFO] [stderr]    Compiling rand_pcg v0.1.1
[INFO] [stderr]    Compiling parking_lot_core v0.4.0
[INFO] [stderr]    Compiling parking_lot_core v0.3.1
[INFO] [stderr]     Checking rand v0.6.5
[INFO] [stderr]     Checking parking_lot v0.6.4
[INFO] [stderr]     Checking parking_lot v0.7.1
[INFO] [stderr]     Checking tokio-reactor v0.1.8
[INFO] [stderr]     Checking tokio-tcp v0.1.3
[INFO] [stderr]     Checking mouscache v0.5.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/redis_cache.rs:293:9
[INFO] [stderr]     |
[INFO] [stderr] 293 |         return T::from_str(val.as_ref()).map(|t| Some(t)).map_err(|_| CacheError::Other("An error occured while parsing a redis value".to_string()))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `T::from_str(val.as_ref()).map(|t| Some(t)).map_err(|_| CacheError::Other("An error occured while parsing a redis value".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/redis_cache.rs:293:9
[INFO] [stderr]     |
[INFO] [stderr] 293 |         return T::from_str(val.as_ref()).map(|t| Some(t)).map_err(|_| CacheError::Other("An error occured while parsing a redis value".to_string()))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `T::from_str(val.as_ref()).map(|t| Some(t)).map_err(|_| CacheError::Other("An error occured while parsing a redis value".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/memory_cache.rs:57:20
[INFO] [stderr]    |
[INFO] [stderr] 57 |               if let Some(_) = writer.insert(key.to_string(), RwLock::new(HashMap::new())) {
[INFO] [stderr]    |  _____________-      ^^^^^^^
[INFO] [stderr] 58 | |                 return Err(::CacheError::Other("Unable to insert a new hashmap".to_string()));
[INFO] [stderr] 59 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if writer.insert(key.to_string(), RwLock::new(HashMap::new())).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/memory_cache.rs:73:20
[INFO] [stderr]    |
[INFO] [stderr] 73 |               if let Some(_) = writer.insert(key.to_string(), RwLock::new(HashSet::new())) {
[INFO] [stderr]    |  _____________-      ^^^^^^^
[INFO] [stderr] 74 | |                 return Err(::CacheError::Other("Unable to insert a new hashset".to_string()));
[INFO] [stderr] 75 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if writer.insert(key.to_string(), RwLock::new(HashSet::new())).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `memory_cache::MemoryCache`
[INFO] [stderr]   --> src/memory_cache.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 | /     pub fn new() -> MemoryCache {
[INFO] [stderr] 95 | |         MemoryCache {
[INFO] [stderr] 96 | |             inner: Arc::new(Inner::new())
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 93 | impl Default for memory_cache::MemoryCache {
[INFO] [stderr] 94 |     fn default() -> Self {
[INFO] [stderr] 95 |         Self::new()
[INFO] [stderr] 96 |     }
[INFO] [stderr] 97 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/memory_cache.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 | /                 if let &Some(ref exp) = exp {
[INFO] [stderr] 120 | |                     if exp.is_expired() {
[INFO] [stderr] 121 | |                         delete_entry = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr] 123 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 if let Some(ref exp) = *exp {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/memory_cache.rs:185:45
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 return T::from_str(val).map(|t| Some(t)).map_err(|_| ::CacheError::Other("Unable to parse value into desired type".to_string()));
[INFO] [stderr]     |                                             ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:198:23
[INFO] [stderr]     |
[INFO] [stderr] 198 |             let res = hash.read().keys().map(|k| k.clone()).collect();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `hash.read().keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:218:26
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(f.clone()).map(|s| s.clone()));
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `reader.get(f.clone()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:218:37
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(f.clone()).map(|s| s.clone()));
[INFO] [stderr]     |                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(&(*f).clone()).map(|s| s.clone()));
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(&str::clone(f)).map(|s| s.clone()));
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:275:13
[INFO] [stderr]     |
[INFO] [stderr] 275 |             hash.read().values().map(|s| s.clone()).collect()
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `hash.read().values().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:308:22
[INFO] [stderr]     |
[INFO] [stderr] 308 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 308 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 308 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:312:23
[INFO] [stderr]     |
[INFO] [stderr] 312 |               let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 313 | |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 314 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/memory_cache.rs:57:20
[INFO] [stderr]    |
[INFO] [stderr] 57 |               if let Some(_) = writer.insert(key.to_string(), RwLock::new(HashMap::new())) {
[INFO] [stderr]    |  _____________-      ^^^^^^^
[INFO] [stderr] 58 | |                 return Err(::CacheError::Other("Unable to insert a new hashmap".to_string()));
[INFO] [stderr] 59 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if writer.insert(key.to_string(), RwLock::new(HashMap::new())).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 312 |             let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr] 313 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 314 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:313:17
[INFO] [stderr]     |
[INFO] [stderr] 313 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `diff_set.difference(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/memory_cache.rs:73:20
[INFO] [stderr]    |
[INFO] [stderr] 73 |               if let Some(_) = writer.insert(key.to_string(), RwLock::new(HashSet::new())) {
[INFO] [stderr]    |  _____________-      ^^^^^^^
[INFO] [stderr] 74 | |                 return Err(::CacheError::Other("Unable to insert a new hashset".to_string()));
[INFO] [stderr] 75 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if writer.insert(key.to_string(), RwLock::new(HashSet::new())).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `memory_cache::MemoryCache`
[INFO] [stderr]   --> src/memory_cache.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 | /     pub fn new() -> MemoryCache {
[INFO] [stderr] 95 | |         MemoryCache {
[INFO] [stderr] 96 | |             inner: Arc::new(Inner::new())
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 93 | impl Default for memory_cache::MemoryCache {
[INFO] [stderr] 94 |     fn default() -> Self {
[INFO] [stderr] 95 |         Self::new()
[INFO] [stderr] 96 |     }
[INFO] [stderr] 97 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:326:22
[INFO] [stderr]     |
[INFO] [stderr] 326 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 326 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 326 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:330:23
[INFO] [stderr]     |
[INFO] [stderr] 330 |               let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 331 | |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 332 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 330 |             let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr] 331 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 332 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:331:17
[INFO] [stderr]     |
[INFO] [stderr] 331 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `diff_set.difference(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/memory_cache.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 | /                 if let &Some(ref exp) = exp {
[INFO] [stderr] 120 | |                     if exp.is_expired() {
[INFO] [stderr] 121 | |                         delete_entry = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr] 123 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 if let Some(ref exp) = *exp {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:347:22
[INFO] [stderr]     |
[INFO] [stderr] 347 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 347 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 347 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:351:23
[INFO] [stderr]     |
[INFO] [stderr] 351 |               let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 352 | |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 353 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 351 |             let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr] 352 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 353 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:352:17
[INFO] [stderr]     |
[INFO] [stderr] 352 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inter_set.intersection(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:365:22
[INFO] [stderr]     |
[INFO] [stderr] 365 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 365 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 365 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:369:23
[INFO] [stderr]     |
[INFO] [stderr] 369 |               let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 370 | |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 371 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 369 |             let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr] 370 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 371 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:370:17
[INFO] [stderr]     |
[INFO] [stderr] 370 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inter_set.intersection(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/memory_cache.rs:185:45
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 return T::from_str(val).map(|t| Some(t)).map_err(|_| ::CacheError::Other("Unable to parse value into desired type".to_string()));
[INFO] [stderr]     |                                             ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:395:16
[INFO] [stderr]     |
[INFO] [stderr] 395 |             Ok(set.read().iter().map(|ref_str| ref_str.clone()).collect::<Vec<String>>())
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `set.read().iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:198:23
[INFO] [stderr]     |
[INFO] [stderr] 198 |             let res = hash.read().keys().map(|k| k.clone()).collect();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `hash.read().keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:218:26
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(f.clone()).map(|s| s.clone()));
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `reader.get(f.clone()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:218:37
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(f.clone()).map(|s| s.clone()));
[INFO] [stderr]     |                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(&(*f).clone()).map(|s| s.clone()));
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 vec.push(reader.get(&str::clone(f)).map(|s| s.clone()));
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:434:22
[INFO] [stderr]     |
[INFO] [stderr] 434 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 434 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 434 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:438:23
[INFO] [stderr]     |
[INFO] [stderr] 438 |               let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 439 | |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 440 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 438 |             let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr] 439 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 440 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:439:17
[INFO] [stderr]     |
[INFO] [stderr] 439 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `union_set.union(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:452:22
[INFO] [stderr]     |
[INFO] [stderr] 452 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 452 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 452 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:456:23
[INFO] [stderr]     |
[INFO] [stderr] 456 |               let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 457 | |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 458 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 456 |             let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr] 457 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 458 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:457:17
[INFO] [stderr]     |
[INFO] [stderr] 457 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `union_set.union(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:275:13
[INFO] [stderr]     |
[INFO] [stderr] 275 |             hash.read().values().map(|s| s.clone()).collect()
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `hash.read().values().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:308:22
[INFO] [stderr]     |
[INFO] [stderr] 308 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 308 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 308 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:312:23
[INFO] [stderr]     |
[INFO] [stderr] 312 |               let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 313 | |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 314 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 312 |             let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr] 313 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 314 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:313:17
[INFO] [stderr]     |
[INFO] [stderr] 313 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `diff_set.difference(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:326:22
[INFO] [stderr]     |
[INFO] [stderr] 326 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 326 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 326 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:330:23
[INFO] [stderr]     |
[INFO] [stderr] 330 |               let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 331 | |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 332 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 330 |             let res = siter.fold(set.read().clone(), |diff_set, current_set_lock| {
[INFO] [stderr] 331 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 332 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:331:17
[INFO] [stderr]     |
[INFO] [stderr] 331 |                 diff_set.difference(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `diff_set.difference(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:347:22
[INFO] [stderr]     |
[INFO] [stderr] 347 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 347 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 347 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:351:23
[INFO] [stderr]     |
[INFO] [stderr] 351 |               let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 352 | |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 353 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 351 |             let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr] 352 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 353 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:352:17
[INFO] [stderr]     |
[INFO] [stderr] 352 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inter_set.intersection(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/redis_cache.rs:140:46
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let host_vec: Vec<&str> = host.split(":").collect();
[INFO] [stderr]     |                                              ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:365:22
[INFO] [stderr]     |
[INFO] [stderr] 365 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 365 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 365 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:369:23
[INFO] [stderr]     |
[INFO] [stderr] 369 |               let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 370 | |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 371 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 369 |             let res = siter.fold(set.read().clone(), |inter_set, current_set_lock| {
[INFO] [stderr] 370 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 371 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:370:17
[INFO] [stderr]     |
[INFO] [stderr] 370 |                 inter_set.intersection(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `inter_set.intersection(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:395:16
[INFO] [stderr]     |
[INFO] [stderr] 395 |             Ok(set.read().iter().map(|ref_str| ref_str.clone()).collect::<Vec<String>>())
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `set.read().iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:434:22
[INFO] [stderr]     |
[INFO] [stderr] 434 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 434 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 434 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:438:23
[INFO] [stderr]     |
[INFO] [stderr] 438 |               let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 439 | |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 440 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 438 |             let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr] 439 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 440 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:439:17
[INFO] [stderr]     |
[INFO] [stderr] 439 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `union_set.union(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/memory_cache.rs:452:22
[INFO] [stderr]     |
[INFO] [stderr] 452 |             sets.get(key.clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 452 |             sets.get(&(*key).clone())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 452 |             sets.get(&str::clone(key))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:456:23
[INFO] [stderr]     |
[INFO] [stderr] 456 |               let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 457 | |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 458 | |             }).iter().map(|sref| sref.clone()).collect::<Vec<_>>();
[INFO] [stderr]     | |______________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 456 |             let res = siter.fold(set.read().clone(), |union_set, current_set_lock| {
[INFO] [stderr] 457 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr] 458 |             }).iter().cloned().collect::<Vec<_>>();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/memory_cache.rs:457:17
[INFO] [stderr]     |
[INFO] [stderr] 457 |                 union_set.union(&current_set_lock.read()).map(|sref| sref.clone()).collect()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `union_set.union(&current_set_lock.read()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/redis_cache.rs:293:46
[INFO] [stderr]     |
[INFO] [stderr] 293 |         return T::from_str(val.as_ref()).map(|t| Some(t)).map_err(|_| CacheError::Other("An error occured while parsing a redis value".to_string()))
[INFO] [stderr]     |                                              ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/redis_cache.rs:302:36
[INFO] [stderr]     |
[INFO] [stderr] 302 |         T::from_redis_obj(map).map(|t| Some(t))
[INFO] [stderr]     |                                    ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/redis_cache.rs:140:46
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let host_vec: Vec<&str> = host.split(":").collect();
[INFO] [stderr]     |                                              ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/redis_cache.rs:293:46
[INFO] [stderr]     |
[INFO] [stderr] 293 |         return T::from_str(val.as_ref()).map(|t| Some(t)).map_err(|_| CacheError::Other("An error occured while parsing a redis value".to_string()))
[INFO] [stderr]     |                                              ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/redis_cache.rs:302:36
[INFO] [stderr]     |
[INFO] [stderr] 302 |         T::from_redis_obj(map).map(|t| Some(t))
[INFO] [stderr]     |                                    ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 7 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mouscache`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: aborting due to 7 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mouscache`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "b63b420fec81dd821f22b65d38e51b165bc8c35662172cb9311ffbbc38c47f49"`
[INFO] running `"docker" "rm" "-f" "b63b420fec81dd821f22b65d38e51b165bc8c35662172cb9311ffbbc38c47f49"`
[INFO] [stdout] b63b420fec81dd821f22b65d38e51b165bc8c35662172cb9311ffbbc38c47f49