[INFO] crate mossy 0.0.1 is already in cache [INFO] extracting crate mossy 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/mossy/0.0.1 [INFO] extracting crate mossy 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mossy/0.0.1 [INFO] validating manifest of mossy-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mossy-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mossy-0.0.1 [INFO] finished frobbing mossy-0.0.1 [INFO] frobbed toml for mossy-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/mossy/0.0.1/Cargo.toml [INFO] started frobbing mossy-0.0.1 [INFO] finished frobbing mossy-0.0.1 [INFO] frobbed toml for mossy-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mossy/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mossy-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mossy/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 713cb9f5873d25fa02fd49dfbd54b363c72a6da870c2e6bf97f8b3c7747d674c [INFO] running `"docker" "start" "-a" "713cb9f5873d25fa02fd49dfbd54b363c72a6da870c2e6bf97f8b3c7747d674c"` [INFO] [stderr] Checking mossy v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:44:44 [INFO] [stderr] | [INFO] [stderr] 44 | tokens.push(Token::Heading{depth: depth,text: text}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:44:57 [INFO] [stderr] | [INFO] [stderr] 44 | tokens.push(Token::Heading{depth: depth,text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:94:66 [INFO] [stderr] | [INFO] [stderr] 94 | tokens.push(Token::Heading{depth: 1, text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:97:66 [INFO] [stderr] | [INFO] [stderr] 97 | tokens.push(Token::Heading{depth: 2, text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:101:54 [INFO] [stderr] | [INFO] [stderr] 101 | tokens.push(Token::Paragraph{text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:104:50 [INFO] [stderr] | [INFO] [stderr] 104 | tokens.push(Token::Paragraph{text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | stack.push(Token::ListStart{ordered: ordered}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ordered` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:118:40 [INFO] [stderr] | [INFO] [stderr] 118 | stack.push(Token::ListItem{text: text, task: false, checked: false}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | Token::Code{lang: lang, text: text} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lang` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | Token::Code{lang: lang, text: text} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:44:44 [INFO] [stderr] | [INFO] [stderr] 44 | tokens.push(Token::Heading{depth: depth,text: text}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:44:57 [INFO] [stderr] | [INFO] [stderr] 44 | tokens.push(Token::Heading{depth: depth,text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:94:66 [INFO] [stderr] | [INFO] [stderr] 94 | tokens.push(Token::Heading{depth: 1, text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:97:66 [INFO] [stderr] | [INFO] [stderr] 97 | tokens.push(Token::Heading{depth: 2, text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:101:54 [INFO] [stderr] | [INFO] [stderr] 101 | tokens.push(Token::Paragraph{text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:104:50 [INFO] [stderr] | [INFO] [stderr] 104 | tokens.push(Token::Paragraph{text: text}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | stack.push(Token::ListStart{ordered: ordered}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ordered` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:118:40 [INFO] [stderr] | [INFO] [stderr] 118 | stack.push(Token::ListItem{text: text, task: false, checked: false}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | Token::Code{lang: lang, text: text} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lang` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | Token::Code{lang: lang, text: text} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: value assigned to `lang` is never read [INFO] [stderr] --> src/lexer.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | let mut lang: String = String::new(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task` [INFO] [stderr] --> src/parser.rs:68:51 [INFO] [stderr] | [INFO] [stderr] 68 | Token::ListItem{text, task, checked} => { [INFO] [stderr] | ^^^^ help: try ignoring the field: `task: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `checked` [INFO] [stderr] --> src/parser.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | Token::ListItem{text, task, checked} => { [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `checked: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | let mut f: String; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Text` [INFO] [stderr] --> src/token.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Text{text: String}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Table` [INFO] [stderr] --> src/token.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Table{header: Vec, align: Vec, cells: Vec} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lexer.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | cursor.read_line(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lexer.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | self.cursor.read_line(&mut temp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:42:44 [INFO] [stderr] | [INFO] [stderr] 42 | let depth: i8 = Regex::new("#").unwrap().find_iter(head_line.as_str()).count() as i8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:43:47 [INFO] [stderr] | [INFO] [stderr] 43 | let text: String = Regex::new("#").unwrap().replace_all(head_line.as_str(), "").trim().to_string(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | else if Regex::new(r"^>").unwrap().is_match(head_line.as_str()){ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:73:77 [INFO] [stderr] | [INFO] [stderr] 73 | parags = Regex::new(r"\s{2,}$").unwrap().replace(Regex::new(r"\n$").unwrap().replace(Regex::new(r"^>+").unwrap().replace(head_line.as_str(), "").to_string().as_str(), "").to_string().as_str(), "\n").trim().to_string(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::ends_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | if Regex::new(r"^>").unwrap().is_match(self.line.clone().unwrap().as_str()){ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:78:86 [INFO] [stderr] | [INFO] [stderr] 78 | parags += Regex::new(r"\s{2,}$").unwrap().replace(Regex::new(r"\n$").unwrap().replace(Regex::new(r"^>+").unwrap().replace(self.line.clone().unwrap().as_str(), "").to_string().as_str(), "").to_string().as_str(), "\n").trim(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::ends_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lexer.rs:129:86 [INFO] [stderr] | [INFO] [stderr] 129 | if Regex::new(r"^\B[(`{3})(\t{1})]").unwrap().is_match(self.line.clone().unwrap_or("".to_string()).as_str()){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lexer.rs:132:44 [INFO] [stderr] | [INFO] [stderr] 132 | text += &self.line.clone().unwrap_or("\n".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "\n".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lexer.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | &self.consume(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `self.consume();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/parser.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | let token = tokens.clone().iter().nth(0).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/parser.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | match self.tokens.iter().nth(self.point) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s = if lang.to_owned()==String::from(""){ String::from("") }else{ format!(" class=\"language-{}\"", lang) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `lang` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s = if lang.to_owned()==String::from(""){ String::from("") }else{ format!(" class=\"language-{}\"", lang) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: variable `is_inList` should have a snake case name such as `is_in_list` [INFO] [stderr] --> src/parser.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let mut is_inList: bool = true; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | / match self.token.clone().unwrap(){ [INFO] [stderr] 84 | | Token::Paragraph{text} => { [INFO] [stderr] 85 | | output+=format!("
\n

{}

\n
\n", text).as_str(); [INFO] [stderr] 86 | | }, [INFO] [stderr] 87 | | _ => {} [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Token::Paragraph{text} = self.token.clone().unwrap() { [INFO] [stderr] 84 | output+=format!("
\n

{}

\n
\n", text).as_str(); [INFO] [stderr] 85 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | / match token{ [INFO] [stderr] 105 | | Token::Paragraph{ text } => { [INFO] [stderr] 106 | | if Regex::new(r"^\[(\w+)\]:\s*([\w\W[[:punct:]]]+)\s*\u0022([\w\W\s[[:punct:]]]+)\u0022\n?$").unwrap().is_match(text.as_str()){ [INFO] [stderr] 107 | | link_len.push(nums as usize); [INFO] [stderr] ... | [INFO] [stderr] 124 | | _ => { } [INFO] [stderr] 125 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | if let Token::Paragraph{ text } = token { [INFO] [stderr] 105 | if Regex::new(r"^\[(\w+)\]:\s*([\w\W[[:punct:]]]+)\s*\u0022([\w\W\s[[:punct:]]]+)\u0022\n?$").unwrap().is_match(text.as_str()){ [INFO] [stderr] 106 | link_len.push(nums as usize); [INFO] [stderr] 107 | let mut linkname: String = String::new(); [INFO] [stderr] 108 | let text:String = Regex::new(r"^\[(\w+)\]:\s*([\w\W[[:punct:]]]+)\s+\u0022([\w\W\s[[:punct:]]]+)\u0022\n?$").unwrap().replace(text.as_str(), |caps: &Captures| { [INFO] [stderr] 109 | linkname = caps.get(1).map_or("", |m| m.as_str()).to_string().to_lowercase(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / let mut f: String; [INFO] [stderr] 160 | | if Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)?\s*\)").unwrap().is_match(text.as_str()) { [INFO] [stderr] 161 | | f = Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)\s*\)").unwrap().replace(text.as_str(), |caps: &Captures|{ [INFO] [stderr] 162 | | return format!("\"{}\"", &caps[2].trim().to_string(), &caps[1].to_string(), &caps[3].to_string()); [INFO] [stderr] ... | [INFO] [stderr] 167 | | }).to_string(); [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 159 | let f = if Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)?\s*\)").unwrap().is_match(text.as_str()) { Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)\s*\)").unwrap().replace(text.as_str(), |caps: &Captures|{ [INFO] [stderr] 160 | return format!("\"{}\"", &caps[2].trim().to_string(), &caps[1].to_string(), &caps[3].to_string()); [INFO] [stderr] 161 | }).to_string() } else { Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s*\)").unwrap().replace(text.as_str(), |caps: &Captures|{ [INFO] [stderr] 162 | return format!("\"{}\"", &caps[2].trim().to_string(), &caps[1].to_string()); [INFO] [stderr] 163 | }).to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:181:24 [INFO] [stderr] | [INFO] [stderr] 181 | return format!("{}", self.links.get(&caps[1].to_string().to_lowercase()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.links.get(&caps[1].to_string().to_lowercase()).unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:181:38 [INFO] [stderr] | [INFO] [stderr] 181 | return format!("{}", self.links.get(&caps[1].to_string().to_lowercase()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.links[&caps[1].to_string().to_lowercase()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mossy.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(markdown: String) -> String { [INFO] [stderr] 17 | | let mut lexer: Lexer = Lexer::new(markdown);//gen tokens. [INFO] [stderr] 18 | | Parser::new(lexer.exec()).exec() //parse markdown_tokens to HTML. [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: value assigned to `lang` is never read [INFO] [stderr] --> src/lexer.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | let mut lang: String = String::new(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task` [INFO] [stderr] --> src/parser.rs:68:51 [INFO] [stderr] | [INFO] [stderr] 68 | Token::ListItem{text, task, checked} => { [INFO] [stderr] | ^^^^ help: try ignoring the field: `task: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `checked` [INFO] [stderr] --> src/parser.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | Token::ListItem{text, task, checked} => { [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `checked: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | let mut f: String; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Text` [INFO] [stderr] --> src/token.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Text{text: String}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Table` [INFO] [stderr] --> src/token.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Table{header: Vec, align: Vec, cells: Vec} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lexer.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | cursor.read_line(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lexer.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | self.cursor.read_line(&mut temp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:42:44 [INFO] [stderr] | [INFO] [stderr] 42 | let depth: i8 = Regex::new("#").unwrap().find_iter(head_line.as_str()).count() as i8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:43:47 [INFO] [stderr] | [INFO] [stderr] 43 | let text: String = Regex::new("#").unwrap().replace_all(head_line.as_str(), "").trim().to_string(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | else if Regex::new(r"^>").unwrap().is_match(head_line.as_str()){ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:73:77 [INFO] [stderr] | [INFO] [stderr] 73 | parags = Regex::new(r"\s{2,}$").unwrap().replace(Regex::new(r"\n$").unwrap().replace(Regex::new(r"^>+").unwrap().replace(head_line.as_str(), "").to_string().as_str(), "").to_string().as_str(), "\n").trim().to_string(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::ends_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | if Regex::new(r"^>").unwrap().is_match(self.line.clone().unwrap().as_str()){ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lexer.rs:78:86 [INFO] [stderr] | [INFO] [stderr] 78 | parags += Regex::new(r"\s{2,}$").unwrap().replace(Regex::new(r"\n$").unwrap().replace(Regex::new(r"^>+").unwrap().replace(self.line.clone().unwrap().as_str(), "").to_string().as_str(), "").to_string().as_str(), "\n").trim(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::ends_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lexer.rs:129:86 [INFO] [stderr] | [INFO] [stderr] 129 | if Regex::new(r"^\B[(`{3})(\t{1})]").unwrap().is_match(self.line.clone().unwrap_or("".to_string()).as_str()){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lexer.rs:132:44 [INFO] [stderr] | [INFO] [stderr] 132 | text += &self.line.clone().unwrap_or("\n".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "\n".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lexer.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | &self.consume(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `self.consume();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/parser.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | let token = tokens.clone().iter().nth(0).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/parser.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | match self.tokens.iter().nth(self.point) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s = if lang.to_owned()==String::from(""){ String::from("") }else{ format!(" class=\"language-{}\"", lang) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `lang` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s = if lang.to_owned()==String::from(""){ String::from("") }else{ format!(" class=\"language-{}\"", lang) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: variable `is_inList` should have a snake case name such as `is_in_list` [INFO] [stderr] --> src/parser.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let mut is_inList: bool = true; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | / match self.token.clone().unwrap(){ [INFO] [stderr] 84 | | Token::Paragraph{text} => { [INFO] [stderr] 85 | | output+=format!("
\n

{}

\n
\n", text).as_str(); [INFO] [stderr] 86 | | }, [INFO] [stderr] 87 | | _ => {} [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Token::Paragraph{text} = self.token.clone().unwrap() { [INFO] [stderr] 84 | output+=format!("
\n

{}

\n
\n", text).as_str(); [INFO] [stderr] 85 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | / match token{ [INFO] [stderr] 105 | | Token::Paragraph{ text } => { [INFO] [stderr] 106 | | if Regex::new(r"^\[(\w+)\]:\s*([\w\W[[:punct:]]]+)\s*\u0022([\w\W\s[[:punct:]]]+)\u0022\n?$").unwrap().is_match(text.as_str()){ [INFO] [stderr] 107 | | link_len.push(nums as usize); [INFO] [stderr] ... | [INFO] [stderr] 124 | | _ => { } [INFO] [stderr] 125 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | if let Token::Paragraph{ text } = token { [INFO] [stderr] 105 | if Regex::new(r"^\[(\w+)\]:\s*([\w\W[[:punct:]]]+)\s*\u0022([\w\W\s[[:punct:]]]+)\u0022\n?$").unwrap().is_match(text.as_str()){ [INFO] [stderr] 106 | link_len.push(nums as usize); [INFO] [stderr] 107 | let mut linkname: String = String::new(); [INFO] [stderr] 108 | let text:String = Regex::new(r"^\[(\w+)\]:\s*([\w\W[[:punct:]]]+)\s+\u0022([\w\W\s[[:punct:]]]+)\u0022\n?$").unwrap().replace(text.as_str(), |caps: &Captures| { [INFO] [stderr] 109 | linkname = caps.get(1).map_or("", |m| m.as_str()).to_string().to_lowercase(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / let mut f: String; [INFO] [stderr] 160 | | if Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)?\s*\)").unwrap().is_match(text.as_str()) { [INFO] [stderr] 161 | | f = Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)\s*\)").unwrap().replace(text.as_str(), |caps: &Captures|{ [INFO] [stderr] 162 | | return format!("\"{}\"", &caps[2].trim().to_string(), &caps[1].to_string(), &caps[3].to_string()); [INFO] [stderr] ... | [INFO] [stderr] 167 | | }).to_string(); [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 159 | let f = if Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)?\s*\)").unwrap().is_match(text.as_str()) { Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s+(\u0022[\w\W\s[[:punct:]]]+\u0022)\s*\)").unwrap().replace(text.as_str(), |caps: &Captures|{ [INFO] [stderr] 160 | return format!("\"{}\"", &caps[2].trim().to_string(), &caps[1].to_string(), &caps[3].to_string()); [INFO] [stderr] 161 | }).to_string() } else { Regex::new(r"!\[(\w+)\]\(\s*([\w\W[[:punct:]]]+)\s*\)").unwrap().replace(text.as_str(), |caps: &Captures|{ [INFO] [stderr] 162 | return format!("\"{}\"", &caps[2].trim().to_string(), &caps[1].to_string()); [INFO] [stderr] 163 | }).to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:181:24 [INFO] [stderr] | [INFO] [stderr] 181 | return format!("{}", self.links.get(&caps[1].to_string().to_lowercase()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.links.get(&caps[1].to_string().to_lowercase()).unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:181:38 [INFO] [stderr] | [INFO] [stderr] 181 | return format!("{}", self.links.get(&caps[1].to_string().to_lowercase()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.links[&caps[1].to_string().to_lowercase()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mossy.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(markdown: String) -> String { [INFO] [stderr] 17 | | let mut lexer: Lexer = Lexer::new(markdown);//gen tokens. [INFO] [stderr] 18 | | Parser::new(lexer.exec()).exec() //parse markdown_tokens to HTML. [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.49s [INFO] running `"docker" "inspect" "713cb9f5873d25fa02fd49dfbd54b363c72a6da870c2e6bf97f8b3c7747d674c"` [INFO] running `"docker" "rm" "-f" "713cb9f5873d25fa02fd49dfbd54b363c72a6da870c2e6bf97f8b3c7747d674c"` [INFO] [stdout] 713cb9f5873d25fa02fd49dfbd54b363c72a6da870c2e6bf97f8b3c7747d674c