[INFO] crate mos6502 0.0.1 is already in cache [INFO] extracting crate mos6502 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/mos6502/0.0.1 [INFO] extracting crate mos6502 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mos6502/0.0.1 [INFO] validating manifest of mos6502-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mos6502-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mos6502-0.0.1 [INFO] finished frobbing mos6502-0.0.1 [INFO] frobbed toml for mos6502-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/mos6502/0.0.1/Cargo.toml [INFO] started frobbing mos6502-0.0.1 [INFO] finished frobbing mos6502-0.0.1 [INFO] frobbed toml for mos6502-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mos6502/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mos6502-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mos6502/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e083fa73dafdf19ee4f93445493787ca546caadcf271dfa1590384e19527c377 [INFO] running `"docker" "start" "-a" "e083fa73dafdf19ee4f93445493787ca546caadcf271dfa1590384e19527c377"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/bin/main.rs` was erroneously implicitly accepted for binary `mos6502`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking mos6502 v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | const PS_NEGATIVE = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | const PS_OVERFLOW = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | const PS_UNUSED = 0b00100000; // JAM: Should this exist? [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | const PS_BRK = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | const PS_DECIMAL_MODE = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:69:39 [INFO] [stderr] | [INFO] [stderr] 69 | const PS_DISABLE_INTERRUPTS = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:70:39 [INFO] [stderr] | [INFO] [stderr] 70 | const PS_ZERO = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:71:39 [INFO] [stderr] | [INFO] [stderr] 71 | const PS_CARRY = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | const PS_NEGATIVE = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | const PS_OVERFLOW = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | const PS_UNUSED = 0b00100000; // JAM: Should this exist? [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | const PS_BRK = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | const PS_DECIMAL_MODE = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:69:39 [INFO] [stderr] | [INFO] [stderr] 69 | const PS_DISABLE_INTERRUPTS = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:70:39 [INFO] [stderr] | [INFO] [stderr] 70 | const PS_ZERO = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/registers.rs:71:39 [INFO] [stderr] | [INFO] [stderr] 71 | const PS_CARRY = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/address.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | Address(((lhs as i32) + rhs) as u16) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(lhs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn to_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn to_usize(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn get_page_number(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn get_offset(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let x = (arr[0] as u16) + ((arr[1] as u16) << 8usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(arr[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | let x = (arr[0] as u16) + ((arr[1] as u16) << 8usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(arr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:190:45 [INFO] [stderr] | [INFO] [stderr] 190 | OpInput::UseAddress(Address(arr[0] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(arr[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:196:45 [INFO] [stderr] | [INFO] [stderr] 196 | OpInput::UseAddress(Address((arr[0] + x) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(arr[0] + x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:202:45 [INFO] [stderr] | [INFO] [stderr] 202 | OpInput::UseAddress(Address((arr[0] + y) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(arr[0] + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:217:68 [INFO] [stderr] | [INFO] [stderr] 217 | OpInput::UseAddress(arr_to_addr(arr) + AddressDiff(x as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:222:68 [INFO] [stderr] | [INFO] [stderr] 222 | OpInput::UseAddress(arr_to_addr(arr) + AddressDiff(y as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:237:54 [INFO] [stderr] | [INFO] [stderr] 237 | let slice = memory.get_slice(Address(start as u16), AddressDiff(2)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:246:54 [INFO] [stderr] | [INFO] [stderr] 246 | let slice = memory.get_slice(Address(start as u16), AddressDiff(2)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:247:70 [INFO] [stderr] | [INFO] [stderr] 247 | OpInput::UseAddress(arr_to_addr(slice) + AddressDiff(y as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> CPU { [INFO] [stderr] 46 | | CPU { [INFO] [stderr] 47 | | registers: Registers::new(), [INFO] [stderr] 48 | | memory: Memory::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | impl Default for cpu::CPU { [INFO] [stderr] 45 | fn default() -> Self { [INFO] [stderr] 46 | Self::new() [INFO] [stderr] 47 | } [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:112:73 [INFO] [stderr] | [INFO] [stderr] 112 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:117:73 [INFO] [stderr] | [INFO] [stderr] 117 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:122:73 [INFO] [stderr] | [INFO] [stderr] 122 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:152:73 [INFO] [stderr] | [INFO] [stderr] 152 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:158:73 [INFO] [stderr] | [INFO] [stderr] 158 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:163:73 [INFO] [stderr] | [INFO] [stderr] 163 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:168:73 [INFO] [stderr] | [INFO] [stderr] 168 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/cpu.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | / loop { [INFO] [stderr] 414 | | if let Some(decoded_instr) = self.fetch_next_and_decode() { [INFO] [stderr] 415 | | self.execute_instruction(decoded_instr); [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | break; [INFO] [stderr] 418 | | } [INFO] [stderr] 419 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(decoded_instr) = self.fetch_next_and_decode() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | *p_val = *p_val >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*p_val >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `memory::Memory` [INFO] [stderr] --> src/memory.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / pub fn new() -> Memory { [INFO] [stderr] 65 | | Memory { bytes: [0; MEMORY_SIZE] } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | impl Default for memory::Memory { [INFO] [stderr] 64 | fn default() -> Self { [INFO] [stderr] 65 | Self::new() [INFO] [stderr] 66 | } [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/memory.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn is_stack_address(address: &Address) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | out = out | PS_NEGATIVE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_NEGATIVE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | out = out | PS_OVERFLOW [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_OVERFLOW` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | out = out | PS_UNUSED [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_UNUSED` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | out = out | PS_BRK [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_BRK` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | out = out | PS_DECIMAL_MODE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_DECIMAL_MODE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | out = out | PS_DISABLE_INTERRUPTS [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_DISABLE_INTERRUPTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | out = out | PS_ZERO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_ZERO` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | out = out | PS_CARRY [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_CARRY` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | *self = *self & rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*self &= rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | *self = *self | rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*self |= rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/registers.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_address(&self) -> Address { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/registers.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | STACK_ADDRESS_LO + AddressDiff(sp as i32) [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `registers::Registers` [INFO] [stderr] --> src/registers.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn new() -> Registers { [INFO] [stderr] 177 | | // TODO akeeton: Revisit these defaults. [INFO] [stderr] 178 | | Registers { [INFO] [stderr] 179 | | accumulator: 0, [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | impl Default for registers::Registers { [INFO] [stderr] 176 | fn default() -> Self { [INFO] [stderr] 177 | Self::new() [INFO] [stderr] 178 | } [INFO] [stderr] 179 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/address.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | Address(((lhs as i32) + rhs) as u16) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(lhs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn to_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn to_usize(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn get_page_number(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn get_offset(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let x = (arr[0] as u16) + ((arr[1] as u16) << 8usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(arr[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | let x = (arr[0] as u16) + ((arr[1] as u16) << 8usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(arr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:190:45 [INFO] [stderr] | [INFO] [stderr] 190 | OpInput::UseAddress(Address(arr[0] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(arr[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:196:45 [INFO] [stderr] | [INFO] [stderr] 196 | OpInput::UseAddress(Address((arr[0] + x) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(arr[0] + x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:202:45 [INFO] [stderr] | [INFO] [stderr] 202 | OpInput::UseAddress(Address((arr[0] + y) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(arr[0] + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:217:68 [INFO] [stderr] | [INFO] [stderr] 217 | OpInput::UseAddress(arr_to_addr(arr) + AddressDiff(x as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:222:68 [INFO] [stderr] | [INFO] [stderr] 222 | OpInput::UseAddress(arr_to_addr(arr) + AddressDiff(y as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:237:54 [INFO] [stderr] | [INFO] [stderr] 237 | let slice = memory.get_slice(Address(start as u16), AddressDiff(2)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:246:54 [INFO] [stderr] | [INFO] [stderr] 246 | let slice = memory.get_slice(Address(start as u16), AddressDiff(2)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:247:70 [INFO] [stderr] | [INFO] [stderr] 247 | OpInput::UseAddress(arr_to_addr(slice) + AddressDiff(y as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> CPU { [INFO] [stderr] 46 | | CPU { [INFO] [stderr] 47 | | registers: Registers::new(), [INFO] [stderr] 48 | | memory: Memory::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | impl Default for cpu::CPU { [INFO] [stderr] 45 | fn default() -> Self { [INFO] [stderr] 46 | Self::new() [INFO] [stderr] 47 | } [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:112:73 [INFO] [stderr] | [INFO] [stderr] 112 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:117:73 [INFO] [stderr] | [INFO] [stderr] 117 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:122:73 [INFO] [stderr] | [INFO] [stderr] 122 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:152:73 [INFO] [stderr] | [INFO] [stderr] 152 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:158:73 [INFO] [stderr] | [INFO] [stderr] 158 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:163:73 [INFO] [stderr] | [INFO] [stderr] 163 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:168:73 [INFO] [stderr] | [INFO] [stderr] 168 | let addr = self.registers.program_counter + AddressDiff(rel as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/cpu.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | / loop { [INFO] [stderr] 414 | | if let Some(decoded_instr) = self.fetch_next_and_decode() { [INFO] [stderr] 415 | | self.execute_instruction(decoded_instr); [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | break; [INFO] [stderr] 418 | | } [INFO] [stderr] 419 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(decoded_instr) = self.fetch_next_and_decode() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | *p_val = *p_val >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*p_val >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/cpu.rs:778:5 [INFO] [stderr] | [INFO] [stderr] 778 | / fn add_with_carry_test() { [INFO] [stderr] 779 | | let mut CPU = CPU::new(); [INFO] [stderr] 780 | | [INFO] [stderr] 781 | | CPU.add_with_carry(1); [INFO] [stderr] ... | [INFO] [stderr] 847 | | assert_eq!(CPU.registers.status.contains(PS_OVERFLOW), true); [INFO] [stderr] 848 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:779:13 [INFO] [stderr] | [INFO] [stderr] 779 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:802:13 [INFO] [stderr] | [INFO] [stderr] 802 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:833:13 [INFO] [stderr] | [INFO] [stderr] 833 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:852:13 [INFO] [stderr] | [INFO] [stderr] 852 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/cpu.rs:880:5 [INFO] [stderr] | [INFO] [stderr] 880 | / fn subtract_with_carry_test() { [INFO] [stderr] 881 | | let mut CPU = CPU::new(); [INFO] [stderr] 882 | | [INFO] [stderr] 883 | | CPU.execute_instruction((Instruction::SEC, OpInput::UseImplied)); [INFO] [stderr] ... | [INFO] [stderr] 936 | | assert_eq!(CPU.registers.status.contains(PS_OVERFLOW), false); [INFO] [stderr] 937 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:881:13 [INFO] [stderr] | [INFO] [stderr] 881 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:941:13 [INFO] [stderr] | [INFO] [stderr] 941 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:973:13 [INFO] [stderr] | [INFO] [stderr] 973 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/cpu.rs:1008:5 [INFO] [stderr] | [INFO] [stderr] 1008 | / fn dec_x_test() { [INFO] [stderr] 1009 | | let mut CPU = CPU::new(); [INFO] [stderr] 1010 | | [INFO] [stderr] 1011 | | CPU.dec_x(); [INFO] [stderr] ... | [INFO] [stderr] 1049 | | assert_eq!(CPU.registers.status.contains(PS_OVERFLOW), false); [INFO] [stderr] 1050 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1009:13 [INFO] [stderr] | [INFO] [stderr] 1009 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1054:13 [INFO] [stderr] | [INFO] [stderr] 1054 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1076:13 [INFO] [stderr] | [INFO] [stderr] 1076 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1089:13 [INFO] [stderr] | [INFO] [stderr] 1089 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1102:17 [INFO] [stderr] | [INFO] [stderr] 1102 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1111:17 [INFO] [stderr] | [INFO] [stderr] 1111 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1124:13 [INFO] [stderr] | [INFO] [stderr] 1124 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1137:13 [INFO] [stderr] | [INFO] [stderr] 1137 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1150:13 [INFO] [stderr] | [INFO] [stderr] 1150 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1165:13 [INFO] [stderr] | [INFO] [stderr] 1165 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1218:19 [INFO] [stderr] | [INFO] [stderr] 1218 | &mut |CPU: &mut CPU, val: u8| { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1228:19 [INFO] [stderr] | [INFO] [stderr] 1228 | &mut |CPU: &mut CPU, val: u8| { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1238:19 [INFO] [stderr] | [INFO] [stderr] 1238 | &mut |CPU: &mut CPU, val: u8| { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1247:13 [INFO] [stderr] | [INFO] [stderr] 1247 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `CPU` should have a snake case name such as `cpu` [INFO] [stderr] --> src/cpu.rs:1275:13 [INFO] [stderr] | [INFO] [stderr] 1275 | let mut CPU = CPU::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `memory::Memory` [INFO] [stderr] --> src/memory.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / pub fn new() -> Memory { [INFO] [stderr] 65 | | Memory { bytes: [0; MEMORY_SIZE] } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | impl Default for memory::Memory { [INFO] [stderr] 64 | fn default() -> Self { [INFO] [stderr] 65 | Self::new() [INFO] [stderr] 66 | } [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/memory.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn is_stack_address(address: &Address) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | out = out | PS_NEGATIVE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_NEGATIVE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | out = out | PS_OVERFLOW [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_OVERFLOW` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | out = out | PS_UNUSED [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_UNUSED` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | out = out | PS_BRK [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_BRK` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | out = out | PS_DECIMAL_MODE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_DECIMAL_MODE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | out = out | PS_DISABLE_INTERRUPTS [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_DISABLE_INTERRUPTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | out = out | PS_ZERO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_ZERO` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | out = out | PS_CARRY [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out |= PS_CARRY` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | *self = *self & rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*self &= rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/registers.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | *self = *self | rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*self |= rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/registers.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_address(&self) -> Address { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/registers.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | STACK_ADDRESS_LO + AddressDiff(sp as i32) [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `registers::Registers` [INFO] [stderr] --> src/registers.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn new() -> Registers { [INFO] [stderr] 177 | | // TODO akeeton: Revisit these defaults. [INFO] [stderr] 178 | | Registers { [INFO] [stderr] 179 | | accumulator: 0, [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | impl Default for registers::Registers { [INFO] [stderr] 176 | fn default() -> Self { [INFO] [stderr] 177 | Self::new() [INFO] [stderr] 178 | } [INFO] [stderr] 179 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.69s [INFO] running `"docker" "inspect" "e083fa73dafdf19ee4f93445493787ca546caadcf271dfa1590384e19527c377"` [INFO] running `"docker" "rm" "-f" "e083fa73dafdf19ee4f93445493787ca546caadcf271dfa1590384e19527c377"` [INFO] [stdout] e083fa73dafdf19ee4f93445493787ca546caadcf271dfa1590384e19527c377