[INFO] crate mop-blocks 0.0.4 is already in cache [INFO] extracting crate mop-blocks 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/mop-blocks/0.0.4 [INFO] extracting crate mop-blocks 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mop-blocks/0.0.4 [INFO] validating manifest of mop-blocks-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mop-blocks-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mop-blocks-0.0.4 [INFO] finished frobbing mop-blocks-0.0.4 [INFO] frobbed toml for mop-blocks-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/mop-blocks/0.0.4/Cargo.toml [INFO] started frobbing mop-blocks-0.0.4 [INFO] finished frobbing mop-blocks-0.0.4 [INFO] frobbed toml for mop-blocks-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mop-blocks/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mop-blocks-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mop-blocks/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd9c48984f2c5245a6f8e33e745f7f690d7fb50dcda92bfd6851c258cfd7221d [INFO] running `"docker" "start" "-a" "dd9c48984f2c5245a6f8e33e745f7f690d7fb50dcda92bfd6851c258cfd7221d"` [INFO] [stderr] Checking mop-common v0.0.4 [INFO] [stderr] Checking mop-structs v0.0.4 [INFO] [stderr] Checking mop-blocks v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: trait `Domain` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/domain.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / pub trait Domain: TraitCfg [INFO] [stderr] 22 | | where [INFO] [stderr] 23 | | S: Solution, [INFO] [stderr] 24 | | { [INFO] [stderr] ... | [INFO] [stderr] 33 | | R: Rng; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `mp::mpho::morho::Morho` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/mp/mpho/morho.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Morho { [INFO] [stderr] 44 | | pub fn best(&self) -> Option> { [INFO] [stderr] 45 | | self.best_idx.map(|x| OrhoRef { [INFO] [stderr] 46 | | hard_cstrs_reasons: self.hard_cstrs_reasons.row(x), [INFO] [stderr] ... | [INFO] [stderr] 259 | | } [INFO] [stderr] 260 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mp::mpho::mpho_definitions_builder::MphoDefinitionsBuilder` [INFO] [stderr] --> src/mp/mpho/mpho_definitions_builder.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | MphoDefinitionsBuilder { [INFO] [stderr] 20 | | domain: None, [INFO] [stderr] 21 | | hard_cstrs: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mp/mpho/mod.rs:36:32 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn into_parts(self) -> (MphoDefinitions, Morho) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mp/mpho/mod.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn parts(&self) -> (&MphoDefinitions, &Morho) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mp/mpho/mod.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn parts_mut(&mut self) -> (&mut MphoDefinitions, &mut Morho) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/obj_direction.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn partial_cmp(&self, a: &T, b: &T) -> Option [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/solution.rs:140:34 [INFO] [stderr] | [INFO] [stderr] 140 | (0..self.nnz()).for_each(|x| cb(x)); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/solution.rs:173:38 [INFO] [stderr] | [INFO] [stderr] 173 | (0..$N).for_each(|x| cb(x)); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] ... [INFO] [stderr] 180 | / array_impls!( [INFO] [stderr] 181 | | 0 1 2 3 4 5 6 7 8 9 [INFO] [stderr] 182 | | 10 11 12 13 14 15 16 17 18 19 [INFO] [stderr] 183 | | 20 21 22 23 24 25 26 27 28 29 [INFO] [stderr] 184 | | 30 31 32 0x40 0x80 0x100 0x200 0x400 0x800 0x1000 [INFO] [stderr] 185 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: trait `Domain` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/domain.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / pub trait Domain: TraitCfg [INFO] [stderr] 22 | | where [INFO] [stderr] 23 | | S: Solution, [INFO] [stderr] 24 | | { [INFO] [stderr] ... | [INFO] [stderr] 33 | | R: Rng; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `mp::mpho::morho::Morho` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/mp/mpho/morho.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Morho { [INFO] [stderr] 44 | | pub fn best(&self) -> Option> { [INFO] [stderr] 45 | | self.best_idx.map(|x| OrhoRef { [INFO] [stderr] 46 | | hard_cstrs_reasons: self.hard_cstrs_reasons.row(x), [INFO] [stderr] ... | [INFO] [stderr] 259 | | } [INFO] [stderr] 260 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mp::mpho::mpho_definitions_builder::MphoDefinitionsBuilder` [INFO] [stderr] --> src/mp/mpho/mpho_definitions_builder.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | MphoDefinitionsBuilder { [INFO] [stderr] 20 | | domain: None, [INFO] [stderr] 21 | | hard_cstrs: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mp/mpho/mod.rs:36:32 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn into_parts(self) -> (MphoDefinitions, Morho) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mp/mpho/mod.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn parts(&self) -> (&MphoDefinitions, &Morho) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mp/mpho/mod.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn parts_mut(&mut self) -> (&mut MphoDefinitions, &mut Morho) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/obj_direction.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn partial_cmp(&self, a: &T, b: &T) -> Option [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/solution.rs:140:34 [INFO] [stderr] | [INFO] [stderr] 140 | (0..self.nnz()).for_each(|x| cb(x)); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/solution.rs:173:38 [INFO] [stderr] | [INFO] [stderr] 173 | (0..$N).for_each(|x| cb(x)); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] ... [INFO] [stderr] 180 | / array_impls!( [INFO] [stderr] 181 | | 0 1 2 3 4 5 6 7 8 9 [INFO] [stderr] 182 | | 10 11 12 13 14 15 16 17 18 19 [INFO] [stderr] 183 | | 20 21 22 23 24 25 26 27 28 29 [INFO] [stderr] 184 | | 30 31 32 0x40 0x80 0x100 0x200 0x400 0x800 0x1000 [INFO] [stderr] 185 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.21s [INFO] running `"docker" "inspect" "dd9c48984f2c5245a6f8e33e745f7f690d7fb50dcda92bfd6851c258cfd7221d"` [INFO] running `"docker" "rm" "-f" "dd9c48984f2c5245a6f8e33e745f7f690d7fb50dcda92bfd6851c258cfd7221d"` [INFO] [stdout] dd9c48984f2c5245a6f8e33e745f7f690d7fb50dcda92bfd6851c258cfd7221d