[INFO] crate moore-svlog-hir 0.1.0 is already in cache
[INFO] extracting crate moore-svlog-hir 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/moore-svlog-hir/0.1.0
[INFO] extracting crate moore-svlog-hir 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moore-svlog-hir/0.1.0
[INFO] validating manifest of moore-svlog-hir-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of moore-svlog-hir-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing moore-svlog-hir-0.1.0
[INFO] finished frobbing moore-svlog-hir-0.1.0
[INFO] frobbed toml for moore-svlog-hir-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/moore-svlog-hir/0.1.0/Cargo.toml
[INFO] started frobbing moore-svlog-hir-0.1.0
[INFO] finished frobbing moore-svlog-hir-0.1.0
[INFO] frobbed toml for moore-svlog-hir-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moore-svlog-hir/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting moore-svlog-hir-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/moore-svlog-hir/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bf3d94af184c94f893b6a2fa9f46282168b624e3042e6d982b1b54ccefb4b2af
[INFO] running `"docker" "start" "-a" "bf3d94af184c94f893b6a2fa9f46282168b624e3042e6d982b1b54ccefb4b2af"`
[INFO] [stderr]     Checking memmap v0.5.2
[INFO] [stderr]     Checking moore-common v0.1.0
[INFO] [stderr]     Checking moore-svlog-syntax v0.1.0
[INFO] [stderr]     Checking moore-svlog-hir v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:110:6
[INFO] [stderr]     |
[INFO] [stderr] 110 |                     dir: dir,
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `dir`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:111:6
[INFO] [stderr]     |
[INFO] [stderr] 111 |                     kind: kind,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:112:6
[INFO] [stderr]     |
[INFO] [stderr] 112 |                     ty: ty,
[INFO] [stderr]     |                     ^^^^^^ help: replace it with: `ty`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |                 slices: slices,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `slices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:365:7
[INFO] [stderr]     |
[INFO] [stderr] 365 |                         span: span,
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:593:5
[INFO] [stderr]     |
[INFO] [stderr] 593 |                 span: span,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:594:5
[INFO] [stderr]     |
[INFO] [stderr] 594 |                 slices: slices,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `slices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:612:7
[INFO] [stderr]     |
[INFO] [stderr] 612 |                         selects: selects,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `selects`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lower/mod.rs:20:3
[INFO] [stderr]    |
[INFO] [stderr] 20 |         session: session,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `session`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lower/mod.rs:21:3
[INFO] [stderr]    |
[INFO] [stderr] 21 |         nameres: nameres,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `nameres`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lower/mod.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |         top: top,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `top`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:115:4
[INFO] [stderr]     |
[INFO] [stderr] 115 |             ports: ports,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `ports`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:117:4
[INFO] [stderr]     |
[INFO] [stderr] 117 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:225:4
[INFO] [stderr]     |
[INFO] [stderr] 225 |             ports: ports,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `ports`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:227:4
[INFO] [stderr]     |
[INFO] [stderr] 227 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:248:4
[INFO] [stderr]     |
[INFO] [stderr] 248 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:110:6
[INFO] [stderr]     |
[INFO] [stderr] 110 |                     dir: dir,
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `dir`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:111:6
[INFO] [stderr]     |
[INFO] [stderr] 111 |                     kind: kind,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:112:6
[INFO] [stderr]     |
[INFO] [stderr] 112 |                     ty: ty,
[INFO] [stderr]     |                     ^^^^^^ help: replace it with: `ty`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |                 slices: slices,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `slices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:365:7
[INFO] [stderr]     |
[INFO] [stderr] 365 |                         span: span,
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:593:5
[INFO] [stderr]     |
[INFO] [stderr] 593 |                 span: span,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:594:5
[INFO] [stderr]     |
[INFO] [stderr] 594 |                 slices: slices,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `slices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/port.rs:612:7
[INFO] [stderr]     |
[INFO] [stderr] 612 |                         selects: selects,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `selects`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lower/mod.rs:20:3
[INFO] [stderr]    |
[INFO] [stderr] 20 |         session: session,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `session`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lower/mod.rs:21:3
[INFO] [stderr]    |
[INFO] [stderr] 21 |         nameres: nameres,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `nameres`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lower/mod.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |         top: top,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `top`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:115:4
[INFO] [stderr]     |
[INFO] [stderr] 115 |             ports: ports,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `ports`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:117:4
[INFO] [stderr]     |
[INFO] [stderr] 117 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:225:4
[INFO] [stderr]     |
[INFO] [stderr] 225 |             ports: ports,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `ports`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:227:4
[INFO] [stderr]     |
[INFO] [stderr] 227 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lower/mod.rs:248:4
[INFO] [stderr]     |
[INFO] [stderr] 248 |             body: body,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> lower/port.rs:192:26
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 ast::Port::Explicit{ span: _, dir, name, expr } => {
[INFO] [stderr]     |                                      ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Explicit { dir, name, expr, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> lower/port.rs:236:23
[INFO] [stderr]     |
[INFO] [stderr] 236 |                 ast::Port::Named{ span: _, dir, kind, ty, name, dims, expr } => {
[INFO] [stderr]     |                                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `Named { dir, kind, ty, name, dims, expr, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> lower/port.rs:192:26
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 ast::Port::Explicit{ span: _, dir, name, expr } => {
[INFO] [stderr]     |                                      ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Explicit { dir, name, expr, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> lower/port.rs:236:23
[INFO] [stderr]     |
[INFO] [stderr] 236 |                 ast::Port::Named{ span: _, dir, kind, ty, name, dims, expr } => {
[INFO] [stderr]     |                                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `Named { dir, kind, ty, name, dims, expr, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> lower/port.rs:156:4
[INFO] [stderr]     |
[INFO] [stderr] 156 |               match *item {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 157 | |                 ast::HierarchyItem::PortDecl(ref decl) => {
[INFO] [stderr] 158 | |                     self.add_diag(DiagBuilder2::error("port declarations are only allowed if a non-ANSI port list is used")
[INFO] [stderr] 159 | |                         .span(decl.span));
[INFO] [stderr] ...   |
[INFO] [stderr] 165 | |                 _ => ()
[INFO] [stderr] 166 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 156 |             if let ast::HierarchyItem::PortDecl(ref decl) = *item {
[INFO] [stderr] 157 |     self.add_diag(DiagBuilder2::error("port declarations are only allowed if a non-ANSI port list is used")
[INFO] [stderr] 158 |         .span(decl.span));
[INFO] [stderr] 159 |     self.add_diag(DiagBuilder2::note(format!("...but first port uses ANSI style"))
[INFO] [stderr] 160 |         .span(first_span)
[INFO] [stderr] 161 |         .add_note("non-ANSI ports cannot have a direction, type, or kind"));
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> lower/port.rs:160:39
[INFO] [stderr]     |
[INFO] [stderr] 160 |                     self.add_diag(DiagBuilder2::note(format!("...but first port uses ANSI style"))
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"...but first port uses ANSI style".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 26
[INFO] [stderr]    --> lower/port.rs:320:2
[INFO] [stderr]     |
[INFO] [stderr] 320 |       fn map_nonansi_ports(&mut self, ports: Vec<ast::Port>, items: &[ast::HierarchyItem], first_span: Span) -> Vec<PartialPort> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 321 | |         let mut mapped = Vec::new();
[INFO] [stderr] 322 | |
[INFO] [stderr] 323 | |         // Create a stub port for each port in the list. Port declarations in
[INFO] [stderr] ...   |
[INFO] [stderr] 598 | |         mapped
[INFO] [stderr] 599 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> lower/port.rs:639:96
[INFO] [stderr]     |
[INFO] [stderr] 639 |       fn find_items_relevant_to_port<'b>(&mut self, items: &'b [ast::HierarchyItem], name: Name) -> (
[INFO] [stderr]     |  ___________________________________________________________________________________________________^
[INFO] [stderr] 640 | |         Vec<(&'b ast::PortDecl, &'b ast::VarDeclName)>,
[INFO] [stderr] 641 | |         Vec<(&'b ast::VarDecl,  &'b ast::VarDeclName)>,
[INFO] [stderr] 642 | |         Vec<(&'b ast::NetDecl,  &'b ast::VarDeclName)>,
[INFO] [stderr] 643 | |     ) {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> lower/mod.rs:196:44
[INFO] [stderr]     |
[INFO] [stderr] 196 |                 x => self.add_diag(DiagBuilder2::fatal(format!("lowering to HIR not implemented for this hierarchy item")).span(x.span()))
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"lowering to HIR not implemented for this hierarchy item".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> lower/port.rs:156:4
[INFO] [stderr]     |
[INFO] [stderr] 156 |               match *item {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 157 | |                 ast::HierarchyItem::PortDecl(ref decl) => {
[INFO] [stderr] 158 | |                     self.add_diag(DiagBuilder2::error("port declarations are only allowed if a non-ANSI port list is used")
[INFO] [stderr] 159 | |                         .span(decl.span));
[INFO] [stderr] ...   |
[INFO] [stderr] 165 | |                 _ => ()
[INFO] [stderr] 166 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 156 |             if let ast::HierarchyItem::PortDecl(ref decl) = *item {
[INFO] [stderr] 157 |     self.add_diag(DiagBuilder2::error("port declarations are only allowed if a non-ANSI port list is used")
[INFO] [stderr] 158 |         .span(decl.span));
[INFO] [stderr] 159 |     self.add_diag(DiagBuilder2::note(format!("...but first port uses ANSI style"))
[INFO] [stderr] 160 |         .span(first_span)
[INFO] [stderr] 161 |         .add_note("non-ANSI ports cannot have a direction, type, or kind"));
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> lower/port.rs:160:39
[INFO] [stderr]     |
[INFO] [stderr] 160 |                     self.add_diag(DiagBuilder2::note(format!("...but first port uses ANSI style"))
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"...but first port uses ANSI style".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 26
[INFO] [stderr]    --> lower/port.rs:320:2
[INFO] [stderr]     |
[INFO] [stderr] 320 |       fn map_nonansi_ports(&mut self, ports: Vec<ast::Port>, items: &[ast::HierarchyItem], first_span: Span) -> Vec<PartialPort> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 321 | |         let mut mapped = Vec::new();
[INFO] [stderr] 322 | |
[INFO] [stderr] 323 | |         // Create a stub port for each port in the list. Port declarations in
[INFO] [stderr] ...   |
[INFO] [stderr] 598 | |         mapped
[INFO] [stderr] 599 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> lower/port.rs:639:96
[INFO] [stderr]     |
[INFO] [stderr] 639 |       fn find_items_relevant_to_port<'b>(&mut self, items: &'b [ast::HierarchyItem], name: Name) -> (
[INFO] [stderr]     |  ___________________________________________________________________________________________________^
[INFO] [stderr] 640 | |         Vec<(&'b ast::PortDecl, &'b ast::VarDeclName)>,
[INFO] [stderr] 641 | |         Vec<(&'b ast::VarDecl,  &'b ast::VarDeclName)>,
[INFO] [stderr] 642 | |         Vec<(&'b ast::NetDecl,  &'b ast::VarDeclName)>,
[INFO] [stderr] 643 | |     ) {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> lower/mod.rs:196:44
[INFO] [stderr]     |
[INFO] [stderr] 196 |                 x => self.add_diag(DiagBuilder2::fatal(format!("lowering to HIR not implemented for this hierarchy item")).span(x.span()))
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"lowering to HIR not implemented for this hierarchy item".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.28s
[INFO] running `"docker" "inspect" "bf3d94af184c94f893b6a2fa9f46282168b624e3042e6d982b1b54ccefb4b2af"`
[INFO] running `"docker" "rm" "-f" "bf3d94af184c94f893b6a2fa9f46282168b624e3042e6d982b1b54ccefb4b2af"`
[INFO] [stdout] bf3d94af184c94f893b6a2fa9f46282168b624e3042e6d982b1b54ccefb4b2af