[INFO] crate moore 0.1.0 is already in cache [INFO] extracting crate moore 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/moore/0.1.0 [INFO] extracting crate moore 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moore/0.1.0 [INFO] validating manifest of moore-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moore-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moore-0.1.0 [INFO] finished frobbing moore-0.1.0 [INFO] frobbed toml for moore-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/moore/0.1.0/Cargo.toml [INFO] started frobbing moore-0.1.0 [INFO] finished frobbing moore-0.1.0 [INFO] frobbed toml for moore-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moore/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moore-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/moore/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e83482a9ad24e0b4bec2056412fe10c1194ea6d075b90fa2955ec5d064065d3d [INFO] running `"docker" "start" "-a" "e83482a9ad24e0b4bec2056412fe10c1194ea6d075b90fa2955ec5d064065d3d"` [INFO] [stderr] Checking moore-common v0.1.0 [INFO] [stderr] Checking llhd v0.1.0 [INFO] [stderr] Checking moore-svlog-syntax v0.1.0 [INFO] [stderr] Checking moore-vhdl-syntax v0.1.0 [INFO] [stderr] Checking moore-vhdl v0.1.0 [INFO] [stderr] Checking moore-svlog-hir v0.1.0 [INFO] [stderr] Checking moore-svlog v0.1.0 [INFO] [stderr] Checking moore v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/score.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | arenas: arenas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `arenas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/score.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | arenas: arenas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `arenas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `score::Arenas` [INFO] [stderr] --> src/score.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / pub fn new() -> Arenas { [INFO] [stderr] 228 | | Arenas { [INFO] [stderr] 229 | | vhdl: vhdl::score::Arenas::new(), [INFO] [stderr] 230 | | defs: Arena::new(), [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | impl Default for score::Arenas { [INFO] [stderr] 226 | fn default() -> Self { [INFO] [stderr] 227 | Self::new() [INFO] [stderr] 228 | } [INFO] [stderr] 229 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `score::Arenas` [INFO] [stderr] --> src/score.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / pub fn new() -> Arenas { [INFO] [stderr] 228 | | Arenas { [INFO] [stderr] 229 | | vhdl: vhdl::score::Arenas::new(), [INFO] [stderr] 230 | | defs: Arena::new(), [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | impl Default for score::Arenas { [INFO] [stderr] 226 | fn default() -> Self { [INFO] [stderr] 227 | Self::new() [INFO] [stderr] 228 | } [INFO] [stderr] 229 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/moore.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | sess: sess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/moore.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | sess: sess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let svlog_sb =` [INFO] [stderr] --> src/bin/moore.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | let svlog_sb = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/moore.rs:446:25 [INFO] [stderr] | [INFO] [stderr] 446 | let archs = ctx.vhdl().archs(vhdl::score::LibRef::new(lib.into()))?.by_entity.get(&entity).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ctx.vhdl().archs(vhdl::score::LibRef::new(lib.into()))?.by_entity[&entity]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/moore.rs:482:47 [INFO] [stderr] | [INFO] [stderr] 482 | ctx.sess.emit(DiagBuilder2::error(format!("SystemVerilog elaboration not supported"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SystemVerilog elaboration not supported".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let svlog_sb =` [INFO] [stderr] --> src/bin/moore.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | let svlog_sb = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/moore.rs:446:25 [INFO] [stderr] | [INFO] [stderr] 446 | let archs = ctx.vhdl().archs(vhdl::score::LibRef::new(lib.into()))?.by_entity.get(&entity).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ctx.vhdl().archs(vhdl::score::LibRef::new(lib.into()))?.by_entity[&entity]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/moore.rs:482:47 [INFO] [stderr] | [INFO] [stderr] 482 | ctx.sess.emit(DiagBuilder2::error(format!("SystemVerilog elaboration not supported"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SystemVerilog elaboration not supported".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.71s [INFO] running `"docker" "inspect" "e83482a9ad24e0b4bec2056412fe10c1194ea6d075b90fa2955ec5d064065d3d"` [INFO] running `"docker" "rm" "-f" "e83482a9ad24e0b4bec2056412fe10c1194ea6d075b90fa2955ec5d064065d3d"` [INFO] [stdout] e83482a9ad24e0b4bec2056412fe10c1194ea6d075b90fa2955ec5d064065d3d