[INFO] crate moonlander-gp 0.1.1 is already in cache [INFO] extracting crate moonlander-gp 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/moonlander-gp/0.1.1 [INFO] extracting crate moonlander-gp 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moonlander-gp/0.1.1 [INFO] validating manifest of moonlander-gp-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moonlander-gp-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moonlander-gp-0.1.1 [INFO] finished frobbing moonlander-gp-0.1.1 [INFO] frobbed toml for moonlander-gp-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/moonlander-gp/0.1.1/Cargo.toml [INFO] started frobbing moonlander-gp-0.1.1 [INFO] finished frobbing moonlander-gp-0.1.1 [INFO] frobbed toml for moonlander-gp-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/moonlander-gp/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moonlander-gp-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/moonlander-gp/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5a5b547a8ff9b79a4b89153a1630d63dfb72bf7df1d48b6b89893772e43a732 [INFO] running `"docker" "start" "-a" "a5a5b547a8ff9b79a4b89153a1630d63dfb72bf7df1d48b6b89893772e43a732"` [INFO] [stderr] Checking downcast v0.6.0 [INFO] [stderr] Checking rayon v0.4.3 [INFO] [stderr] Checking moonlander-gp v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/population.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | generation: generation [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/population.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | generation: generation [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/genetic/fitness.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return self.1.eq(&other.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.1.eq(&other.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/genetic/fitness.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return self.1.partial_cmp(&other.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.1.partial_cmp(&other.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/genetic/fitness.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return self.1.partial_cmp(&other.1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.1.partial_cmp(&other.1).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/pick.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/genetic/evolve.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / pick![rng, [INFO] [stderr] 29 | | weights.reproduce, { [INFO] [stderr] 30 | | let winner = selector(&pop, rng); [INFO] [stderr] 31 | | ret.add(winner.clone()); [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | ]; [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/pick.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | let result = $( if bound <= random_number && random_number < { bound += $weight; bound } { [INFO] [stderr] | _________________________^ [INFO] [stderr] 12 | | $expression [INFO] [stderr] 13 | | } else )+ { [INFO] [stderr] 14 | | panic!(); [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/genetic/evolve.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / pick![rng, [INFO] [stderr] 29 | | weights.reproduce, { [INFO] [stderr] 30 | | let winner = selector(&pop, rng); [INFO] [stderr] 31 | | ret.add(winner.clone()); [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | ]; [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/pick.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/impl_astnode.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / impl_astnode!(Tree, 666, [INFO] [stderr] 127 | | leaf Leaf((data d |rng: &mut ::rand::Rng| (rng.next_u32() % 100) as i32)), [INFO] [stderr] 128 | | int Node(left, right)); [INFO] [stderr] | |_________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/pick.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | let result = $( if bound <= random_number && random_number < { bound += $weight; bound } { [INFO] [stderr] | _________________________^ [INFO] [stderr] 12 | | $expression [INFO] [stderr] 13 | | } else )+ { [INFO] [stderr] 14 | | panic!(); [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/impl_astnode.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / impl_astnode!(Tree, 666, [INFO] [stderr] 127 | | leaf Leaf((data d |rng: &mut ::rand::Rng| (rng.next_u32() % 100) as i32)), [INFO] [stderr] 128 | | int Node(left, right)); [INFO] [stderr] | |_________________________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/pick.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/random_pop.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / impl_astnode!(List, 0, [INFO] [stderr] 121 | | int Cons(next), [INFO] [stderr] 122 | | leaf Nil()); [INFO] [stderr] | |______________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/pick.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | let result = $( if bound <= random_number && random_number < { bound += $weight; bound } { [INFO] [stderr] | _________________________^ [INFO] [stderr] 12 | | $expression [INFO] [stderr] 13 | | } else )+ { [INFO] [stderr] 14 | | panic!(); [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/random_pop.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / impl_astnode!(List, 0, [INFO] [stderr] 121 | | int Cons(next), [INFO] [stderr] 122 | | leaf Nil()); [INFO] [stderr] | |______________________________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/genetic/fitness.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return self.1.eq(&other.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.1.eq(&other.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/genetic/fitness.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return self.1.partial_cmp(&other.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.1.partial_cmp(&other.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/genetic/fitness.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return self.1.partial_cmp(&other.1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.1.partial_cmp(&other.1).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/pick.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/genetic/evolve.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / pick![rng, [INFO] [stderr] 29 | | weights.reproduce, { [INFO] [stderr] 30 | | let winner = selector(&pop, rng); [INFO] [stderr] 31 | | ret.add(winner.clone()); [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | ]; [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/pick.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | let result = $( if bound <= random_number && random_number < { bound += $weight; bound } { [INFO] [stderr] | _________________________^ [INFO] [stderr] 12 | | $expression [INFO] [stderr] 13 | | } else )+ { [INFO] [stderr] 14 | | panic!(); [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/genetic/evolve.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / pick![rng, [INFO] [stderr] 29 | | weights.reproduce, { [INFO] [stderr] 30 | | let winner = selector(&pop, rng); [INFO] [stderr] 31 | | ret.add(winner.clone()); [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | ]; [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&T`) [INFO] [stderr] --> src/ast.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | impl_downcast!(AstNode); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&mut T`) [INFO] [stderr] --> src/ast.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | impl_downcast!(AstNode); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ast.rs:83:60 [INFO] [stderr] | [INFO] [stderr] 83 | let current_root_path = Rc::new(NodeInTree { node: node.clone(), root_path: Some(parent_root_path.clone()) }); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 83 | let current_root_path = Rc::new(NodeInTree { node: &(*node).clone(), root_path: Some(parent_root_path.clone()) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 83 | let current_root_path = Rc::new(NodeInTree { node: &(dyn ast::AstNode + 'static)::clone(node), root_path: Some(parent_root_path.clone()) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/ast.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | let address: *mut() = mem::transmute(node1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `node1 as *const T as *mut ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/population.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn champion<'a>(&'a self) -> CreatureScore<'a, P, F> [INFO] [stderr] 63 | | where P: Encodable, F: Encodable [INFO] [stderr] 64 | | { [INFO] [stderr] 65 | | let indexes = 0..self.n(); [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/population.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | let winner_i = indexes.into_iter().max_by_key(|i| self.scores[*i].score_card()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `indexes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/population.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn best_n<'a>(&self, n: usize) -> Vec

[INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/population.rs:79:38 [INFO] [stderr] | [INFO] [stderr] 79 | indexes[indexes.len() - n..].into_iter().map(|i| self.population[*i].clone()).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn internal(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn leaf(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn next_level(&self) -> NodeWeights { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn gen_child(&self, rng: &mut Rng) -> Box

{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/genetic/crossover.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let nap1 = rng.choose(&nodes1.get(typ).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&nodes1[typ]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/genetic/crossover.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | let nap2 = rng.choose(&nodes2.get(typ).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&nodes2[typ]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/genetic/fitness.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn add(self, scores: Scores) -> ScoreCard { [INFO] [stderr] 62 | | let mut xs = self.0; [INFO] [stderr] 63 | | xs.extend(scores); [INFO] [stderr] 64 | | ScoreCard::new(xs) [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/genetic/fitness.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | / match find_rec(&mut self.0, name) { [INFO] [stderr] 128 | | Some(rec) => { rec.1 += value; increased = true; }, [INFO] [stderr] 129 | | None => { /* Moved outside match because borrow checker can't end scope early */ } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(rec) = find_rec(&mut self.0, name) { rec.1 += value; increased = true; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `moonlander-gp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&T`) [INFO] [stderr] --> src/ast.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | impl_downcast!(AstNode); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&mut T`) [INFO] [stderr] --> src/ast.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | impl_downcast!(AstNode); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ast.rs:83:60 [INFO] [stderr] | [INFO] [stderr] 83 | let current_root_path = Rc::new(NodeInTree { node: node.clone(), root_path: Some(parent_root_path.clone()) }); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 83 | let current_root_path = Rc::new(NodeInTree { node: &(*node).clone(), root_path: Some(parent_root_path.clone()) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 83 | let current_root_path = Rc::new(NodeInTree { node: &(dyn ast::AstNode + 'static)::clone(node), root_path: Some(parent_root_path.clone()) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/ast.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | let address: *mut() = mem::transmute(node1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `node1 as *const T as *mut ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/population.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn champion<'a>(&'a self) -> CreatureScore<'a, P, F> [INFO] [stderr] 63 | | where P: Encodable, F: Encodable [INFO] [stderr] 64 | | { [INFO] [stderr] 65 | | let indexes = 0..self.n(); [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/population.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | let winner_i = indexes.into_iter().max_by_key(|i| self.scores[*i].score_card()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `indexes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/population.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn best_n<'a>(&self, n: usize) -> Vec

[INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/population.rs:79:38 [INFO] [stderr] | [INFO] [stderr] 79 | indexes[indexes.len() - n..].into_iter().map(|i| self.population[*i].clone()).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn internal(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn leaf(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn next_level(&self) -> NodeWeights { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_pop.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn gen_child(&self, rng: &mut Rng) -> Box

{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/genetic/crossover.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let nap1 = rng.choose(&nodes1.get(typ).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&nodes1[typ]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/genetic/crossover.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | let nap2 = rng.choose(&nodes2.get(typ).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&nodes2[typ]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/genetic/fitness.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn add(self, scores: Scores) -> ScoreCard { [INFO] [stderr] 62 | | let mut xs = self.0; [INFO] [stderr] 63 | | xs.extend(scores); [INFO] [stderr] 64 | | ScoreCard::new(xs) [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/genetic/fitness.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | / match find_rec(&mut self.0, name) { [INFO] [stderr] 128 | | Some(rec) => { rec.1 += value; increased = true; }, [INFO] [stderr] 129 | | None => { /* Moved outside match because borrow checker can't end scope early */ } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(rec) = find_rec(&mut self.0, name) { rec.1 += value; increased = true; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/genetic/fitness.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(2.0, added.total_score()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/genetic/fitness.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(2.0, added.total_score()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/genetic/fitness.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!(2.0, added.total_score()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/genetic/fitness.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!(2.0, added.total_score()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `moonlander-gp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a5a5b547a8ff9b79a4b89153a1630d63dfb72bf7df1d48b6b89893772e43a732"` [INFO] running `"docker" "rm" "-f" "a5a5b547a8ff9b79a4b89153a1630d63dfb72bf7df1d48b6b89893772e43a732"` [INFO] [stdout] a5a5b547a8ff9b79a4b89153a1630d63dfb72bf7df1d48b6b89893772e43a732