[INFO] crate monotonic_solver 0.2.1 is already in cache [INFO] extracting crate monotonic_solver 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/monotonic_solver/0.2.1 [INFO] extracting crate monotonic_solver 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/monotonic_solver/0.2.1 [INFO] validating manifest of monotonic_solver-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of monotonic_solver-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing monotonic_solver-0.2.1 [INFO] finished frobbing monotonic_solver-0.2.1 [INFO] frobbed toml for monotonic_solver-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/monotonic_solver/0.2.1/Cargo.toml [INFO] started frobbing monotonic_solver-0.2.1 [INFO] finished frobbing monotonic_solver-0.2.1 [INFO] frobbed toml for monotonic_solver-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/monotonic_solver/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting monotonic_solver-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/monotonic_solver/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43f4e354925278677e296479ab63483e9e49d00fcbd7bc967b69c1a3a537f8b6 [INFO] running `"docker" "start" "-a" "43f4e354925278677e296479ab63483e9e49d00fcbd7bc967b69c1a3a537f8b6"` [INFO] [stderr] Checking monotonic_solver v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:316:23 [INFO] [stderr] | [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 311 | pub fn solve( [INFO] [stderr] 312 | start: &[T], [INFO] [stderr] 313 | goal: &[T], [INFO] [stderr] 314 | filter: &[T], [INFO] [stderr] 315 | order_constraints: &[(T, T)], [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 318 | let mut cache = HashSet::default(); [INFO] [stderr] 319 | for s in start { [INFO] [stderr] 320 | cache.insert(s.clone()); [INFO] [stderr] 321 | } [INFO] [stderr] 322 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:316:50 [INFO] [stderr] | [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 311 | pub fn solve( [INFO] [stderr] 312 | start: &[T], [INFO] [stderr] 313 | goal: &[T], [INFO] [stderr] 314 | filter: &[T], [INFO] [stderr] 315 | order_constraints: &[(T, T)], [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 318 | let mut cache = HashSet::default(); [INFO] [stderr] 319 | for s in start { [INFO] [stderr] 320 | cache.insert(s.clone()); [INFO] [stderr] 321 | } [INFO] [stderr] 322 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:365:23 [INFO] [stderr] | [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 360 | pub fn solve_and_reduce( [INFO] [stderr] 361 | start: &[T], [INFO] [stderr] 362 | goal: &[T], [INFO] [stderr] 363 | filter: &[T], [INFO] [stderr] 364 | order_constraints: &[(T, T)], [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 360 | pub fn solve_and_reduce( [INFO] [stderr] 361 | start: &[T], [INFO] [stderr] 362 | goal: &[T], [INFO] [stderr] 363 | filter: &[T], [INFO] [stderr] 364 | order_constraints: &[(T, T)], [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:365:12 [INFO] [stderr] | [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:409:23 [INFO] [stderr] | [INFO] [stderr] 409 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 403 | pub fn search( [INFO] [stderr] 404 | start: &[T], [INFO] [stderr] 405 | pat: F, [INFO] [stderr] 406 | max_size: usize, [INFO] [stderr] 407 | filter: &[T], [INFO] [stderr] 408 | order_constraints: &[(T, T)], [INFO] [stderr] ... [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 414 | let mut cache = HashSet::default(); [INFO] [stderr] 415 | for s in start { [INFO] [stderr] 416 | cache.insert(s.clone()); [INFO] [stderr] 417 | } [INFO] [stderr] 418 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:409:50 [INFO] [stderr] | [INFO] [stderr] 409 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 403 | pub fn search( [INFO] [stderr] 404 | start: &[T], [INFO] [stderr] 405 | pat: F, [INFO] [stderr] 406 | max_size: usize, [INFO] [stderr] 407 | filter: &[T], [INFO] [stderr] 408 | order_constraints: &[(T, T)], [INFO] [stderr] ... [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 414 | let mut cache = HashSet::default(); [INFO] [stderr] 415 | for s in start { [INFO] [stderr] 416 | cache.insert(s.clone()); [INFO] [stderr] 417 | } [INFO] [stderr] 418 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:409:12 [INFO] [stderr] | [INFO] [stderr] 409 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:316:23 [INFO] [stderr] | [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 311 | pub fn solve( [INFO] [stderr] 312 | start: &[T], [INFO] [stderr] 313 | goal: &[T], [INFO] [stderr] 314 | filter: &[T], [INFO] [stderr] 315 | order_constraints: &[(T, T)], [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 318 | let mut cache = HashSet::default(); [INFO] [stderr] 319 | for s in start { [INFO] [stderr] 320 | cache.insert(s.clone()); [INFO] [stderr] 321 | } [INFO] [stderr] 322 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:316:50 [INFO] [stderr] | [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 311 | pub fn solve( [INFO] [stderr] 312 | start: &[T], [INFO] [stderr] 313 | goal: &[T], [INFO] [stderr] 314 | filter: &[T], [INFO] [stderr] 315 | order_constraints: &[(T, T)], [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 318 | let mut cache = HashSet::default(); [INFO] [stderr] 319 | for s in start { [INFO] [stderr] 320 | cache.insert(s.clone()); [INFO] [stderr] 321 | } [INFO] [stderr] 322 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:365:23 [INFO] [stderr] | [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 360 | pub fn solve_and_reduce( [INFO] [stderr] 361 | start: &[T], [INFO] [stderr] 362 | goal: &[T], [INFO] [stderr] 363 | filter: &[T], [INFO] [stderr] 364 | order_constraints: &[(T, T)], [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 360 | pub fn solve_and_reduce( [INFO] [stderr] 361 | start: &[T], [INFO] [stderr] 362 | goal: &[T], [INFO] [stderr] 363 | filter: &[T], [INFO] [stderr] 364 | order_constraints: &[(T, T)], [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:365:12 [INFO] [stderr] | [INFO] [stderr] 365 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:409:23 [INFO] [stderr] | [INFO] [stderr] 409 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 403 | pub fn search( [INFO] [stderr] 404 | start: &[T], [INFO] [stderr] 405 | pat: F, [INFO] [stderr] 406 | max_size: usize, [INFO] [stderr] 407 | filter: &[T], [INFO] [stderr] 408 | order_constraints: &[(T, T)], [INFO] [stderr] ... [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 414 | let mut cache = HashSet::default(); [INFO] [stderr] 415 | for s in start { [INFO] [stderr] 416 | cache.insert(s.clone()); [INFO] [stderr] 417 | } [INFO] [stderr] 418 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:409:50 [INFO] [stderr] | [INFO] [stderr] 409 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 403 | pub fn search( [INFO] [stderr] 404 | start: &[T], [INFO] [stderr] 405 | pat: F, [INFO] [stderr] 406 | max_size: usize, [INFO] [stderr] 407 | filter: &[T], [INFO] [stderr] 408 | order_constraints: &[(T, T)], [INFO] [stderr] ... [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 414 | let mut cache = HashSet::default(); [INFO] [stderr] 415 | for s in start { [INFO] [stderr] 416 | cache.insert(s.clone()); [INFO] [stderr] 417 | } [INFO] [stderr] 418 | let mut filter_cache: HashSet = HashSet::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:409:12 [INFO] [stderr] | [INFO] [stderr] 409 | infer: fn(cache: &HashSet, filter_cache: &HashSet, story: &[T]) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> examples/drama.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(box_patterns)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `monotonic_solver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/groceries.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | fn likes(&self, fruit: Fruit) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/groceries.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | fn is_sweet(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/groceries.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | fn is_sour(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/groceries.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | fn is_bitter(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/groceries.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / if let &Preference(x, taste1, taste2) = expr { [INFO] [stderr] 72 | | for expr2 in story { [INFO] [stderr] 73 | | if let &ForSale(y) = expr2 { [INFO] [stderr] 74 | | // Both tastes must be satisfied for the fruit. [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | if let Preference(x, taste1, taste2) = *expr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/groceries.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | / if let &ForSale(y) = expr2 { [INFO] [stderr] 74 | | // Both tastes must be satisfied for the fruit. [INFO] [stderr] 75 | | if taste1.likes(y) && taste2.likes(y) { [INFO] [stderr] 76 | | let new_expr = Buy(x, y); [INFO] [stderr] 77 | | if can_add(&new_expr) {return Some(new_expr)}; [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | if let ForSale(y) = *expr2 { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/groceries.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | |expr| if let &Buy(x, y) = expr {if x == person {Some(y)} else {None}} else {None}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | |expr| if let Buy(x, y) = *expr {if x == person {Some(y)} else {None}} else {None}, [INFO] [stderr] | ^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "43f4e354925278677e296479ab63483e9e49d00fcbd7bc967b69c1a3a537f8b6"` [INFO] running `"docker" "rm" "-f" "43f4e354925278677e296479ab63483e9e49d00fcbd7bc967b69c1a3a537f8b6"` [INFO] [stdout] 43f4e354925278677e296479ab63483e9e49d00fcbd7bc967b69c1a3a537f8b6