[INFO] crate monome-rs 0.2.0 is already in cache [INFO] extracting crate monome-rs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/monome-rs/0.2.0 [INFO] extracting crate monome-rs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/monome-rs/0.2.0 [INFO] validating manifest of monome-rs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of monome-rs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing monome-rs-0.2.0 [INFO] finished frobbing monome-rs-0.2.0 [INFO] frobbed toml for monome-rs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/monome-rs/0.2.0/Cargo.toml [INFO] started frobbing monome-rs-0.2.0 [INFO] finished frobbing monome-rs-0.2.0 [INFO] frobbed toml for monome-rs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/monome-rs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting monome-rs-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/monome-rs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cb2cbef5cebd7f41c712f375849f599f5f67ea15a4b5412e69cfd48b8eec299 [INFO] running `"docker" "start" "-a" "0cb2cbef5cebd7f41c712f375849f599f5f67ea15a4b5412e69cfd48b8eec299"` [INFO] [stderr] Checking monome-rs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / return MonomeInfo { [INFO] [stderr] 53 | | port: None, [INFO] [stderr] 54 | | host: None, [INFO] [stderr] 55 | | prefix: None, [INFO] [stderr] ... | [INFO] [stderr] 58 | | rotation: None, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | MonomeInfo { [INFO] [stderr] 53 | port: None, [INFO] [stderr] 54 | host: None, [INFO] [stderr] 55 | prefix: None, [INFO] [stderr] 56 | id: None, [INFO] [stderr] 57 | size: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / return Transport { [INFO] [stderr] 129 | | device_port, [INFO] [stderr] 130 | | socket, [INFO] [stderr] 131 | | tx, [INFO] [stderr] 132 | | rx, [INFO] [stderr] 133 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 128 | Transport { [INFO] [stderr] 129 | device_port, [INFO] [stderr] 130 | socket, [INFO] [stderr] 131 | tx, [INFO] [stderr] 132 | rx, [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | return Ok(monome); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(monome)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:928:17 [INFO] [stderr] | [INFO] [stderr] 928 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:932:17 [INFO] [stderr] | [INFO] [stderr] 932 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / return MonomeInfo { [INFO] [stderr] 53 | | port: None, [INFO] [stderr] 54 | | host: None, [INFO] [stderr] 55 | | prefix: None, [INFO] [stderr] ... | [INFO] [stderr] 58 | | rotation: None, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | MonomeInfo { [INFO] [stderr] 53 | port: None, [INFO] [stderr] 54 | host: None, [INFO] [stderr] 55 | prefix: None, [INFO] [stderr] 56 | id: None, [INFO] [stderr] 57 | size: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / return Transport { [INFO] [stderr] 129 | | device_port, [INFO] [stderr] 130 | | socket, [INFO] [stderr] 131 | | tx, [INFO] [stderr] 132 | | rx, [INFO] [stderr] 133 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 128 | Transport { [INFO] [stderr] 129 | device_port, [INFO] [stderr] 130 | socket, [INFO] [stderr] 131 | tx, [INFO] [stderr] 132 | rx, [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | return Ok(monome); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(monome)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:928:17 [INFO] [stderr] | [INFO] [stderr] 928 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:932:17 [INFO] [stderr] | [INFO] [stderr] 932 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/lib.rs:1190:13 [INFO] [stderr] | [INFO] [stderr] 1190 | let m = Monome::new_with_port("/plop".to_string(), SERIALOSC_PORT + 1).unwrap(); [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `poll_send_to` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:151:80 [INFO] [stderr] | [INFO] [stderr] 151 | let _amt = try_ready!(self.socket.poll_send_to(&mut b.unwrap(), &addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:277:54 [INFO] [stderr] | [INFO] [stderr] 277 | for item in self.iter().map(|i| OscType::Int(*i as i32)) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:288:39 [INFO] [stderr] | [INFO] [stderr] 288 | osctype_vec.push(OscType::Int(*self as i32)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:297:54 [INFO] [stderr] | [INFO] [stderr] 297 | for item in self.iter().map(|i| OscType::Int(*i as i32)) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:321:55 [INFO] [stderr] | [INFO] [stderr] 321 | for item in masks.iter().map(|i| OscType::Int(*i as i32)) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | prefix: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | / match rv { [INFO] [stderr] 388 | | Ok(rv) => { [INFO] [stderr] 389 | | break (socket, rv); [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | Err(_) => {} [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 387 | if let Ok(rv) = rv { [INFO] [stderr] 388 | break (socket, rv); [INFO] [stderr] 389 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `poll_send_to` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:151:80 [INFO] [stderr] | [INFO] [stderr] 151 | let _amt = try_ready!(self.socket.poll_send_to(&mut b.unwrap(), &addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:277:54 [INFO] [stderr] | [INFO] [stderr] 277 | for item in self.iter().map(|i| OscType::Int(*i as i32)) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:288:39 [INFO] [stderr] | [INFO] [stderr] 288 | osctype_vec.push(OscType::Int(*self as i32)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:297:54 [INFO] [stderr] | [INFO] [stderr] 297 | for item in self.iter().map(|i| OscType::Int(*i as i32)) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:321:55 [INFO] [stderr] | [INFO] [stderr] 321 | for item in masks.iter().map(|i| OscType::Int(*i as i32)) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | prefix: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:937:26 [INFO] [stderr] | [INFO] [stderr] 937 | fn parse(&self, buf: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lib.rs:937:5 [INFO] [stderr] | [INFO] [stderr] 937 | / fn parse(&self, buf: &Vec) -> Option { [INFO] [stderr] 938 | | let packet = decode(buf).unwrap(); [INFO] [stderr] 939 | | debug!("⇦ {:?}", packet); [INFO] [stderr] 940 | | [INFO] [stderr] ... | [INFO] [stderr] 1027 | | } [INFO] [stderr] 1028 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | / match rv { [INFO] [stderr] 388 | | Ok(rv) => { [INFO] [stderr] 389 | | break (socket, rv); [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | Err(_) => {} [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 387 | if let Ok(rv) = rv { [INFO] [stderr] 388 | break (socket, rv); [INFO] [stderr] 389 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:1063:30 [INFO] [stderr] | [INFO] [stderr] 1063 | let pair = Arc::new((Mutex::new(false), Condvar::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:937:26 [INFO] [stderr] | [INFO] [stderr] 937 | fn parse(&self, buf: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lib.rs:937:5 [INFO] [stderr] | [INFO] [stderr] 937 | / fn parse(&self, buf: &Vec) -> Option { [INFO] [stderr] 938 | | let packet = decode(buf).unwrap(); [INFO] [stderr] 939 | | debug!("⇦ {:?}", packet); [INFO] [stderr] 940 | | [INFO] [stderr] ... | [INFO] [stderr] 1027 | | } [INFO] [stderr] 1028 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> examples/random.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | v2[i] = if random::() % 2 == 0 { false } else { true }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(random::() % 2 == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> examples/tilt.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for x in 0..128 { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `grid[..128].clone_from_slice(&grid2[..128])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/tilt.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | / match direction { [INFO] [stderr] 45 | | KeyDirection::Down => { [INFO] [stderr] 46 | | let idx = toidx(x, y, 16); [INFO] [stderr] 47 | | grid[idx] = !grid[idx]; [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | _ => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let KeyDirection::Down = direction { [INFO] [stderr] 45 | let idx = toidx(x, y, 16); [INFO] [stderr] 46 | grid[idx] = !grid[idx]; [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.01s [INFO] running `"docker" "inspect" "0cb2cbef5cebd7f41c712f375849f599f5f67ea15a4b5412e69cfd48b8eec299"` [INFO] running `"docker" "rm" "-f" "0cb2cbef5cebd7f41c712f375849f599f5f67ea15a4b5412e69cfd48b8eec299"` [INFO] [stdout] 0cb2cbef5cebd7f41c712f375849f599f5f67ea15a4b5412e69cfd48b8eec299