[INFO] crate mono_display 0.1.0 is already in cache [INFO] extracting crate mono_display 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mono_display/0.1.0 [INFO] extracting crate mono_display 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mono_display/0.1.0 [INFO] validating manifest of mono_display-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mono_display-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mono_display-0.1.0 [INFO] finished frobbing mono_display-0.1.0 [INFO] frobbed toml for mono_display-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mono_display/0.1.0/Cargo.toml [INFO] started frobbing mono_display-0.1.0 [INFO] finished frobbing mono_display-0.1.0 [INFO] frobbed toml for mono_display-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mono_display/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mono_display-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mono_display/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c2e378f2c6b81bfa992c9bb20ed30f438e81b207b43983ccde1f2304735dab1 [INFO] running `"docker" "start" "-a" "5c2e378f2c6b81bfa992c9bb20ed30f438e81b207b43983ccde1f2304735dab1"` [INFO] [stderr] Compiling font-rs v0.1.3 [INFO] [stderr] Checking bit-set v0.3.0 [INFO] [stderr] Checking rppal v0.7.1 [INFO] [stderr] Checking bdf v0.5.5 [INFO] [stderr] Checking mono_display v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | Error { msg: msg } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | Error { msg: msg } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/gfx.rs:228:28 [INFO] [stderr] | [INFO] [stderr] 228 | let mask = 1 << y % 8; [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (y % 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/gfx.rs:228:28 [INFO] [stderr] | [INFO] [stderr] 228 | let mask = 1 << y % 8; [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (y % 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gfx.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn add_xy(&self, dx: i16, dy: i16) -> Vector { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/gfx.rs:310:20 [INFO] [stderr] | [INFO] [stderr] 310 | for row in (top / 8)..(bottom / 8 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((top / 8)..=bottom / 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(pos as u8 & 0x0f)` [INFO] [stderr] --> src/ssd1306.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | self.send_command(&[0x00 | (pos as u8 & 0x0f)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gfx.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn add_xy(&self, dx: i16, dy: i16) -> Vector { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/gfx.rs:310:20 [INFO] [stderr] | [INFO] [stderr] 310 | for row in (top / 8)..(bottom / 8 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((top / 8)..=bottom / 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(pos as u8 & 0x0f)` [INFO] [stderr] --> src/ssd1306.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | self.send_command(&[0x00 | (pos as u8 & 0x0f)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.28s [INFO] running `"docker" "inspect" "5c2e378f2c6b81bfa992c9bb20ed30f438e81b207b43983ccde1f2304735dab1"` [INFO] running `"docker" "rm" "-f" "5c2e378f2c6b81bfa992c9bb20ed30f438e81b207b43983ccde1f2304735dab1"` [INFO] [stdout] 5c2e378f2c6b81bfa992c9bb20ed30f438e81b207b43983ccde1f2304735dab1