[INFO] crate modulator 0.1.0 is already in cache [INFO] extracting crate modulator 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/modulator/0.1.0 [INFO] extracting crate modulator 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/modulator/0.1.0 [INFO] validating manifest of modulator-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of modulator-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing modulator-0.1.0 [INFO] finished frobbing modulator-0.1.0 [INFO] frobbed toml for modulator-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/modulator/0.1.0/Cargo.toml [INFO] started frobbing modulator-0.1.0 [INFO] finished frobbing modulator-0.1.0 [INFO] frobbed toml for modulator-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/modulator/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting modulator-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/modulator/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a12f2058df611abaa3a6973db56861b834bb8162e2354d477248c886a75335dd [INFO] running `"docker" "start" "-a" "a12f2058df611abaa3a6973db56861b834bb8162e2354d477248c886a75335dd"` [INFO] [stderr] Checking modulator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sources.rs:464:17 [INFO] [stderr] | [INFO] [stderr] 464 | let mut v = a * self.t[0]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sources.rs:464:17 [INFO] [stderr] | [INFO] [stderr] 464 | let mut v = a * self.t[0]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | self.t[1] = self.t[0] + self.t[1]; // make the durations into a timeline [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.t[1] += self.t[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | self.t[2] = self.t[1] + self.t[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.t[2] += self.t[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | self.value = self.value + Newtonian::forward(self.s, f32::min(t, t2) - t0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value += Newtonian::forward(self.s, f32::min(t, t2) - t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:549:17 [INFO] [stderr] | [INFO] [stderr] 549 | self.value = self.value + Newtonian::accelerate(self.d, f32::min(t, t2) - t1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value += Newtonian::accelerate(self.d, f32::min(t, t2) - t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sources.rs:638:43 [INFO] [stderr] | [INFO] [stderr] 638 | fn new_buckets(buckets: usize, range: &[f32; 2]) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:441:44 [INFO] [stderr] | [INFO] [stderr] 441 | pub fn get(&self, key: &str) -> Option<&Box>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn Modulator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:445:52 [INFO] [stderr] | [INFO] [stderr] 445 | pub fn get_mut(&mut self, key: &str) -> Option<&mut Box>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Modulator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | self.t[1] = self.t[0] + self.t[1]; // make the durations into a timeline [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.t[1] += self.t[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | self.t[2] = self.t[1] + self.t[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.t[2] += self.t[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | self.value = self.value + Newtonian::forward(self.s, f32::min(t, t2) - t0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value += Newtonian::forward(self.s, f32::min(t, t2) - t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sources.rs:549:17 [INFO] [stderr] | [INFO] [stderr] 549 | self.value = self.value + Newtonian::accelerate(self.d, f32::min(t, t2) - t1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value += Newtonian::accelerate(self.d, f32::min(t, t2) - t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sources.rs:638:43 [INFO] [stderr] | [INFO] [stderr] 638 | fn new_buckets(buckets: usize, range: &[f32; 2]) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:441:44 [INFO] [stderr] | [INFO] [stderr] 441 | pub fn get(&self, key: &str) -> Option<&Box>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn Modulator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:445:52 [INFO] [stderr] | [INFO] [stderr] 445 | pub fn get_mut(&mut self, key: &str) -> Option<&mut Box>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Modulator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "a12f2058df611abaa3a6973db56861b834bb8162e2354d477248c886a75335dd"` [INFO] running `"docker" "rm" "-f" "a12f2058df611abaa3a6973db56861b834bb8162e2354d477248c886a75335dd"` [INFO] [stdout] a12f2058df611abaa3a6973db56861b834bb8162e2354d477248c886a75335dd