[INFO] crate modbus 1.0.0 is already in cache [INFO] extracting crate modbus 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/modbus/1.0.0 [INFO] extracting crate modbus 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/modbus/1.0.0 [INFO] validating manifest of modbus-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of modbus-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing modbus-1.0.0 [INFO] finished frobbing modbus-1.0.0 [INFO] frobbed toml for modbus-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/modbus/1.0.0/Cargo.toml [INFO] started frobbing modbus-1.0.0 [INFO] finished frobbing modbus-1.0.0 [INFO] frobbed toml for modbus-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/modbus/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting modbus-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/modbus/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 973f0e0b7fcc46bf66fee0ccf556ca3bff16a62c2b963cff2a191af533226694 [INFO] running `"docker" "start" "-a" "973f0e0b7fcc46bf66fee0ccf556ca3bff16a62c2b963cff2a191af533226694"` [INFO] [stderr] Compiling modbus-test-server v0.0.4 [INFO] [stderr] Checking modbus v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/tcp.rs:331:43 [INFO] [stderr] | [INFO] [stderr] 331 | let deserialized = Header::unpack(&vec![50, 16, 15, 90, 0, 99, 68]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[50, 16, 15, 90, 0, 99, 68]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | let qtty: u16 = args[1].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:48:41 [INFO] [stderr] | [INFO] [stderr] 48 | let qtty: u16 = args[1].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | let value: Coil = args[1].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|s| s.trim().parse().expect(matches.usage())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | let qtty: u16 = args[1].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:72:41 [INFO] [stderr] | [INFO] [stderr] 72 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | let value: u16 = args[1].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:77:41 [INFO] [stderr] | [INFO] [stderr] 77 | let addr: u16 = args[0].parse().expect(matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/client.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | .map(|s| s.trim().parse().expect(matches.usage())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = matches.usage(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `"docker" "inspect" "973f0e0b7fcc46bf66fee0ccf556ca3bff16a62c2b963cff2a191af533226694"` [INFO] running `"docker" "rm" "-f" "973f0e0b7fcc46bf66fee0ccf556ca3bff16a62c2b963cff2a191af533226694"` [INFO] [stdout] 973f0e0b7fcc46bf66fee0ccf556ca3bff16a62c2b963cff2a191af533226694