[INFO] crate mnt 0.3.1 is already in cache [INFO] extracting crate mnt 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/mnt/0.3.1 [INFO] extracting crate mnt 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mnt/0.3.1 [INFO] validating manifest of mnt-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mnt-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mnt-0.3.1 [INFO] finished frobbing mnt-0.3.1 [INFO] frobbed toml for mnt-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/mnt/0.3.1/Cargo.toml [INFO] started frobbing mnt-0.3.1 [INFO] finished frobbing mnt-0.3.1 [INFO] frobbed toml for mnt-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mnt/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mnt-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mnt/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11e22e6d188ced8c0461bdd06a51d659cb7accc294b497ef1c5a913b3c22920d [INFO] running `"docker" "start" "-a" "11e22e6d188ced8c0461bdd06a51d659cb7accc294b497ef1c5a913b3c22920d"` [INFO] [stderr] Checking mnt v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | const PROC_MOUNTS: &'static str = "/proc/mounts"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | const PROC_MOUNTS: &'static str = "/proc/mounts"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match search { [INFO] [stderr] 98 | | &MountParam::Spec(spec) => spec == &self.spec, [INFO] [stderr] 99 | | &MountParam::File(file) => file == &self.file, [INFO] [stderr] 100 | | &MountParam::VfsType(vfstype) => vfstype == &self.vfstype, [INFO] [stderr] ... | [INFO] [stderr] 103 | | &MountParam::PassNo(passno) => passno == &self.passno, [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *search { [INFO] [stderr] 98 | MountParam::Spec(spec) => spec == &self.spec, [INFO] [stderr] 99 | MountParam::File(file) => file == &self.file, [INFO] [stderr] 100 | MountParam::VfsType(vfstype) => vfstype == &self.vfstype, [INFO] [stderr] 101 | MountParam::MntOps(mntops) => self.mntops.contains(mntops), [INFO] [stderr] 102 | MountParam::Freq(dumpfield) => dumpfield == &self.freq, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | &MountParam::Spec(spec) => spec == &self.spec, [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.spec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:99:40 [INFO] [stderr] | [INFO] [stderr] 99 | &MountParam::File(file) => file == &self.file, [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | &MountParam::VfsType(vfstype) => vfstype == &self.vfstype, [INFO] [stderr] | ^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.vfstype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parse.rs:208:48 [INFO] [stderr] | [INFO] [stderr] 208 | fn remove_overlaps(self, exclude_files: &Vec) -> Self where T: AsRef; [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match search { [INFO] [stderr] 98 | | &MountParam::Spec(spec) => spec == &self.spec, [INFO] [stderr] 99 | | &MountParam::File(file) => file == &self.file, [INFO] [stderr] 100 | | &MountParam::VfsType(vfstype) => vfstype == &self.vfstype, [INFO] [stderr] ... | [INFO] [stderr] 103 | | &MountParam::PassNo(passno) => passno == &self.passno, [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *search { [INFO] [stderr] 98 | MountParam::Spec(spec) => spec == &self.spec, [INFO] [stderr] 99 | MountParam::File(file) => file == &self.file, [INFO] [stderr] 100 | MountParam::VfsType(vfstype) => vfstype == &self.vfstype, [INFO] [stderr] 101 | MountParam::MntOps(mntops) => self.mntops.contains(mntops), [INFO] [stderr] 102 | MountParam::Freq(dumpfield) => dumpfield == &self.freq, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | &MountParam::Spec(spec) => spec == &self.spec, [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.spec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:99:40 [INFO] [stderr] | [INFO] [stderr] 99 | &MountParam::File(file) => file == &self.file, [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/parse.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | &MountParam::VfsType(vfstype) => vfstype == &self.vfstype, [INFO] [stderr] | ^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.vfstype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parse.rs:208:48 [INFO] [stderr] | [INFO] [stderr] 208 | fn remove_overlaps(self, exclude_files: &Vec) -> Self where T: AsRef; [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/list-submounts.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | let root = match args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/list-mount.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | let target = match args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.93s [INFO] running `"docker" "inspect" "11e22e6d188ced8c0461bdd06a51d659cb7accc294b497ef1c5a913b3c22920d"` [INFO] running `"docker" "rm" "-f" "11e22e6d188ced8c0461bdd06a51d659cb7accc294b497ef1c5a913b3c22920d"` [INFO] [stdout] 11e22e6d188ced8c0461bdd06a51d659cb7accc294b497ef1c5a913b3c22920d