[INFO] crate mmseg 0.1.1 is already in cache [INFO] extracting crate mmseg 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mmseg/0.1.1 [INFO] extracting crate mmseg 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mmseg/0.1.1 [INFO] validating manifest of mmseg-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmseg-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmseg-0.1.1 [INFO] finished frobbing mmseg-0.1.1 [INFO] frobbed toml for mmseg-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mmseg/0.1.1/Cargo.toml [INFO] started frobbing mmseg-0.1.1 [INFO] finished frobbing mmseg-0.1.1 [INFO] frobbed toml for mmseg-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mmseg/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmseg-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mmseg/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d643245e09e46e20e773b9b2ce242d080d083777ab9c48479b0febcd78f66ab3 [INFO] running `"docker" "start" "-a" "d643245e09e46e20e773b9b2ce242d080d083777ab9c48479b0febcd78f66ab3"` [INFO] [stderr] Checking mmseg v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MMSeg` [INFO] [stderr] --> src/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn new() -> Self { [INFO] [stderr] 96 | | let mut seg = Self { [INFO] [stderr] 97 | | words: HashMap::new(), [INFO] [stderr] 98 | | max_word_len: 0, [INFO] [stderr] ... | [INFO] [stderr] 102 | | seg [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / loop { [INFO] [stderr] 162 | | if let Some(token) = self.get_next_token(&chars, &mut pos, simple) { [INFO] [stderr] 163 | | ret.push(token); [INFO] [stderr] 164 | | } else { [INFO] [stderr] 165 | | break; [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(token) = self.get_next_token(&chars, &mut pos, simple) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | if token.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:290:53 [INFO] [stderr] | [INFO] [stderr] 290 | } else if !is_chinese_char(chars[*pos]) { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 291 | | break; [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:288:43 [INFO] [stderr] | [INFO] [stderr] 288 | if index >= self.max_word_len { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 289 | | break; [INFO] [stderr] 290 | | } else if !is_chinese_char(chars[*pos]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mmseg`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MMSeg` [INFO] [stderr] --> src/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn new() -> Self { [INFO] [stderr] 96 | | let mut seg = Self { [INFO] [stderr] 97 | | words: HashMap::new(), [INFO] [stderr] 98 | | max_word_len: 0, [INFO] [stderr] ... | [INFO] [stderr] 102 | | seg [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / loop { [INFO] [stderr] 162 | | if let Some(token) = self.get_next_token(&chars, &mut pos, simple) { [INFO] [stderr] 163 | | ret.push(token); [INFO] [stderr] 164 | | } else { [INFO] [stderr] 165 | | break; [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(token) = self.get_next_token(&chars, &mut pos, simple) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | if token.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:290:53 [INFO] [stderr] | [INFO] [stderr] 290 | } else if !is_chinese_char(chars[*pos]) { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 291 | | break; [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:288:43 [INFO] [stderr] | [INFO] [stderr] 288 | if index >= self.max_word_len { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 289 | | break; [INFO] [stderr] 290 | | } else if !is_chinese_char(chars[*pos]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mmseg`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d643245e09e46e20e773b9b2ce242d080d083777ab9c48479b0febcd78f66ab3"` [INFO] running `"docker" "rm" "-f" "d643245e09e46e20e773b9b2ce242d080d083777ab9c48479b0febcd78f66ab3"` [INFO] [stdout] d643245e09e46e20e773b9b2ce242d080d083777ab9c48479b0febcd78f66ab3