[INFO] crate mmap-storage 0.9.1 is already in cache [INFO] extracting crate mmap-storage 0.9.1 into work/ex/clippy-test-run/sources/stable/reg/mmap-storage/0.9.1 [INFO] extracting crate mmap-storage 0.9.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mmap-storage/0.9.1 [INFO] validating manifest of mmap-storage-0.9.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmap-storage-0.9.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmap-storage-0.9.1 [INFO] finished frobbing mmap-storage-0.9.1 [INFO] frobbed toml for mmap-storage-0.9.1 written to work/ex/clippy-test-run/sources/stable/reg/mmap-storage/0.9.1/Cargo.toml [INFO] started frobbing mmap-storage-0.9.1 [INFO] finished frobbing mmap-storage-0.9.1 [INFO] frobbed toml for mmap-storage-0.9.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mmap-storage/0.9.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmap-storage-0.9.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mmap-storage/0.9.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f234e4925b3fe4a6aea79e7578712ec34eead18d8cf1517329b455ca581285c [INFO] running `"docker" "start" "-a" "4f234e4925b3fe4a6aea79e7578712ec34eead18d8cf1517329b455ca581285c"` [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking mmap-storage v0.9.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/file.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / fn as_inner<'a>(&'a self) -> &'a memmap::MmapMut { [INFO] [stderr] 58 | | match self.inner.as_ref() { [INFO] [stderr] 59 | | Some(inner) => inner, [INFO] [stderr] 60 | | None => unreachable!() [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/file.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / fn as_inner_mut<'a>(&'a mut self) -> &'a mut memmap::MmapMut { [INFO] [stderr] 65 | | match self.inner.as_mut() { [INFO] [stderr] 66 | | Some(inner) => inner, [INFO] [stderr] 67 | | None => unreachable!() [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/file.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | assert!(data.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/file.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / fn as_inner<'a>(&'a self) -> &'a memmap::MmapMut { [INFO] [stderr] 58 | | match self.inner.as_ref() { [INFO] [stderr] 59 | | Some(inner) => inner, [INFO] [stderr] 60 | | None => unreachable!() [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/file.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / fn as_inner_mut<'a>(&'a mut self) -> &'a mut memmap::MmapMut { [INFO] [stderr] 65 | | match self.inner.as_mut() { [INFO] [stderr] 66 | | Some(inner) => inner, [INFO] [stderr] 67 | | None => unreachable!() [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/file.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | assert!(data.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/file_storage.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | const STORAGE_PATH: &'static str = "test_file.bin"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/file_storage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | storage.write(&data).expect("To extend with 10 bytes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/file_storage.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | storage.write(&data[1..]).expect("Write slice of data"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mmap-storage`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4f234e4925b3fe4a6aea79e7578712ec34eead18d8cf1517329b455ca581285c"` [INFO] running `"docker" "rm" "-f" "4f234e4925b3fe4a6aea79e7578712ec34eead18d8cf1517329b455ca581285c"` [INFO] [stdout] 4f234e4925b3fe4a6aea79e7578712ec34eead18d8cf1517329b455ca581285c