[INFO] crate mm_client 0.10.0 is already in cache [INFO] extracting crate mm_client 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/mm_client/0.10.0 [INFO] extracting crate mm_client 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mm_client/0.10.0 [INFO] validating manifest of mm_client-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mm_client-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mm_client-0.10.0 [INFO] finished frobbing mm_client-0.10.0 [INFO] frobbed toml for mm_client-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/mm_client/0.10.0/Cargo.toml [INFO] started frobbing mm_client-0.10.0 [INFO] finished frobbing mm_client-0.10.0 [INFO] frobbed toml for mm_client-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mm_client/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mm_client-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mm_client/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca7d00cea3158919115e7dca272c14f22d59d4247623288695021df1f990f580 [INFO] running `"docker" "start" "-a" "ca7d00cea3158919115e7dca272c14f22d59d4247623288695021df1f990f580"` [INFO] [stderr] Checking mockito v0.2.5 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking mm_client v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | const LIVE_URL: &'static str = "https://media.services.pbs.org/api/v1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | const STAGING_URL: &'static str = "https://media-staging.services.pbs.org/api/v1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | params.unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | const LIVE_URL: &'static str = mockito::SERVER_URL; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | const STAGING_URL: &'static str = mockito::SERVER_URL; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | const KEY: &'static str = "hello"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | const SECRET: &'static str = "world"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | const BASIC_AUTH: &'static str = "Basic aGVsbG86d29ybGQ="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | let test_response = String::from("{\"name\":\"value\"}"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:192:65 [INFO] [stderr] | [INFO] [stderr] 192 | assert_matches!(show_get(id.as_str(), None), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | let test_response = String::from("{\"name\":\"value\"}"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:209:73 [INFO] [stderr] | [INFO] [stderr] 209 | assert_matches!(show_get(id.as_str(), Some(params)), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | let test_response = String::from("{\"name\":\"value\"}"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:225:55 [INFO] [stderr] | [INFO] [stderr] 225 | assert_matches!(show_list(params), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:243:21 [INFO] [stderr] | [INFO] [stderr] 243 | let test_response = String::from("{\"name\":\"value\"}"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:244:55 [INFO] [stderr] | [INFO] [stderr] 244 | assert_matches!(show_list(params), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bad_rq_error` [INFO] [stderr] --> src/lib.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | let bad_rq_error = MMCError::BadRequest(String::from( [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bad_rq_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bad_rq_error` [INFO] [stderr] --> src/lib.rs:262:66 [INFO] [stderr] | [INFO] [stderr] 262 | assert_matches!(show_get(id.as_str(), None), Err(bad_rq_error)) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bad_rq_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:334:25 [INFO] [stderr] | [INFO] [stderr] 334 | let test_response = String::from("{\"name\":\"value\"}"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:337:28 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(test_response) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:364:25 [INFO] [stderr] | [INFO] [stderr] 364 | let test_response = String::from("{\"name\":\"value\"}"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:367:28 [INFO] [stderr] | [INFO] [stderr] 367 | Ok(test_response) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:387:71 [INFO] [stderr] | [INFO] [stderr] 387 | assert_matches!(show_create(p_id.as_str(), &body), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/lib.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | let body = "{\"name\":\"value\"}"; [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bad_rq_error` [INFO] [stderr] --> src/lib.rs:405:21 [INFO] [stderr] | [INFO] [stderr] 405 | let bad_rq_error = MMCError::BadRequest(String::from(server_error)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bad_rq_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bad_rq_error` [INFO] [stderr] --> src/lib.rs:406:72 [INFO] [stderr] | [INFO] [stderr] 406 | assert_matches!(show_create(p_id.as_str(), &body), Err(bad_rq_error)) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bad_rq_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/lib.rs:395:13 [INFO] [stderr] | [INFO] [stderr] 395 | let body = "{\"name\":\"value\"}"; [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:421:21 [INFO] [stderr] | [INFO] [stderr] 421 | let test_response = String::from(body_str); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:422:60 [INFO] [stderr] | [INFO] [stderr] 422 | assert_matches!(show_edit(id.as_str()), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:439:69 [INFO] [stderr] | [INFO] [stderr] 439 | assert_matches!(show_update(id.as_str(), &body), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/lib.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | let body = "{\"name\":\"value\"}"; [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:454:21 [INFO] [stderr] | [INFO] [stderr] 454 | let test_response = String::from(body_str); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_response` [INFO] [stderr] --> src/lib.rs:455:62 [INFO] [stderr] | [INFO] [stderr] 455 | assert_matches!(show_delete(id.as_str()), Ok(test_response)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_test_response` instead [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | params.unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.78s [INFO] running `"docker" "inspect" "ca7d00cea3158919115e7dca272c14f22d59d4247623288695021df1f990f580"` [INFO] running `"docker" "rm" "-f" "ca7d00cea3158919115e7dca272c14f22d59d4247623288695021df1f990f580"` [INFO] [stdout] ca7d00cea3158919115e7dca272c14f22d59d4247623288695021df1f990f580