[INFO] crate mlem-asm 0.1.0 is already in cache
[INFO] extracting crate mlem-asm 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mlem-asm/0.1.0
[INFO] extracting crate mlem-asm 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mlem-asm/0.1.0
[INFO] validating manifest of mlem-asm-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mlem-asm-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mlem-asm-0.1.0
[INFO] finished frobbing mlem-asm-0.1.0
[INFO] frobbed toml for mlem-asm-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mlem-asm/0.1.0/Cargo.toml
[INFO] started frobbing mlem-asm-0.1.0
[INFO] finished frobbing mlem-asm-0.1.0
[INFO] frobbed toml for mlem-asm-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mlem-asm/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mlem-asm-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mlem-asm/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 22d374af0491cdf84e1f73ebc3ca01601c05b3cafa28f7ab854951b59d413409
[INFO] running `"docker" "start" "-a" "22d374af0491cdf84e1f73ebc3ca01601c05b3cafa28f7ab854951b59d413409"`
[INFO] [stderr]     Checking serde_cbor v0.5.2
[INFO] [stderr]     Checking mlem v0.1.0
[INFO] [stderr]     Checking mlem-asm v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lex.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lex.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable `arg3` is assigned to, but never used
[INFO] [stderr]   --> src/parse/mod.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let mut arg3 = None;
[INFO] [stderr]    |             ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_arg3` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `arg3` is never read
[INFO] [stderr]   --> src/parse/mod.rs:70:24
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Ok(v) => { arg3 = Some(v); },
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/parse/address.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     let non_decimal_radix: Option<u32>;
[INFO] [stderr] 63 | |     if item.len() < 2 {
[INFO] [stderr] 64 | |         non_decimal_radix = None;
[INFO] [stderr] 65 | |     } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         };
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let non_decimal_radix = if item.len() < 2 { None } else { match &item[0..2] {
[INFO] [stderr] 63 |             "0x" => Some(16),
[INFO] [stderr] 64 |             "0b" => Some(2),
[INFO] [stderr] 65 |             _ => None,
[INFO] [stderr] 66 |         } };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parse/mod.rs:31:8
[INFO] [stderr]    |
[INFO] [stderr] 31 |     if pieces.len() == 0 { return Ok(None); }
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pieces.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/parse/mod.rs:38:8
[INFO] [stderr]    |
[INFO] [stderr] 38 |     if pieces.len() >= 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pieces.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/parse/mod.rs:169:40
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 errors.push((n as u64, format!("{}", e)));
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parse/mod.rs:173:8
[INFO] [stderr]     |
[INFO] [stderr] 173 |     if errors.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unused comparison that must be used
[INFO] [stderr]   --> src/lex.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 state == LexState::Done;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/lex.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 state == LexState::Done;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lex.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if v.len() == 0 { v.push(new_token); }
[INFO] [stderr]    |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:59:29
[INFO] [stderr]    |
[INFO] [stderr] 59 | pub fn program_to_writer(p: &Program, mut w: &mut Write) -> Result<(), serde_cbor::Error> {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lex.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lex.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> examples/mlem-asm.rs:89:37
[INFO] [stderr]    |
[INFO] [stderr] 89 |                             let mut m = Machine::new(65535, &mut i, &mut o);
[INFO] [stderr]    |                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> examples/mlem-asm.rs:95:37
[INFO] [stderr]    |
[INFO] [stderr] 95 |                             let mut m = Machine::new(65535, &mut i, &mut o);
[INFO] [stderr]    |                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: variable `arg3` is assigned to, but never used
[INFO] [stderr]   --> src/parse/mod.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let mut arg3 = None;
[INFO] [stderr]    |             ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_arg3` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `arg3` is never read
[INFO] [stderr]   --> src/parse/mod.rs:70:24
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Ok(v) => { arg3 = Some(v); },
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/parse/address.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     let non_decimal_radix: Option<u32>;
[INFO] [stderr] 63 | |     if item.len() < 2 {
[INFO] [stderr] 64 | |         non_decimal_radix = None;
[INFO] [stderr] 65 | |     } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         };
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let non_decimal_radix = if item.len() < 2 { None } else { match &item[0..2] {
[INFO] [stderr] 63 |             "0x" => Some(16),
[INFO] [stderr] 64 |             "0b" => Some(2),
[INFO] [stderr] 65 |             _ => None,
[INFO] [stderr] 66 |         } };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parse/mod.rs:31:8
[INFO] [stderr]    |
[INFO] [stderr] 31 |     if pieces.len() == 0 { return Ok(None); }
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pieces.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/parse/mod.rs:38:8
[INFO] [stderr]    |
[INFO] [stderr] 38 |     if pieces.len() >= 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pieces.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/parse/mod.rs:169:40
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 errors.push((n as u64, format!("{}", e)));
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parse/mod.rs:173:8
[INFO] [stderr]     |
[INFO] [stderr] 173 |     if errors.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unused comparison that must be used
[INFO] [stderr]   --> src/lex.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 state == LexState::Done;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/lex.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 state == LexState::Done;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lex.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if v.len() == 0 { v.push(new_token); }
[INFO] [stderr]    |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:59:29
[INFO] [stderr]    |
[INFO] [stderr] 59 | pub fn program_to_writer(p: &Program, mut w: &mut Write) -> Result<(), serde_cbor::Error> {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.66s
[INFO] running `"docker" "inspect" "22d374af0491cdf84e1f73ebc3ca01601c05b3cafa28f7ab854951b59d413409"`
[INFO] running `"docker" "rm" "-f" "22d374af0491cdf84e1f73ebc3ca01601c05b3cafa28f7ab854951b59d413409"`
[INFO] [stdout] 22d374af0491cdf84e1f73ebc3ca01601c05b3cafa28f7ab854951b59d413409