[INFO] crate mlcr 0.2.0 is already in cache [INFO] extracting crate mlcr 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/mlcr/0.2.0 [INFO] extracting crate mlcr 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mlcr/0.2.0 [INFO] validating manifest of mlcr-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mlcr-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mlcr-0.2.0 [INFO] finished frobbing mlcr-0.2.0 [INFO] frobbed toml for mlcr-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/mlcr/0.2.0/Cargo.toml [INFO] started frobbing mlcr-0.2.0 [INFO] finished frobbing mlcr-0.2.0 [INFO] frobbed toml for mlcr-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mlcr/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mlcr-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mlcr/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 456cf66c4ce761315c0d78f8a99345ac93d13d63713ca733d82bcc6eb1529cfc [INFO] running `"docker" "start" "-a" "456cf66c4ce761315c0d78f8a99345ac93d13d63713ca733d82bcc6eb1529cfc"` [INFO] [stderr] Checking nn v0.1.6 [INFO] [stderr] Checking mlcr v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | prediction: prediction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prediction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | heap: heap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `heap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | prediction: prediction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prediction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | heap: heap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `heap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | vec![id as f64, self.instated as f64, self.last_used[0] as f64, self.last_used[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.instated)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | vec![id as f64, self.instated as f64, self.last_used[0] as f64, self.last_used[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.last_used[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:53:73 [INFO] [stderr] | [INFO] [stderr] 53 | vec![id as f64, self.instated as f64, self.last_used[0] as f64, self.last_used[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.last_used[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | self.times_used as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.times_used)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cache` [INFO] [stderr] --> src/lib.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new() -> Cache { [INFO] [stderr] 145 | | Cache { [INFO] [stderr] 146 | | blocks: HashMap::new(), [INFO] [stderr] 147 | | nn: NN::new(&[5, 6, 1]), [INFO] [stderr] 148 | | clock: 0, [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | impl Default for Cache { [INFO] [stderr] 138 | fn default() -> Self { [INFO] [stderr] 139 | Self::new() [INFO] [stderr] 140 | } [INFO] [stderr] 141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | let goal = (self.clock as f64 * 0.01).tanh(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.clock)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ConcurrentCache` [INFO] [stderr] --> src/lib.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / pub fn new() -> ConcurrentCache { [INFO] [stderr] 250 | | ConcurrentCache { [INFO] [stderr] 251 | | inner: Mutex::new(Cache::new()), [INFO] [stderr] 252 | | queue: SegQueue::new(), [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | impl Default for ConcurrentCache { [INFO] [stderr] 248 | fn default() -> Self { [INFO] [stderr] 249 | Self::new() [INFO] [stderr] 250 | } [INFO] [stderr] 251 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | vec![id as f64, self.instated as f64, self.last_used[0] as f64, self.last_used[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.instated)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | vec![id as f64, self.instated as f64, self.last_used[0] as f64, self.last_used[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.last_used[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:53:73 [INFO] [stderr] | [INFO] [stderr] 53 | vec![id as f64, self.instated as f64, self.last_used[0] as f64, self.last_used[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.last_used[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | self.times_used as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.times_used)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cache` [INFO] [stderr] --> src/lib.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new() -> Cache { [INFO] [stderr] 145 | | Cache { [INFO] [stderr] 146 | | blocks: HashMap::new(), [INFO] [stderr] 147 | | nn: NN::new(&[5, 6, 1]), [INFO] [stderr] 148 | | clock: 0, [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | impl Default for Cache { [INFO] [stderr] 138 | fn default() -> Self { [INFO] [stderr] 139 | Self::new() [INFO] [stderr] 140 | } [INFO] [stderr] 141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | let goal = (self.clock as f64 * 0.01).tanh(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.clock)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ConcurrentCache` [INFO] [stderr] --> src/lib.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / pub fn new() -> ConcurrentCache { [INFO] [stderr] 250 | | ConcurrentCache { [INFO] [stderr] 251 | | inner: Mutex::new(Cache::new()), [INFO] [stderr] 252 | | queue: SegQueue::new(), [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | impl Default for ConcurrentCache { [INFO] [stderr] 248 | fn default() -> Self { [INFO] [stderr] 249 | Self::new() [INFO] [stderr] 250 | } [INFO] [stderr] 251 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.39s [INFO] running `"docker" "inspect" "456cf66c4ce761315c0d78f8a99345ac93d13d63713ca733d82bcc6eb1529cfc"` [INFO] running `"docker" "rm" "-f" "456cf66c4ce761315c0d78f8a99345ac93d13d63713ca733d82bcc6eb1529cfc"` [INFO] [stdout] 456cf66c4ce761315c0d78f8a99345ac93d13d63713ca733d82bcc6eb1529cfc