[INFO] crate mlc 0.1.1 is already in cache [INFO] extracting crate mlc 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mlc/0.1.1 [INFO] extracting crate mlc 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mlc/0.1.1 [INFO] validating manifest of mlc-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mlc-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mlc-0.1.1 [INFO] finished frobbing mlc-0.1.1 [INFO] frobbed toml for mlc-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mlc/0.1.1/Cargo.toml [INFO] started frobbing mlc-0.1.1 [INFO] finished frobbing mlc-0.1.1 [INFO] frobbed toml for mlc-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mlc/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mlc-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mlc/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71393f291e0b775b72b01093a4ec407c53107930631ddfcf37c0e1e3d4ed2c01 [INFO] running `"docker" "start" "-a" "71393f291e0b775b72b01093a4ec407c53107930631ddfcf37c0e1e3d4ed2c01"` [INFO] [stderr] Checking mlc v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return dest; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `dest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return dest; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:37:41 [INFO] [stderr] | [INFO] [stderr] 37 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | *s.offset(i as isize) = c as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `s.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let a = *s1.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `s1.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | let b = *s2.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `s2.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | return a as i32 - b as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | return a as i32 - b as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return dest; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `dest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return dest; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:37:41 [INFO] [stderr] | [INFO] [stderr] 37 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | *dest.offset(i as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | *s.offset(i as isize) = c as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `s.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let a = *s1.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `s1.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | let b = *s2.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `s2.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | return a as i32 - b as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | return a as i32 - b as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "71393f291e0b775b72b01093a4ec407c53107930631ddfcf37c0e1e3d4ed2c01"` [INFO] running `"docker" "rm" "-f" "71393f291e0b775b72b01093a4ec407c53107930631ddfcf37c0e1e3d4ed2c01"` [INFO] [stdout] 71393f291e0b775b72b01093a4ec407c53107930631ddfcf37c0e1e3d4ed2c01