[INFO] crate mksvg 0.1.1 is already in cache [INFO] extracting crate mksvg 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mksvg/0.1.1 [INFO] extracting crate mksvg 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mksvg/0.1.1 [INFO] validating manifest of mksvg-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mksvg-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mksvg-0.1.1 [INFO] finished frobbing mksvg-0.1.1 [INFO] frobbed toml for mksvg-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mksvg/0.1.1/Cargo.toml [INFO] started frobbing mksvg-0.1.1 [INFO] finished frobbing mksvg-0.1.1 [INFO] frobbed toml for mksvg-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mksvg/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mksvg-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mksvg/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d89e94f2457f080de49f8e07ac2860706576924de3298129c0e29dc532897ed [INFO] running `"docker" "start" "-a" "9d89e94f2457f080de49f8e07ac2860706576924de3298129c0e29dc532897ed"` [INFO] [stderr] Checking mksvg v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | w:w, [INFO] [stderr] | ^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/write.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | write!(self.w,"{}{}\n",ps,s).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | w:w, [INFO] [stderr] | ^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/write.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | write!(self.w,"{}{}\n",ps,s).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/page.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | print!("Creating : {}\n",pps); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/page.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | print!("Combining\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | w:w, [INFO] [stderr] | ^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/write.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | write!(self.w,"{}{}\n",ps,s).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | w:w, [INFO] [stderr] | ^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/write.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | write!(self.w,"{}{}\n",ps,s).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/page.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | print!("Creating : {}\n",pps); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/page.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | print!("Combining\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/path.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_lowercase': use inherent methods instead [INFO] [stderr] --> src/path.rs:70:44 [INFO] [stderr] | [INFO] [stderr] 70 | true=>self.items.push(PNode{tp:AsciiExt::to_ascii_lowercase(&tp),vals:vals.to_string()}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_uppercase': use inherent methods instead [INFO] [stderr] --> src/path.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | false=>self.items.push(PNode{tp:AsciiExt::to_ascii_uppercase(&tp),vals:vals.to_string()}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/path.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_lowercase': use inherent methods instead [INFO] [stderr] --> src/path.rs:70:44 [INFO] [stderr] | [INFO] [stderr] 70 | true=>self.items.push(PNode{tp:AsciiExt::to_ascii_lowercase(&tp),vals:vals.to_string()}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_uppercase': use inherent methods instead [INFO] [stderr] --> src/path.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | false=>self.items.push(PNode{tp:AsciiExt::to_ascii_uppercase(&tp),vals:vals.to_string()}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `args::Args` [INFO] [stderr] --> src/args.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new()->Args{ [INFO] [stderr] 60 | | Args{ [INFO] [stderr] 61 | | items:Vec::new(), [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/args.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if sstr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sstr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/args.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if tstr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tstr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/write.rs:162:28 [INFO] [stderr] | [INFO] [stderr] 162 | let lns = tx.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/write.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / fn bg_text(&mut self,tx:&str,x:T,y:T,fs:T,sw:T,scol:&str,args:Args){ [INFO] [stderr] 174 | | self.text(tx,x,y,fs,args.clone().stroke_width(sw).stroke(scol)); [INFO] [stderr] 175 | | self.text(tx,x,y,fs,args.stroke("none")); [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/write.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / fn bg_text(&mut self,tx:&str,x:T,y:T,fs:T,sw:T,scol:&str,args:Args){ [INFO] [stderr] 174 | | self.text(tx,x,y,fs,args.clone().stroke_width(sw).stroke(scol)); [INFO] [stderr] 175 | | self.text(tx,x,y,fs,args.stroke("none")); [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/write.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | / fn bg_text_lines(&mut self,tx:&str,x:T,y:T,fs:T,dy:T,sw:T,scol:&str,args:Args){ [INFO] [stderr] 180 | | let p = args.font_size(fs); [INFO] [stderr] 181 | | self.text_lines(tx,x,y,fs,dy,p.clone().stroke_width(sw).stroke(scol)); [INFO] [stderr] 182 | | self.text_lines(tx,x,y,fs,dy,p.stroke("none")); [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if cards.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cards.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/page.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | for i in 0 .. ((cards.len()-1) /total) +1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=((cards.len()-1) /total)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/page.rs:57:53 [INFO] [stderr] | [INFO] [stderr] 57 | let mut path = PathBuf::from(cpath.parent().unwrap_or(Path::new(""))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/page.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn page_flip(v:&Vec,w:usize)->Vec{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:106:8 [INFO] [stderr] | [INFO] [stderr] 106 | if tmp.len() > 0{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tmp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/text.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if cline.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cline.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/path.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self.rel { [INFO] [stderr] 70 | | true=>self.items.push(PNode{tp:AsciiExt::to_ascii_lowercase(&tp),vals:vals.to_string()}), [INFO] [stderr] 71 | | false=>self.items.push(PNode{tp:AsciiExt::to_ascii_uppercase(&tp),vals:vals.to_string()}), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.rel { self.items.push(PNode{tp:AsciiExt::to_ascii_lowercase(&tp),vals:vals.to_string()}) } else { self.items.push(PNode{tp:AsciiExt::to_ascii_uppercase(&tp),vals:vals.to_string()}) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `args::Args` [INFO] [stderr] --> src/args.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new()->Args{ [INFO] [stderr] 60 | | Args{ [INFO] [stderr] 61 | | items:Vec::new(), [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/args.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if sstr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sstr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/args.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if tstr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tstr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/write.rs:162:28 [INFO] [stderr] | [INFO] [stderr] 162 | let lns = tx.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/write.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / fn bg_text(&mut self,tx:&str,x:T,y:T,fs:T,sw:T,scol:&str,args:Args){ [INFO] [stderr] 174 | | self.text(tx,x,y,fs,args.clone().stroke_width(sw).stroke(scol)); [INFO] [stderr] 175 | | self.text(tx,x,y,fs,args.stroke("none")); [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/write.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / fn bg_text(&mut self,tx:&str,x:T,y:T,fs:T,sw:T,scol:&str,args:Args){ [INFO] [stderr] 174 | | self.text(tx,x,y,fs,args.clone().stroke_width(sw).stroke(scol)); [INFO] [stderr] 175 | | self.text(tx,x,y,fs,args.stroke("none")); [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/write.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | / fn bg_text_lines(&mut self,tx:&str,x:T,y:T,fs:T,dy:T,sw:T,scol:&str,args:Args){ [INFO] [stderr] 180 | | let p = args.font_size(fs); [INFO] [stderr] 181 | | self.text_lines(tx,x,y,fs,dy,p.clone().stroke_width(sw).stroke(scol)); [INFO] [stderr] 182 | | self.text_lines(tx,x,y,fs,dy,p.stroke("none")); [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if cards.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cards.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/page.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | for i in 0 .. ((cards.len()-1) /total) +1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=((cards.len()-1) /total)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/page.rs:57:53 [INFO] [stderr] | [INFO] [stderr] 57 | let mut path = PathBuf::from(cpath.parent().unwrap_or(Path::new(""))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/page.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn page_flip(v:&Vec,w:usize)->Vec{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:106:8 [INFO] [stderr] | [INFO] [stderr] 106 | if tmp.len() > 0{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tmp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/text.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if cline.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cline.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/path.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self.rel { [INFO] [stderr] 70 | | true=>self.items.push(PNode{tp:AsciiExt::to_ascii_lowercase(&tp),vals:vals.to_string()}), [INFO] [stderr] 71 | | false=>self.items.push(PNode{tp:AsciiExt::to_ascii_uppercase(&tp),vals:vals.to_string()}), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.rel { self.items.push(PNode{tp:AsciiExt::to_ascii_lowercase(&tp),vals:vals.to_string()}) } else { self.items.push(PNode{tp:AsciiExt::to_ascii_uppercase(&tp),vals:vals.to_string()}) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "9d89e94f2457f080de49f8e07ac2860706576924de3298129c0e29dc532897ed"` [INFO] running `"docker" "rm" "-f" "9d89e94f2457f080de49f8e07ac2860706576924de3298129c0e29dc532897ed"` [INFO] [stdout] 9d89e94f2457f080de49f8e07ac2860706576924de3298129c0e29dc532897ed