[INFO] crate mio-uds 0.6.7 is already in cache [INFO] extracting crate mio-uds 0.6.7 into work/ex/clippy-test-run/sources/stable/reg/mio-uds/0.6.7 [INFO] extracting crate mio-uds 0.6.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mio-uds/0.6.7 [INFO] validating manifest of mio-uds-0.6.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mio-uds-0.6.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mio-uds-0.6.7 [INFO] finished frobbing mio-uds-0.6.7 [INFO] frobbed toml for mio-uds-0.6.7 written to work/ex/clippy-test-run/sources/stable/reg/mio-uds/0.6.7/Cargo.toml [INFO] started frobbing mio-uds-0.6.7 [INFO] finished frobbing mio-uds-0.6.7 [INFO] frobbed toml for mio-uds-0.6.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mio-uds/0.6.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mio-uds-0.6.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mio-uds/0.6.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 760f98b9dc94b705147a0905288cf9947c4e427c00e6cd0848469a31d130dc7a [INFO] running `"docker" "start" "-a" "760f98b9dc94b705147a0905288cf9947c4e427c00e6cd0848469a31d130dc7a"` [INFO] [stderr] Checking mio-uds v0.6.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/socket.rs:38:50 [INFO] [stderr] --> src/socket.rs:38:50 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 38 | Ok(fd) => return Ok(Socket { fd: fd }), [INFO] [stderr] 38 | Ok(fd) => return Ok(Socket { fd: fd }), [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | msgs: msgs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `msgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(events.get(0).unwrap().readiness(), Ready::writable()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(events.get(1).unwrap().readiness(), Ready::writable()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | assert!(events.get(0).unwrap().readiness().is_readable()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(events.get(0).unwrap().token(), Token(2)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(events.get(0).unwrap().readiness(), Ready::writable()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(events.get(1).unwrap().readiness(), Ready::writable()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | assert!(events.get(0).unwrap().readiness().is_readable()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/smoke.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | assert_eq!(events.get(0).unwrap().token(), Token(2)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::len': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/echo.rs:271:28 [INFO] [stderr] | [INFO] [stderr] 271 | for i in 0..events.len() { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> tests/echo.rs:272:32 [INFO] [stderr] | [INFO] [stderr] 272 | let event = events.get(i).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/echo.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / fn conn<'a>(&'a mut self, tok: Token) -> &'a mut EchoConn { [INFO] [stderr] 112 | | self.conns[usize::from(tok) - 2].as_mut().unwrap() [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/echo.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | if self.rx.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.rx.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/smoke.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | let (mut first, mut last) = recv.split_at_mut(6); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/smoke.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | let (mut first, mut last) = recv.split_at_mut(6); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.83s [INFO] running `"docker" "inspect" "760f98b9dc94b705147a0905288cf9947c4e427c00e6cd0848469a31d130dc7a"` [INFO] running `"docker" "rm" "-f" "760f98b9dc94b705147a0905288cf9947c4e427c00e6cd0848469a31d130dc7a"` [INFO] [stdout] 760f98b9dc94b705147a0905288cf9947c4e427c00e6cd0848469a31d130dc7a