[INFO] crate mio-st 0.2.0 is already in cache [INFO] extracting crate mio-st 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/mio-st/0.2.0 [INFO] extracting crate mio-st 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mio-st/0.2.0 [INFO] validating manifest of mio-st-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mio-st-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mio-st-0.2.0 [INFO] finished frobbing mio-st-0.2.0 [INFO] frobbed toml for mio-st-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/mio-st/0.2.0/Cargo.toml [INFO] started frobbing mio-st-0.2.0 [INFO] finished frobbing mio-st-0.2.0 [INFO] frobbed toml for mio-st-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mio-st/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mio-st-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mio-st/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c49a8372d00c47cea7c1d6ea7b0f327be8869c021a1231686ccb39964849282 [INFO] running `"docker" "start" "-a" "7c49a8372d00c47cea7c1d6ea7b0f327be8869c021a1231686ccb39964849282"` [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking mio-st v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/epoll.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | .saturating_add((duration.subsec_nanos() as u64 / NANOS_PER_MILLI) + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/event/ready.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | const READABLE: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/poll/interests.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | const READABLE: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/epoll.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | .saturating_add((duration.subsec_nanos() as u64 / NANOS_PER_MILLI) + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!((&mut events).len(), 0); // ExactSizeIterator implementation. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!((&mut events).len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:197:20 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!((&mut events).len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:215:20 [INFO] [stderr] | [INFO] [stderr] 215 | assert_eq!((&mut events).len(), 4); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:229:20 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!((&mut events).len(), EVENTS_CAP); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:257:20 [INFO] [stderr] | [INFO] [stderr] 257 | assert_eq!((&mut events).len(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:270:20 [INFO] [stderr] | [INFO] [stderr] 270 | assert_eq!((&mut events).len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/event/events.rs:283:20 [INFO] [stderr] | [INFO] [stderr] 283 | assert_eq!((&mut events).len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event/id.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(id, id.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event/id.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(id, id.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/event/ready.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | const READABLE: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/event/ready.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | / fn is_tests() { [INFO] [stderr] 160 | | assert!(!Ready::empty().is_readable()); [INFO] [stderr] 161 | | assert!(!Ready::empty().is_writable()); [INFO] [stderr] 162 | | assert!(!Ready::empty().is_error()); [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event/mod.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(event, event.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/poll/interests.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | const READABLE: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.57s [INFO] running `"docker" "inspect" "7c49a8372d00c47cea7c1d6ea7b0f327be8869c021a1231686ccb39964849282"` [INFO] running `"docker" "rm" "-f" "7c49a8372d00c47cea7c1d6ea7b0f327be8869c021a1231686ccb39964849282"` [INFO] [stdout] 7c49a8372d00c47cea7c1d6ea7b0f327be8869c021a1231686ccb39964849282