[INFO] crate mio-child-process 0.2.1 is already in cache [INFO] extracting crate mio-child-process 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/mio-child-process/0.2.1 [INFO] extracting crate mio-child-process 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mio-child-process/0.2.1 [INFO] validating manifest of mio-child-process-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mio-child-process-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mio-child-process-0.2.1 [INFO] finished frobbing mio-child-process-0.2.1 [INFO] frobbed toml for mio-child-process-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/mio-child-process/0.2.1/Cargo.toml [INFO] started frobbing mio-child-process-0.2.1 [INFO] finished frobbing mio-child-process-0.2.1 [INFO] frobbed toml for mio-child-process-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mio-child-process/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mio-child-process-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mio-child-process/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e690bca87f298f1e080aa6c67b132eecceb6d7e5ddca935ba42a859f3a8d0b00 [INFO] running `"docker" "start" "-a" "e690bca87f298f1e080aa6c67b132eecceb6d7e5ddca935ba42a859f3a8d0b00"` [INFO] [stderr] Checking mio-child-process v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / if !result.stdout.is_empty() { [INFO] [stderr] 129 | | if SendResult::Abort [INFO] [stderr] 130 | | == try_send_buffer(&result.stdout, StdioChannel::Stdout, &sender) [INFO] [stderr] 131 | | { [INFO] [stderr] 132 | | return; [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if !result.stdout.is_empty() && SendResult::Abort [INFO] [stderr] 129 | == try_send_buffer(&result.stdout, StdioChannel::Stdout, &sender) { [INFO] [stderr] 130 | return; [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / if !result.stderr.is_empty() { [INFO] [stderr] 136 | | if SendResult::Abort [INFO] [stderr] 137 | | == try_send_buffer(&result.stderr, StdioChannel::Stderr, &sender) [INFO] [stderr] 138 | | { [INFO] [stderr] 139 | | return; [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | if !result.stderr.is_empty() && SendResult::Abort [INFO] [stderr] 136 | == try_send_buffer(&result.stderr, StdioChannel::Stderr, &sender) { [INFO] [stderr] 137 | return; [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / if !result.stdout.is_empty() { [INFO] [stderr] 129 | | if SendResult::Abort [INFO] [stderr] 130 | | == try_send_buffer(&result.stdout, StdioChannel::Stdout, &sender) [INFO] [stderr] 131 | | { [INFO] [stderr] 132 | | return; [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if !result.stdout.is_empty() && SendResult::Abort [INFO] [stderr] 129 | == try_send_buffer(&result.stdout, StdioChannel::Stdout, &sender) { [INFO] [stderr] 130 | return; [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / if !result.stderr.is_empty() { [INFO] [stderr] 136 | | if SendResult::Abort [INFO] [stderr] 137 | | == try_send_buffer(&result.stderr, StdioChannel::Stderr, &sender) [INFO] [stderr] 138 | | { [INFO] [stderr] 139 | | return; [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | if !result.stderr.is_empty() && SendResult::Abort [INFO] [stderr] 136 | == try_send_buffer(&result.stderr, StdioChannel::Stderr, &sender) { [INFO] [stderr] 137 | return; [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:312:12 [INFO] [stderr] | [INFO] [stderr] 312 | if let Err(_) = sender.send(ProcessEvent::Data(channel, String::from(str))) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 313 | | SendResult::Abort [INFO] [stderr] 314 | | } else { [INFO] [stderr] 315 | | SendResult::Ok [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____- help: try this: `if sender.send(ProcessEvent::Data(channel, String::from(str))).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:312:12 [INFO] [stderr] | [INFO] [stderr] 312 | if let Err(_) = sender.send(ProcessEvent::Data(channel, String::from(str))) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 313 | | SendResult::Abort [INFO] [stderr] 314 | | } else { [INFO] [stderr] 315 | | SendResult::Ok [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____- help: try this: `if sender.send(ProcessEvent::Data(channel, String::from(str))).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "e690bca87f298f1e080aa6c67b132eecceb6d7e5ddca935ba42a859f3a8d0b00"` [INFO] running `"docker" "rm" "-f" "e690bca87f298f1e080aa6c67b132eecceb6d7e5ddca935ba42a859f3a8d0b00"` [INFO] [stdout] e690bca87f298f1e080aa6c67b132eecceb6d7e5ddca935ba42a859f3a8d0b00