[INFO] crate minisat 0.4.0 is already in cache
[INFO] extracting crate minisat 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/minisat/0.4.0
[INFO] extracting crate minisat 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minisat/0.4.0
[INFO] validating manifest of minisat-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of minisat-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing minisat-0.4.0
[INFO] finished frobbing minisat-0.4.0
[INFO] frobbed toml for minisat-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/minisat/0.4.0/Cargo.toml
[INFO] started frobbing minisat-0.4.0
[INFO] finished frobbing minisat-0.4.0
[INFO] frobbed toml for minisat-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minisat/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting minisat-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/minisat/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2276f2f1ff57a009849dd8f8113cafae1dd52700b87901235b5c0e00d945b4b4
[INFO] running `"docker" "start" "-a" "2276f2f1ff57a009849dd8f8113cafae1dd52700b87901235b5c0e00d945b4b4"`
[INFO] [stderr]     Checking quickcheck v0.7.2
[INFO] [stderr]    Compiling minisat v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/core/Solver.cc:26:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:995:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("restarts              : %"PRIu64"\n", starts);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:996:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("conflicts             : %-12"PRIu64"   (%.0f /sec)\n", conflicts   , conflicts   /cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:997:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("decisions             : %-12"PRIu64"   (%4.2f %% random) (%.0f /sec)\n", decisions, (float)rnd_decisions*100 / (float)decisions, decisions   /cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:998:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("propagations          : %-12"PRIu64"   (%.0f /sec)\n", propagations, propagations/cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:999:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("conflict literals     : %-12"PRIu64"   (%4.2f %% deleted)\n", tot_literals, (max_literals - tot_literals)*100 / (double)max_literals);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.h:25,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.cc:22:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.h:25,
[INFO] [stderr] warning:                  from lib/minisat-c-bindings/minisat.cc:22:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/model_ord.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |             let w = B::new_less_lit(solver, inclusive, p, q);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/binary.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 xs.push(Item { bit: bit, val: v });
[INFO] [stderr]    |                                ^^^^^^^^ help: replace it with: `bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/model_ord.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |             let w = B::new_less_lit(solver, inclusive, p, q);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/binary.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 xs.push(Item { bit: bit, val: v });
[INFO] [stderr]    |                                ^^^^^^^^ help: replace it with: `bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/model_ord.rs:91:16
[INFO] [stderr]    |
[INFO] [stderr] 91 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 92 | |             if !inclusive {
[INFO] [stderr] 93 | |                 solver.add_clause(prefix);
[INFO] [stderr] 94 | |             }
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 91 |         } else if !inclusive {
[INFO] [stderr] 92 |     solver.add_clause(prefix);
[INFO] [stderr] 93 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/binary.rs:67:28
[INFO] [stderr]    |
[INFO] [stderr] 67 |                 let Item { bit: _,   val: b_val } = xs.remove(0);
[INFO] [stderr]    |                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `Item { val: b_val, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/binary.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 let Item { bit: _,   val: c_val } = xs.remove(0);
[INFO] [stderr]    |                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Item { val: c_val, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/binary.rs:76:28
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 let Item { bit: _,   val: b_val } = xs.remove(0);
[INFO] [stderr]    |                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Item { val: b_val, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/model_ord.rs:20:68
[INFO] [stderr]    |
[INFO] [stderr] 20 |             Bool::Const(c) => Self::assert_less_or(solver, prefix, c.into(), x, y),
[INFO] [stderr]    |                                                                    ^^^^^^^^ help: consider removing `.into()`: `c`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             b.clone()
[INFO] [stderr]    |             ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:65:49
[INFO] [stderr]    |
[INFO] [stderr] 65 |             if inclusive { true.into() } else { b.clone() }
[INFO] [stderr]    |                                                 ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:67:28
[INFO] [stderr]    |
[INFO] [stderr] 67 |             if inclusive { b.clone() } else { false.into() }
[INFO] [stderr]    |                            ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:69:29
[INFO] [stderr]    |
[INFO] [stderr] 69 |             if inclusive { !(a.clone()) } else { false.into() }
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:71:50
[INFO] [stderr]    |
[INFO] [stderr] 71 |             if inclusive { true.into() } else { !(a.clone()) }
[INFO] [stderr]    |                                                  ^^^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if a.len() > 0 && b.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!a.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:85:27
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if a.len() > 0 && b.len() > 0 {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!b.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:87:19
[INFO] [stderr]    |
[INFO] [stderr] 87 |         } else if a.len() > 0 {
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!a.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:89:19
[INFO] [stderr]    |
[INFO] [stderr] 89 |         } else if b.len() > 0 {
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!b.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/unary.rs:30:41
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let lits = lits.into_iter().map(|x| Unary::from_bool(x)).collect();
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Unary::from_bool`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/unary.rs:42:12
[INFO] [stderr]    |
[INFO] [stderr] 42 |         if self.0.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/unary.rs:127:12
[INFO] [stderr]     |
[INFO] [stderr] 127 |         if a.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `a.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/unary.rs:130:19
[INFO] [stderr]     |
[INFO] [stderr] 130 |         } else if b.len() == 0 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/unary.rs:171:12
[INFO] [stderr]     |
[INFO] [stderr] 171 |         if xs.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/unary.rs:241:14
[INFO] [stderr]     |
[INFO] [stderr] 241 |             .unwrap_or(self.0.len())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.0.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/binary.rs:61:15
[INFO] [stderr]    |
[INFO] [stderr] 61 |         while xs.len() > 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!xs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/binary.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 i = i+1;
[INFO] [stderr]    |                 ^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/binary.rs:108:25
[INFO] [stderr]     |
[INFO] [stderr] 108 |         else if a == !b { c }
[INFO] [stderr]     |                         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/binary.rs:107:24
[INFO] [stderr]     |
[INFO] [stderr] 107 |         else if a == c { c }
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/binary.rs:188:42
[INFO] [stderr]     |
[INFO] [stderr] 188 |             let ai = a.0.get(i).cloned().unwrap_or(false.into());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| false.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/binary.rs:189:42
[INFO] [stderr]     |
[INFO] [stderr] 189 |             let bi = b.0.get(i).cloned().unwrap_or(false.into());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| false.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/symbolic.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 |         if xs.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/symbolic.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 | /             match (p,q,x) {
[INFO] [stderr] 61 | |                 (Some(p), Some(q), _) => solver.add_clause(
[INFO] [stderr] 62 | |                     once(!p).chain(once(!q)).chain(prefix.iter().cloned())),
[INFO] [stderr] 63 | |                 _ => {},
[INFO] [stderr] 64 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 60 |             if let (Some(p), Some(q), _) = (p,q,x) { solver.add_clause(
[INFO] [stderr] 61 | once(!p).chain(once(!q)).chain(prefix.iter().cloned())) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Solver`
[INFO] [stderr]    --> src/lib.rs:195:5
[INFO] [stderr]     |
[INFO] [stderr] 195 | /     pub fn new() -> Self {
[INFO] [stderr] 196 | |         let ptr = unsafe { minisat_new() };
[INFO] [stderr] 197 | |
[INFO] [stderr] 198 | |         // "normal solver"??? (cfr. haskell minisat-0.1.2 newSolver)
[INFO] [stderr] ...   |
[INFO] [stderr] 201 | |         Solver { ptr }
[INFO] [stderr] 202 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 193 | impl Default for Solver {
[INFO] [stderr] 194 |     fn default() -> Self {
[INFO] [stderr] 195 |         Self::new()
[INFO] [stderr] 196 |     }
[INFO] [stderr] 197 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:228:5
[INFO] [stderr]     |
[INFO] [stderr] 228 | /     pub fn solve<'a>(&'a mut self) -> Result<Model<'a>, ()> {
[INFO] [stderr] 229 | |         self.solve_under_assumptions(empty())
[INFO] [stderr] 230 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:240:5
[INFO] [stderr]     |
[INFO] [stderr] 240 | /     pub fn solve_under_assumptions<'a, I:IntoIterator<Item = Bool>>(&'a mut self, lits :I) -> Result<Model<'a>, ()> {
[INFO] [stderr] 241 | |         unsafe { minisat_solve_begin(self.ptr); }
[INFO] [stderr] 242 | |         for lit in lits {
[INFO] [stderr] 243 | |             match lit {
[INFO] [stderr] ...   |
[INFO] [stderr] 257 | |         }
[INFO] [stderr] 258 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:281:12
[INFO] [stderr]     |
[INFO] [stderr] 281 |         if lits.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lits.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:349:12
[INFO] [stderr]     |
[INFO] [stderr] 349 |         if xs.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:397:12
[INFO] [stderr]     |
[INFO] [stderr] 397 |         if out.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] The following warnings were emitted during compilation:
[INFO] [stderr] 
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/core/Solver.cc:26:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:995:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("restarts              : %"PRIu64"\n", starts);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:996:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("conflicts             : %-12"PRIu64"   (%.0f /sec)\n", conflicts   , conflicts   /cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:997:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("decisions             : %-12"PRIu64"   (%4.2f %% random) (%.0f /sec)\n", decisions, (float)rnd_decisions*100 / (float)decisions, decisions   /cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:998:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("propagations          : %-12"PRIu64"   (%.0f /sec)\n", propagations, propagations/cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:999:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("conflict literals     : %-12"PRIu64"   (%4.2f %% deleted)\n", tot_literals, (max_literals - tot_literals)*100 / (double)max_literals);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.h:25,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.cc:22:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.h:25,
[INFO] [stderr] warning:                  from lib/minisat-c-bindings/minisat.cc:22:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `minisat`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/model_ord.rs:91:16
[INFO] [stderr]    |
[INFO] [stderr] 91 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 92 | |             if !inclusive {
[INFO] [stderr] 93 | |                 solver.add_clause(prefix);
[INFO] [stderr] 94 | |             }
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 91 |         } else if !inclusive {
[INFO] [stderr] 92 |     solver.add_clause(prefix);
[INFO] [stderr] 93 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/binary.rs:67:28
[INFO] [stderr]    |
[INFO] [stderr] 67 |                 let Item { bit: _,   val: b_val } = xs.remove(0);
[INFO] [stderr]    |                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `Item { val: b_val, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/binary.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 let Item { bit: _,   val: c_val } = xs.remove(0);
[INFO] [stderr]    |                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Item { val: c_val, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/binary.rs:76:28
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 let Item { bit: _,   val: b_val } = xs.remove(0);
[INFO] [stderr]    |                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Item { val: b_val, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:731:39
[INFO] [stderr]     |
[INFO] [stderr] 731 |         let b = Binary::new(&mut sat, 123123123123);
[INFO] [stderr]     |                                       ^^^^^^^^^^^^ help: consider: `123_123_123_123`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:732:39
[INFO] [stderr]     |
[INFO] [stderr] 732 |         let c = Binary::new(&mut sat, 1231231231239);
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^ help: consider: `1_231_231_231_239`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/model_ord.rs:20:68
[INFO] [stderr]    |
[INFO] [stderr] 20 |             Bool::Const(c) => Self::assert_less_or(solver, prefix, c.into(), x, y),
[INFO] [stderr]    |                                                                    ^^^^^^^^ help: consider removing `.into()`: `c`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             b.clone()
[INFO] [stderr]    |             ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:65:49
[INFO] [stderr]    |
[INFO] [stderr] 65 |             if inclusive { true.into() } else { b.clone() }
[INFO] [stderr]    |                                                 ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:67:28
[INFO] [stderr]    |
[INFO] [stderr] 67 |             if inclusive { b.clone() } else { false.into() }
[INFO] [stderr]    |                            ^^^^^^^^^ help: try dereferencing it: `*b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:69:29
[INFO] [stderr]    |
[INFO] [stderr] 69 |             if inclusive { !(a.clone()) } else { false.into() }
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/model_ord.rs:71:50
[INFO] [stderr]    |
[INFO] [stderr] 71 |             if inclusive { true.into() } else { !(a.clone()) }
[INFO] [stderr]    |                                                  ^^^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if a.len() > 0 && b.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!a.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:85:27
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if a.len() > 0 && b.len() > 0 {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!b.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:87:19
[INFO] [stderr]    |
[INFO] [stderr] 87 |         } else if a.len() > 0 {
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!a.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model_ord.rs:89:19
[INFO] [stderr]    |
[INFO] [stderr] 89 |         } else if b.len() > 0 {
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!b.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/unary.rs:30:41
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let lits = lits.into_iter().map(|x| Unary::from_bool(x)).collect();
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Unary::from_bool`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/unary.rs:42:12
[INFO] [stderr]    |
[INFO] [stderr] 42 |         if self.0.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/unary.rs:127:12
[INFO] [stderr]     |
[INFO] [stderr] 127 |         if a.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `a.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/unary.rs:130:19
[INFO] [stderr]     |
[INFO] [stderr] 130 |         } else if b.len() == 0 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/unary.rs:171:12
[INFO] [stderr]     |
[INFO] [stderr] 171 |         if xs.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/unary.rs:241:14
[INFO] [stderr]     |
[INFO] [stderr] 241 |             .unwrap_or(self.0.len())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.0.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/binary.rs:61:15
[INFO] [stderr]    |
[INFO] [stderr] 61 |         while xs.len() > 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!xs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/binary.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 i = i+1;
[INFO] [stderr]    |                 ^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/binary.rs:108:25
[INFO] [stderr]     |
[INFO] [stderr] 108 |         else if a == !b { c }
[INFO] [stderr]     |                         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/binary.rs:107:24
[INFO] [stderr]     |
[INFO] [stderr] 107 |         else if a == c { c }
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/binary.rs:188:42
[INFO] [stderr]     |
[INFO] [stderr] 188 |             let ai = a.0.get(i).cloned().unwrap_or(false.into());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| false.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/binary.rs:189:42
[INFO] [stderr]     |
[INFO] [stderr] 189 |             let bi = b.0.get(i).cloned().unwrap_or(false.into());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| false.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/symbolic.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 |         if xs.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/symbolic.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 | /             match (p,q,x) {
[INFO] [stderr] 61 | |                 (Some(p), Some(q), _) => solver.add_clause(
[INFO] [stderr] 62 | |                     once(!p).chain(once(!q)).chain(prefix.iter().cloned())),
[INFO] [stderr] 63 | |                 _ => {},
[INFO] [stderr] 64 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 60 |             if let (Some(p), Some(q), _) = (p,q,x) { solver.add_clause(
[INFO] [stderr] 61 | once(!p).chain(once(!q)).chain(prefix.iter().cloned())) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Solver`
[INFO] [stderr]    --> src/lib.rs:195:5
[INFO] [stderr]     |
[INFO] [stderr] 195 | /     pub fn new() -> Self {
[INFO] [stderr] 196 | |         let ptr = unsafe { minisat_new() };
[INFO] [stderr] 197 | |
[INFO] [stderr] 198 | |         // "normal solver"??? (cfr. haskell minisat-0.1.2 newSolver)
[INFO] [stderr] ...   |
[INFO] [stderr] 201 | |         Solver { ptr }
[INFO] [stderr] 202 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 193 | impl Default for Solver {
[INFO] [stderr] 194 |     fn default() -> Self {
[INFO] [stderr] 195 |         Self::new()
[INFO] [stderr] 196 |     }
[INFO] [stderr] 197 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:228:5
[INFO] [stderr]     |
[INFO] [stderr] 228 | /     pub fn solve<'a>(&'a mut self) -> Result<Model<'a>, ()> {
[INFO] [stderr] 229 | |         self.solve_under_assumptions(empty())
[INFO] [stderr] 230 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:240:5
[INFO] [stderr]     |
[INFO] [stderr] 240 | /     pub fn solve_under_assumptions<'a, I:IntoIterator<Item = Bool>>(&'a mut self, lits :I) -> Result<Model<'a>, ()> {
[INFO] [stderr] 241 | |         unsafe { minisat_solve_begin(self.ptr); }
[INFO] [stderr] 242 | |         for lit in lits {
[INFO] [stderr] 243 | |             match lit {
[INFO] [stderr] ...   |
[INFO] [stderr] 257 | |         }
[INFO] [stderr] 258 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:281:12
[INFO] [stderr]     |
[INFO] [stderr] 281 |         if lits.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lits.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:349:12
[INFO] [stderr]     |
[INFO] [stderr] 349 |         if xs.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:397:12
[INFO] [stderr]     |
[INFO] [stderr] 397 |         if out.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/lib.rs:562:13
[INFO] [stderr]     |
[INFO] [stderr] 562 |             Err(_) => panic!(),
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `colors`
[INFO] [stderr]    --> src/lib.rs:669:26
[INFO] [stderr]     |
[INFO] [stderr] 669 |                 for i in 0..n_nodes {
[INFO] [stderr]     |                          ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 669 |                 for (i, <item>) in colors.iter().enumerate().take(n_nodes) {
[INFO] [stderr]     |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:798:16
[INFO] [stderr]     |
[INFO] [stderr] 798 |             if lits.len() == 0 { return true; }
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lits.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:849:13
[INFO] [stderr]     |
[INFO] [stderr] 849 | /             match sat.solve() {
[INFO] [stderr] 850 | |                 Err(()) => panic!(),
[INFO] [stderr] 851 | |                 _ => {},
[INFO] [stderr] 852 | |             };
[INFO] [stderr]     | |_____________^ help: try this: `if let Err(()) = sat.solve() { panic!() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] The following warnings were emitted during compilation:
[INFO] [stderr] 
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/core/Solver.cc:26:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:995:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("restarts              : %"PRIu64"\n", starts);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:996:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("conflicts             : %-12"PRIu64"   (%.0f /sec)\n", conflicts   , conflicts   /cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:997:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("decisions             : %-12"PRIu64"   (%4.2f %% random) (%.0f /sec)\n", decisions, (float)rnd_decisions*100 / (float)decisions, decisions   /cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:998:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("propagations          : %-12"PRIu64"   (%.0f /sec)\n", propagations, propagations/cpu_time);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: lib/minisat/minisat/core/Solver.cc:999:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:      printf("conflict literals     : %-12"PRIu64"   (%4.2f %% deleted)\n", tot_literals, (max_literals - tot_literals)*100 / (double)max_literals);
[INFO] [stderr] warning:             ^
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.h:25,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.cc:22:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] warning: In file included from lib/minisat/minisat/core/Solver.h:28:0,
[INFO] [stderr] warning:                  from lib/minisat/minisat/simp/SimpSolver.h:25,
[INFO] [stderr] warning:                  from lib/minisat-c-bindings/minisat.cc:22:
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:285:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.begin);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:291:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:              fprintf(stderr, "%4"PRIi64, range.end);
[INFO] [stderr] warning:                              ^
[INFO] [stderr] warning: lib/minisat/minisat/utils/Options.h:293:25: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
[INFO] [stderr] warning:          fprintf(stderr, "] (default: %"PRIi64")\n", value);
[INFO] [stderr] warning:                          ^
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `minisat`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "2276f2f1ff57a009849dd8f8113cafae1dd52700b87901235b5c0e00d945b4b4"`
[INFO] running `"docker" "rm" "-f" "2276f2f1ff57a009849dd8f8113cafae1dd52700b87901235b5c0e00d945b4b4"`
[INFO] [stdout] 2276f2f1ff57a009849dd8f8113cafae1dd52700b87901235b5c0e00d945b4b4