[INFO] crate minimp3 0.3.2 is already in cache [INFO] extracting crate minimp3 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/minimp3/0.3.2 [INFO] extracting crate minimp3 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minimp3/0.3.2 [INFO] validating manifest of minimp3-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of minimp3-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing minimp3-0.3.2 [INFO] finished frobbing minimp3-0.3.2 [INFO] frobbed toml for minimp3-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/minimp3/0.3.2/Cargo.toml [INFO] started frobbing minimp3-0.3.2 [INFO] finished frobbing minimp3-0.3.2 [INFO] frobbed toml for minimp3-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minimp3/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting minimp3-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/minimp3/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0546837b9b2e091551df2d4991fc47bec8da3fe56783a2f39405eb3af575b217 [INFO] running `"docker" "start" "-a" "0546837b9b2e091551df2d4991fc47bec8da3fe56783a2f39405eb3af575b217"` [INFO] [stderr] Compiling minimp3-sys v0.3.1 [INFO] [stderr] Checking slice-deque v0.1.16 [INFO] [stderr] Checking minimp3 v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / let mut bytes_read = None; [INFO] [stderr] 77 | | if self.buffer.len() < REFILL_TRIGGER { [INFO] [stderr] 78 | | bytes_read = Some(self.refill()?); [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let bytes_read = if self.buffer.len() < REFILL_TRIGGER { Some(self.refill()?) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / let mut bytes_read = None; [INFO] [stderr] 77 | | if self.buffer.len() < REFILL_TRIGGER { [INFO] [stderr] 78 | | bytes_read = Some(self.refill()?); [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let bytes_read = if self.buffer.len() < REFILL_TRIGGER { Some(self.refill()?) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sample_rate` [INFO] [stderr] --> examples/example.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Frame { data, sample_rate, channels, .. }) => { [INFO] [stderr] | ^^^^^^^^^^^ help: try ignoring the field: `sample_rate: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.26s [INFO] running `"docker" "inspect" "0546837b9b2e091551df2d4991fc47bec8da3fe56783a2f39405eb3af575b217"` [INFO] running `"docker" "rm" "-f" "0546837b9b2e091551df2d4991fc47bec8da3fe56783a2f39405eb3af575b217"` [INFO] [stdout] 0546837b9b2e091551df2d4991fc47bec8da3fe56783a2f39405eb3af575b217