[INFO] crate minimax 0.0.2 is already in cache [INFO] extracting crate minimax 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/minimax/0.0.2 [INFO] extracting crate minimax 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minimax/0.0.2 [INFO] validating manifest of minimax-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of minimax-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing minimax-0.0.2 [INFO] finished frobbing minimax-0.0.2 [INFO] frobbed toml for minimax-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/minimax/0.0.2/Cargo.toml [INFO] started frobbing minimax-0.0.2 [INFO] finished frobbing minimax-0.0.2 [INFO] frobbed toml for minimax-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minimax/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting minimax-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/minimax/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57fa9bb9e04033021d3fbb0b15f898b1231b5e32398029d7e138b86e2637af07 [INFO] running `"docker" "start" "-a" "57fa9bb9e04033021d3fbb0b15f898b1231b5e32398029d7e138b86e2637af07"` [INFO] [stderr] Checking minimax v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/strategies/negamax.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Negamax { opts: opts, rng: rand::thread_rng(), _eval: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/strategies/negamax.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Negamax { opts: opts, rng: rand::thread_rng(), _eval: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `apply` which has no body [INFO] [stderr] --> src/interface.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 95 | | fn apply(&self, &mut ::S); [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `undo` which has no body [INFO] [stderr] --> src/interface.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 98 | | fn undo(&self, &mut ::S); [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `generate_moves` which has no body [INFO] [stderr] --> src/interface.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 130 | | fn generate_moves(&Self::S, Player, &mut [Option]) -> usize; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `strategies::random::Random` [INFO] [stderr] --> src/strategies/random.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Random { [INFO] [stderr] 11 | | Random { [INFO] [stderr] 12 | | rng: rand::thread_rng() [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for strategies::random::Random { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `choose_move` doesn't need a mutable reference [INFO] [stderr] --> src/test.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | match strategy.choose_move(&mut state, p) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ttt.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match mw { [INFO] [stderr] 158 | | Some(interface::Winner::Competitor(wp)) => match wp { [INFO] [stderr] 159 | | interface::Player::Computer => return interface::Evaluation::Best, [INFO] [stderr] 160 | | interface::Player::Opponent => return interface::Evaluation::Worst, [INFO] [stderr] 161 | | }, [INFO] [stderr] 162 | | _ => {}, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Some(interface::Winner::Competitor(wp)) = mw { match wp { [INFO] [stderr] 158 | interface::Player::Computer => return interface::Evaluation::Best, [INFO] [stderr] 159 | interface::Player::Opponent => return interface::Evaluation::Worst, [INFO] [stderr] 160 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line` [INFO] [stderr] --> src/ttt.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | if b.squares[line + 0] == b.squares[line + 1] { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line` [INFO] [stderr] --> src/ttt.rs:170:30 [INFO] [stderr] | [INFO] [stderr] 170 | if b.squares[line + 0] == Square::X { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line` [INFO] [stderr] --> src/ttt.rs:172:37 [INFO] [stderr] | [INFO] [stderr] 172 | } else if b.squares[line + 0] == Square::O { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ttt.rs:179:60 [INFO] [stderr] | [INFO] [stderr] 179 | } else if b.squares[line + 1] == Square::O { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 180 | | score += 5; [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ttt.rs:177:53 [INFO] [stderr] | [INFO] [stderr] 177 | if b.squares[line + 1] == Square::X { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 178 | | score += 5; [INFO] [stderr] 179 | | } else if b.squares[line + 1] == Square::O { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `minimax`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: use of `#[inline]` on trait method `apply` which has no body [INFO] [stderr] --> src/interface.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 95 | | fn apply(&self, &mut ::S); [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `undo` which has no body [INFO] [stderr] --> src/interface.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 98 | | fn undo(&self, &mut ::S); [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `generate_moves` which has no body [INFO] [stderr] --> src/interface.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 130 | | fn generate_moves(&Self::S, Player, &mut [Option]) -> usize; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `strategies::random::Random` [INFO] [stderr] --> src/strategies/random.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Random { [INFO] [stderr] 11 | | Random { [INFO] [stderr] 12 | | rng: rand::thread_rng() [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for strategies::random::Random { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `choose_move` doesn't need a mutable reference [INFO] [stderr] --> src/test.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | match strategy.choose_move(&mut state, p) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ttt.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match mw { [INFO] [stderr] 158 | | Some(interface::Winner::Competitor(wp)) => match wp { [INFO] [stderr] 159 | | interface::Player::Computer => return interface::Evaluation::Best, [INFO] [stderr] 160 | | interface::Player::Opponent => return interface::Evaluation::Worst, [INFO] [stderr] 161 | | }, [INFO] [stderr] 162 | | _ => {}, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Some(interface::Winner::Competitor(wp)) = mw { match wp { [INFO] [stderr] 158 | interface::Player::Computer => return interface::Evaluation::Best, [INFO] [stderr] 159 | interface::Player::Opponent => return interface::Evaluation::Worst, [INFO] [stderr] 160 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line` [INFO] [stderr] --> src/ttt.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | if b.squares[line + 0] == b.squares[line + 1] { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line` [INFO] [stderr] --> src/ttt.rs:170:30 [INFO] [stderr] | [INFO] [stderr] 170 | if b.squares[line + 0] == Square::X { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line` [INFO] [stderr] --> src/ttt.rs:172:37 [INFO] [stderr] | [INFO] [stderr] 172 | } else if b.squares[line + 0] == Square::O { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ttt.rs:179:60 [INFO] [stderr] | [INFO] [stderr] 179 | } else if b.squares[line + 1] == Square::O { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 180 | | score += 5; [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ttt.rs:177:53 [INFO] [stderr] | [INFO] [stderr] 177 | if b.squares[line + 1] == Square::X { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 178 | | score += 5; [INFO] [stderr] 179 | | } else if b.squares[line + 1] == Square::O { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `minimax`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "57fa9bb9e04033021d3fbb0b15f898b1231b5e32398029d7e138b86e2637af07"` [INFO] running `"docker" "rm" "-f" "57fa9bb9e04033021d3fbb0b15f898b1231b5e32398029d7e138b86e2637af07"` [INFO] [stdout] 57fa9bb9e04033021d3fbb0b15f898b1231b5e32398029d7e138b86e2637af07