[INFO] crate minidump-processor 0.1.0 is already in cache [INFO] extracting crate minidump-processor 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/minidump-processor/0.1.0 [INFO] extracting crate minidump-processor 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minidump-processor/0.1.0 [INFO] validating manifest of minidump-processor-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of minidump-processor-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing minidump-processor-0.1.0 [INFO] finished frobbing minidump-processor-0.1.0 [INFO] frobbed toml for minidump-processor-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/minidump-processor/0.1.0/Cargo.toml [INFO] started frobbing minidump-processor-0.1.0 [INFO] finished frobbing minidump-processor-0.1.0 [INFO] frobbed toml for minidump-processor-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minidump-processor/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting minidump-processor-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/minidump-processor/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 510ef2ee3d4f76d7b0de0fa4f9b6abb510803eec39ec85834403b6756a22f24a [INFO] running `"docker" "start" "-a" "510ef2ee3d4f76d7b0de0fa4f9b6abb510803eec39ec85834403b6756a22f24a"` [INFO] [stderr] Checking test-assembler v0.1.5 [INFO] [stderr] Checking minidump-common v0.1.0 [INFO] [stderr] Checking range-map v0.1.5 [INFO] [stderr] Checking breakpad-symbols v0.1.1 [INFO] [stderr] Checking minidump v0.1.0 [INFO] [stderr] Checking minidump-processor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | process_create_time: process_create_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `process_create_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | crash_reason: crash_reason, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crash_reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | crash_address: crash_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crash_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | assertion: assertion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assertion` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | requesting_thread: requesting_thread, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `requesting_thread` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | system_info: system_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `system_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process_state.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | trust: trust, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trust` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process_state.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process_state.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stackwalker/mod.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | CallStack { frames: frames, info: info } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stackwalker/mod.rs:65:33 [INFO] [stderr] | [INFO] [stderr] 65 | CallStack { frames: frames, info: info } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | process_create_time: process_create_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `process_create_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | crash_reason: crash_reason, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crash_reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | crash_address: crash_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crash_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | assertion: assertion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assertion` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | requesting_thread: requesting_thread, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `requesting_thread` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | system_info: system_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `system_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process_state.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | trust: trust, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trust` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process_state.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process_state.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stackwalker/mod.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | CallStack { frames: frames, info: info } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stackwalker/mod.rs:65:33 [INFO] [stderr] | [INFO] [stderr] 65 | CallStack { frames: frames, info: info } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | MinidumpModule::new(0x40000000, 0x10000, "module1"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | MinidumpModule::new(0x50000000, 0x10000, "module2"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | stack.start().set_const(0x80000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | f.raw.eip = 0x40000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | f.raw.ebp = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | stack.start().set_const(0x80000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | .D32(0x40008679) // frame 0: return address [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_8679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | f.raw.eip = 0x4000c7a5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_c7a5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(f0.instruction, 0x4000c7a5); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_c7a5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stackwalker/x86_unittest.rs:104:36 [INFO] [stderr] | [INFO] [stderr] 104 | assert_eq!(f1.instruction, 0x40008678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_8678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/processor.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | exception_context.or(thread.context.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| thread.context.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processor.rs:121:29 [INFO] [stderr] | [INFO] [stderr] 121 | time: UTC.timestamp(dump.header.time_date_stamp as i64, 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dump.header.time_date_stamp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/process_state.rs:267:12 [INFO] [stderr] | [INFO] [stderr] 267 | if self.frames.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.frames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stackwalker/x86.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match valid { [INFO] [stderr] 14 | | &MinidumpContextValidity::All => {}, [INFO] [stderr] 15 | | &MinidumpContextValidity::Some(ref which) => { [INFO] [stderr] 16 | | if !which.contains("ebp") { [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *valid { [INFO] [stderr] 14 | MinidumpContextValidity::All => {}, [INFO] [stderr] 15 | MinidumpContextValidity::Some(ref which) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stackwalker/x86.rs:46:69 [INFO] [stderr] | [INFO] [stderr] 46 | Some(caller_ebp)) = (stack_memory.get_memory_at_address(last_ebp as u64 + 4), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(last_ebp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stackwalker/x86.rs:47:69 [INFO] [stderr] | [INFO] [stderr] 47 | stack_memory.get_memory_at_address(last_ebp as u64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(last_ebp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stackwalker/x86.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | frame.instruction = (caller_eip as u64) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(caller_eip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/stackwalker/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / if let &Some(module) = &modules.module_at_address(frame.instruction) { [INFO] [stderr] 38 | | // FIXME: this shouldn't need to clone, we should be able to use [INFO] [stderr] 39 | | // the same lifetime as the module list that's passed in. [INFO] [stderr] 40 | | frame.module = Some(module.clone()); [INFO] [stderr] 41 | | symbolizer.fill_symbol(module, frame); [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(module) = modules.module_at_address(frame.instruction) { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stackwalker/mod.rs:45:35 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn walk_stack(maybe_context : &Option<&MinidumpContext>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&MinidumpContext>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stackwalker/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / if let &Some(context) = maybe_context { [INFO] [stderr] 54 | | let ctx = context.clone(); [INFO] [stderr] 55 | | let mut maybe_frame = Some(StackFrame::from_context(ctx, FrameTrust::Context)); [INFO] [stderr] 56 | | while let Some(mut frame) = maybe_frame { [INFO] [stderr] ... | [INFO] [stderr] 63 | | info = CallStackInfo::MissingContext; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(context) = *maybe_context { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/processor.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | exception_context.or(thread.context.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| thread.context.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processor.rs:121:29 [INFO] [stderr] | [INFO] [stderr] 121 | time: UTC.timestamp(dump.header.time_date_stamp as i64, 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dump.header.time_date_stamp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/process_state.rs:267:12 [INFO] [stderr] | [INFO] [stderr] 267 | if self.frames.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.frames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stackwalker/x86.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match valid { [INFO] [stderr] 14 | | &MinidumpContextValidity::All => {}, [INFO] [stderr] 15 | | &MinidumpContextValidity::Some(ref which) => { [INFO] [stderr] 16 | | if !which.contains("ebp") { [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *valid { [INFO] [stderr] 14 | MinidumpContextValidity::All => {}, [INFO] [stderr] 15 | MinidumpContextValidity::Some(ref which) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stackwalker/x86.rs:46:69 [INFO] [stderr] | [INFO] [stderr] 46 | Some(caller_ebp)) = (stack_memory.get_memory_at_address(last_ebp as u64 + 4), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(last_ebp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stackwalker/x86.rs:47:69 [INFO] [stderr] | [INFO] [stderr] 47 | stack_memory.get_memory_at_address(last_ebp as u64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(last_ebp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stackwalker/x86.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | frame.instruction = (caller_eip as u64) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(caller_eip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/stackwalker/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / if let &Some(module) = &modules.module_at_address(frame.instruction) { [INFO] [stderr] 38 | | // FIXME: this shouldn't need to clone, we should be able to use [INFO] [stderr] 39 | | // the same lifetime as the module list that's passed in. [INFO] [stderr] 40 | | frame.module = Some(module.clone()); [INFO] [stderr] 41 | | symbolizer.fill_symbol(module, frame); [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(module) = modules.module_at_address(frame.instruction) { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stackwalker/mod.rs:45:35 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn walk_stack(maybe_context : &Option<&MinidumpContext>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&MinidumpContext>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stackwalker/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / if let &Some(context) = maybe_context { [INFO] [stderr] 54 | | let ctx = context.clone(); [INFO] [stderr] 55 | | let mut maybe_frame = Some(StackFrame::from_context(ctx, FrameTrust::Context)); [INFO] [stderr] 56 | | while let Some(mut frame) = maybe_frame { [INFO] [stderr] ... | [INFO] [stderr] 63 | | info = CallStackInfo::MissingContext; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(context) = *maybe_context { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_processor.rs:74:54 [INFO] [stderr] | [INFO] [stderr] 74 | assert_eq!(f0.context.get_instruction_pointer(), 0x0040429e); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_429e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_processor.rs:75:48 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(f0.context.get_stack_pointer(), 0x0012fe84); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0012_fe84` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_processor.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(raw.eip, 0x0040429e); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_429e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_processor.rs:89:54 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(f3.context.get_instruction_pointer(), 0x7c816fd7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7c81_6fd7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_processor.rs:90:48 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(f3.context.get_stack_pointer(), 0x0012ffc8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0012_ffc8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_processor.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(raw.eip, 0x7c816fd7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7c81_6fd7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> tests/test_processor.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(raw.eip, 0x0040429e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> tests/test_processor.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(raw.eip, 0x7c816fd7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> tests/test_processor.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | / fn test_processor() { [INFO] [stderr] 49 | | let mut dump = read_test_minidump().unwrap(); [INFO] [stderr] 50 | | let state = minidump_processor::process_minidump(&mut dump, [INFO] [stderr] 51 | | &Symbolizer::new( [INFO] [stderr] ... | [INFO] [stderr] 108 | | assert_eq!(state.threads[1].frames.len(), 0); [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/test_processor.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match valid { [INFO] [stderr] 95 | | &MinidumpContextValidity::All => assert!(false, "Should not have all registers valid"), [INFO] [stderr] 96 | | &MinidumpContextValidity::Some(ref which) => { [INFO] [stderr] 97 | | assert!(which.contains("eip")); [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | match *valid { [INFO] [stderr] 95 | MinidumpContextValidity::All => assert!(false, "Should not have all registers valid"), [INFO] [stderr] 96 | MinidumpContextValidity::Some(ref which) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/minidump_stackwalk.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | const USAGE : &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/minidump_stackwalk.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | const USAGE : &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.30s [INFO] running `"docker" "inspect" "510ef2ee3d4f76d7b0de0fa4f9b6abb510803eec39ec85834403b6756a22f24a"` [INFO] running `"docker" "rm" "-f" "510ef2ee3d4f76d7b0de0fa4f9b6abb510803eec39ec85834403b6756a22f24a"` [INFO] [stdout] 510ef2ee3d4f76d7b0de0fa4f9b6abb510803eec39ec85834403b6756a22f24a