[INFO] crate mini_http 0.0.3 is already in cache [INFO] extracting crate mini_http 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/mini_http/0.0.3 [INFO] extracting crate mini_http 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mini_http/0.0.3 [INFO] validating manifest of mini_http-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mini_http-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mini_http-0.0.3 [INFO] finished frobbing mini_http-0.0.3 [INFO] frobbed toml for mini_http-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/mini_http/0.0.3/Cargo.toml [INFO] started frobbing mini_http-0.0.3 [INFO] finished frobbing mini_http-0.0.3 [INFO] frobbed toml for mini_http-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mini_http/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mini_http-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mini_http/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 306ae80a971084a38f1c09e4545bb0cfffddf9ebe5bb366ee90896fe1e7c8b15 [INFO] running `"docker" "start" "-a" "306ae80a971084a38f1c09e4545bb0cfffddf9ebe5bb366ee90896fe1e7c8b15"` [INFO] [stderr] Checking mini_http v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | socket_status: socket_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `socket_status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | socket_status: socket_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `socket_status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:443:32 [INFO] [stderr] | [INFO] [stderr] 443 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 444 | | if let Some(err_response) = err_response { [INFO] [stderr] 445 | | Some(err_response) [INFO] [stderr] 446 | | } else { [INFO] [stderr] 447 | | None [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 443 | } else if let Some(err_response) = err_response { [INFO] [stderr] 444 | Some(err_response) [INFO] [stderr] 445 | } else { [INFO] [stderr] 446 | None [INFO] [stderr] 447 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:443:32 [INFO] [stderr] | [INFO] [stderr] 443 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 444 | | if let Some(err_response) = err_response { [INFO] [stderr] 445 | | Some(err_response) [INFO] [stderr] 446 | | } else { [INFO] [stderr] 447 | | None [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 443 | } else if let Some(err_response) = err_response { [INFO] [stderr] 444 | Some(err_response) [INFO] [stderr] 445 | } else { [INFO] [stderr] 446 | None [INFO] [stderr] 447 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / Stream { [INFO] [stderr] 149 | | stream: mio::net::TcpStream, [INFO] [stderr] 150 | | keep_alive: bool, [INFO] [stderr] 151 | | socket_status: SocketStatus, [INFO] [stderr] ... | [INFO] [stderr] 157 | | bytes_written: usize, [INFO] [stderr] 158 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / Stream { [INFO] [stderr] 149 | | stream: mio::net::TcpStream, [INFO] [stderr] 150 | | keep_alive: bool, [INFO] [stderr] 151 | | socket_status: SocketStatus, [INFO] [stderr] ... | [INFO] [stderr] 157 | | bytes_written: usize, [INFO] [stderr] 158 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / fn continued_stream(stream: mio::net::TcpStream, [INFO] [stderr] 182 | | keep_alive: bool, [INFO] [stderr] 183 | | socket_status: SocketStatus, [INFO] [stderr] 184 | | reader: HttpStreamReader, [INFO] [stderr] ... | [INFO] [stderr] 191 | | Socket::Stream { stream, keep_alive, socket_status, reader, request, done_reading, receiver, response, bytes_written } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / match self { [INFO] [stderr] 213 | | &Thread::Pooled { ref pool } => { [INFO] [stderr] 214 | | pool.execute(f); [INFO] [stderr] 215 | | } [INFO] [stderr] ... | [INFO] [stderr] 218 | | } [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 212 | match *self { [INFO] [stderr] 213 | Thread::Pooled { ref pool } => { [INFO] [stderr] 214 | pool.execute(f); [INFO] [stderr] 215 | } [INFO] [stderr] 216 | Thread::Threaded => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | / pub fn start(&self, func: F) -> Result<()> [INFO] [stderr] 280 | | where F: Send + Sync + 'static + Fn(Request) -> Response> [INFO] [stderr] 281 | | { [INFO] [stderr] 282 | | let func = sync::Arc::new(func); [INFO] [stderr] ... | [INFO] [stderr] 520 | | } [INFO] [stderr] 521 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / Stream { [INFO] [stderr] 149 | | stream: mio::net::TcpStream, [INFO] [stderr] 150 | | keep_alive: bool, [INFO] [stderr] 151 | | socket_status: SocketStatus, [INFO] [stderr] ... | [INFO] [stderr] 157 | | bytes_written: usize, [INFO] [stderr] 158 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / Stream { [INFO] [stderr] 149 | | stream: mio::net::TcpStream, [INFO] [stderr] 150 | | keep_alive: bool, [INFO] [stderr] 151 | | socket_status: SocketStatus, [INFO] [stderr] ... | [INFO] [stderr] 157 | | bytes_written: usize, [INFO] [stderr] 158 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / fn continued_stream(stream: mio::net::TcpStream, [INFO] [stderr] 182 | | keep_alive: bool, [INFO] [stderr] 183 | | socket_status: SocketStatus, [INFO] [stderr] 184 | | reader: HttpStreamReader, [INFO] [stderr] ... | [INFO] [stderr] 191 | | Socket::Stream { stream, keep_alive, socket_status, reader, request, done_reading, receiver, response, bytes_written } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / match self { [INFO] [stderr] 213 | | &Thread::Pooled { ref pool } => { [INFO] [stderr] 214 | | pool.execute(f); [INFO] [stderr] 215 | | } [INFO] [stderr] ... | [INFO] [stderr] 218 | | } [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 212 | match *self { [INFO] [stderr] 213 | Thread::Pooled { ref pool } => { [INFO] [stderr] 214 | pool.execute(f); [INFO] [stderr] 215 | } [INFO] [stderr] 216 | Thread::Threaded => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | / pub fn start(&self, func: F) -> Result<()> [INFO] [stderr] 280 | | where F: Send + Sync + 'static + Fn(Request) -> Response> [INFO] [stderr] 281 | | { [INFO] [stderr] 282 | | let func = sync::Arc::new(func); [INFO] [stderr] ... | [INFO] [stderr] 520 | | } [INFO] [stderr] 521 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/echo.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | let resp = if request.body().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!request.body().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.90s [INFO] running `"docker" "inspect" "306ae80a971084a38f1c09e4545bb0cfffddf9ebe5bb366ee90896fe1e7c8b15"` [INFO] running `"docker" "rm" "-f" "306ae80a971084a38f1c09e4545bb0cfffddf9ebe5bb366ee90896fe1e7c8b15"` [INFO] [stdout] 306ae80a971084a38f1c09e4545bb0cfffddf9ebe5bb366ee90896fe1e7c8b15