[INFO] crate mime 0.3.12 is already in cache [INFO] extracting crate mime 0.3.12 into work/ex/clippy-test-run/sources/stable/reg/mime/0.3.12 [INFO] extracting crate mime 0.3.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mime/0.3.12 [INFO] validating manifest of mime-0.3.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mime-0.3.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mime-0.3.12 [INFO] finished frobbing mime-0.3.12 [INFO] frobbed toml for mime-0.3.12 written to work/ex/clippy-test-run/sources/stable/reg/mime/0.3.12/Cargo.toml [INFO] started frobbing mime-0.3.12 [INFO] finished frobbing mime-0.3.12 [INFO] frobbed toml for mime-0.3.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mime/0.3.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mime-0.3.12 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mime/0.3.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb3b62a0851b3bbbb6b07fba34305b3695d0c11393b60a0265ff8cf72e4ea9e7 [INFO] running `"docker" "start" "-a" "eb3b62a0851b3bbbb6b07fba34305b3695d0c11393b60a0265ff8cf72e4ea9e7"` [INFO] [stderr] Checking mime v0.3.12 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | slash: slash, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | plus: plus, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `plus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | slash: slash, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | plus: plus, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `plus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | slash: slash, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | plus: plus, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `plus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | slash: slash, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | plus: plus, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `plus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | byte: byte, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/parse.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | / if semicolon + 2 == name.0 && CHARSET == &s[name.0..name.1] { [INFO] [stderr] 222 | | if UTF_8 == &s[value.0..value.1] { [INFO] [stderr] 223 | | params = ParamSource::Utf8(semicolon); [INFO] [stderr] 224 | | continue 'params; [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | if semicolon + 2 == name.0 && CHARSET == &s[name.0..name.1] && UTF_8 == &s[value.0..value.1] { [INFO] [stderr] 222 | params = ParamSource::Utf8(semicolon); [INFO] [stderr] 223 | continue 'params; [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | return self.semicolon().unwrap_or(self.source.as_ref().len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.semicolon().unwrap_or(self.source.as_ref().len())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 320 | | if &a[..a_end] != &b[..b_end] { [INFO] [stderr] 321 | | return false; [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 319 | } else if &a[..a_end] != &b[..b_end] { [INFO] [stderr] 320 | return false; [INFO] [stderr] 321 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 20 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mime`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/parse.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | / if semicolon + 2 == name.0 && CHARSET == &s[name.0..name.1] { [INFO] [stderr] 222 | | if UTF_8 == &s[value.0..value.1] { [INFO] [stderr] 223 | | params = ParamSource::Utf8(semicolon); [INFO] [stderr] 224 | | continue 'params; [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | if semicolon + 2 == name.0 && CHARSET == &s[name.0..name.1] && UTF_8 == &s[value.0..value.1] { [INFO] [stderr] 222 | params = ParamSource::Utf8(semicolon); [INFO] [stderr] 223 | continue 'params; [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | return self.semicolon().unwrap_or(self.source.as_ref().len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.semicolon().unwrap_or(self.source.as_ref().len())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 320 | | if &a[..a_end] != &b[..b_end] { [INFO] [stderr] 321 | | return false; [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 319 | } else if &a[..a_end] != &b[..b_end] { [INFO] [stderr] 320 | return false; [INFO] [stderr] 321 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 20 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mime`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eb3b62a0851b3bbbb6b07fba34305b3695d0c11393b60a0265ff8cf72e4ea9e7"` [INFO] running `"docker" "rm" "-f" "eb3b62a0851b3bbbb6b07fba34305b3695d0c11393b60a0265ff8cf72e4ea9e7"` [INFO] [stdout] eb3b62a0851b3bbbb6b07fba34305b3695d0c11393b60a0265ff8cf72e4ea9e7