[INFO] crate milstian-internet-framework 0.3.0 is already in cache [INFO] extracting crate milstian-internet-framework 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/milstian-internet-framework/0.3.0 [INFO] extracting crate milstian-internet-framework 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/milstian-internet-framework/0.3.0 [INFO] validating manifest of milstian-internet-framework-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of milstian-internet-framework-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing milstian-internet-framework-0.3.0 [INFO] finished frobbing milstian-internet-framework-0.3.0 [INFO] frobbed toml for milstian-internet-framework-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/milstian-internet-framework/0.3.0/Cargo.toml [INFO] started frobbing milstian-internet-framework-0.3.0 [INFO] finished frobbing milstian-internet-framework-0.3.0 [INFO] frobbed toml for milstian-internet-framework-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/milstian-internet-framework/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting milstian-internet-framework-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/milstian-internet-framework/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e5dca1472454a367c0b618a845ae824fb510d803b16c907db17551148384928 [INFO] running `"docker" "start" "-a" "6e5dca1472454a367c0b618a845ae824fb510d803b16c907db17551148384928"` [INFO] [stderr] Checking milstian-http v0.1.9 [INFO] [stderr] Checking milstian-feedback v0.1.1 [INFO] [stderr] Checking milstian-internet-framework v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread/mod.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread/mod.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/error.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / return Ok(response::Message::new( [INFO] [stderr] 47 | | protocol.to_string(), [INFO] [stderr] 48 | | status_code.to_string(), [INFO] [stderr] 49 | | headers, [INFO] [stderr] 50 | | response_body, [INFO] [stderr] 51 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | Ok(response::Message::new( [INFO] [stderr] 47 | protocol.to_string(), [INFO] [stderr] 48 | status_code.to_string(), [INFO] [stderr] 49 | headers, [INFO] [stderr] 50 | response_body, [INFO] [stderr] 51 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/file_not_found.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return exists && !is_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exists && !is_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(modified); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(modified)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | / return Err(format!( [INFO] [stderr] 55 | | "Failed to parse '{}', error: {:?}", [INFO] [stderr] 56 | | &modified, error [INFO] [stderr] 57 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Err(format!( [INFO] [stderr] 55 | "Failed to parse '{}', error: {:?}", [INFO] [stderr] 56 | &modified, error [INFO] [stderr] 57 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return "max-age=2592000".to_string(); // TODO Make this dynamic? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"max-age=2592000".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:235:25 [INFO] [stderr] | [INFO] [stderr] 235 | / return Ok(response::Message::new( [INFO] [stderr] 236 | | protocol.to_string(), [INFO] [stderr] 237 | | status_code.to_string(), [INFO] [stderr] 238 | | headers, [INFO] [stderr] 239 | | response_body, [INFO] [stderr] 240 | | )); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 235 | Ok(response::Message::new( [INFO] [stderr] 236 | protocol.to_string(), [INFO] [stderr] 237 | status_code.to_string(), [INFO] [stderr] 238 | headers, [INFO] [stderr] 239 | response_body, [INFO] [stderr] 240 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:243:25 [INFO] [stderr] | [INFO] [stderr] 243 | / return Err(format!( [INFO] [stderr] 244 | | "Error: Failed to read file {}, error: {:?}", [INFO] [stderr] 245 | | filename, e [INFO] [stderr] 246 | | )); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 243 | Err(format!( [INFO] [stderr] 244 | "Error: Failed to read file {}, error: {:?}", [INFO] [stderr] 245 | filename, e [INFO] [stderr] 246 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | / return Err(format!( [INFO] [stderr] 252 | | "Error: Failed to open file {}, error: {:?}", [INFO] [stderr] 253 | | filename, e [INFO] [stderr] 254 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 251 | Err(format!( [INFO] [stderr] 252 | "Error: Failed to open file {}, error: {:?}", [INFO] [stderr] 253 | filename, e [INFO] [stderr] 254 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:184:62 [INFO] [stderr] | [INFO] [stderr] 184 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return Err("Found no matching HTTP responder".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Found no matching HTTP responder".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | / return Err(format!( [INFO] [stderr] 79 | | "Could not find canonical path from: {:?}, error: {}", [INFO] [stderr] 80 | | &root_path, &error [INFO] [stderr] 81 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | Err(format!( [INFO] [stderr] 79 | "Could not find canonical path from: {:?}, error: {}", [INFO] [stderr] 80 | &root_path, &error [INFO] [stderr] 81 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/error.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / return Ok(response::Message::new( [INFO] [stderr] 47 | | protocol.to_string(), [INFO] [stderr] 48 | | status_code.to_string(), [INFO] [stderr] 49 | | headers, [INFO] [stderr] 50 | | response_body, [INFO] [stderr] 51 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | Ok(response::Message::new( [INFO] [stderr] 47 | protocol.to_string(), [INFO] [stderr] 48 | status_code.to_string(), [INFO] [stderr] 49 | headers, [INFO] [stderr] 50 | response_body, [INFO] [stderr] 51 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/file_not_found.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return exists && !is_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exists && !is_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/file_not_found.rs:185:46 [INFO] [stderr] | [INFO] [stderr] 185 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(modified); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(modified)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | / return Err(format!( [INFO] [stderr] 55 | | "Failed to parse '{}', error: {:?}", [INFO] [stderr] 56 | | &modified, error [INFO] [stderr] 57 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Err(format!( [INFO] [stderr] 55 | "Failed to parse '{}', error: {:?}", [INFO] [stderr] 56 | &modified, error [INFO] [stderr] 57 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return "max-age=2592000".to_string(); // TODO Make this dynamic? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"max-age=2592000".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:235:25 [INFO] [stderr] | [INFO] [stderr] 235 | / return Ok(response::Message::new( [INFO] [stderr] 236 | | protocol.to_string(), [INFO] [stderr] 237 | | status_code.to_string(), [INFO] [stderr] 238 | | headers, [INFO] [stderr] 239 | | response_body, [INFO] [stderr] 240 | | )); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 235 | Ok(response::Message::new( [INFO] [stderr] 236 | protocol.to_string(), [INFO] [stderr] 237 | status_code.to_string(), [INFO] [stderr] 238 | headers, [INFO] [stderr] 239 | response_body, [INFO] [stderr] 240 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:243:25 [INFO] [stderr] | [INFO] [stderr] 243 | / return Err(format!( [INFO] [stderr] 244 | | "Error: Failed to read file {}, error: {:?}", [INFO] [stderr] 245 | | filename, e [INFO] [stderr] 246 | | )); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 243 | Err(format!( [INFO] [stderr] 244 | "Error: Failed to read file {}, error: {:?}", [INFO] [stderr] 245 | filename, e [INFO] [stderr] 246 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | / return Err(format!( [INFO] [stderr] 252 | | "Error: Failed to open file {}, error: {:?}", [INFO] [stderr] 253 | | filename, e [INFO] [stderr] 254 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 251 | Err(format!( [INFO] [stderr] 252 | "Error: Failed to open file {}, error: {:?}", [INFO] [stderr] 253 | filename, e [INFO] [stderr] 254 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:184:62 [INFO] [stderr] | [INFO] [stderr] 184 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:402:46 [INFO] [stderr] | [INFO] [stderr] 402 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:443:46 [INFO] [stderr] | [INFO] [stderr] 443 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:497:46 [INFO] [stderr] | [INFO] [stderr] 497 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:520:46 [INFO] [stderr] | [INFO] [stderr] 520 | let duration = Duration::new(250000, 0); [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:560:46 [INFO] [stderr] | [INFO] [stderr] 560 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:603:46 [INFO] [stderr] | [INFO] [stderr] 603 | let duration = Duration::new(2592000, 0); // TODO Make this dynamic [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:626:46 [INFO] [stderr] | [INFO] [stderr] 626 | let duration = Duration::new(250000, 0); [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response/tcp/http/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return Err("Found no matching HTTP responder".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Found no matching HTTP responder".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | / return Err(format!( [INFO] [stderr] 79 | | "Could not find canonical path from: {:?}, error: {}", [INFO] [stderr] 80 | | &root_path, &error [INFO] [stderr] 81 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | Err(format!( [INFO] [stderr] 79 | "Could not find canonical path from: {:?}, error: {}", [INFO] [stderr] 80 | &root_path, &error [INFO] [stderr] 81 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/mime.rs:13:48 [INFO] [stderr] | [INFO] [stderr] 13 | let parts: Vec<&str> = filename.rsplitn(2, ".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::error::Responder` [INFO] [stderr] --> src/response/tcp/http/error.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Responder { [INFO] [stderr] 18 | | Responder {} [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::file_not_found::Responder` [INFO] [stderr] --> src/response/tcp/http/file_not_found.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Responder { [INFO] [stderr] 21 | | Responder { filename: None } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::filesystem::Responder` [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Responder { [INFO] [stderr] 34 | | Responder { filename: None } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:42:48 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn get_rfc7231_as_systemtime(modified: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | filename: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:218:52 [INFO] [stderr] | [INFO] [stderr] 218 | if duration.as_secs() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using duration.as_secs() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::Dispatcher` [INFO] [stderr] --> src/response/tcp/http/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Dispatcher { [INFO] [stderr] 21 | | Dispatcher { [INFO] [stderr] 22 | | request_message: None, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | _overflow_bytes: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | overflow_bytes: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:88:73 [INFO] [stderr] | [INFO] [stderr] 88 | fn matches(&mut self, &request::Message, &Application, &SocketAddr, &u8) -> bool; [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/response/tcp/mod.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | acc_read_size = acc_read_size + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `acc_read_size += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/response/tcp/mod.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | overflow_bytes = overflow_bytes + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overflow_bytes += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/response/tcp/mod.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if buffer.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response/tcp/mod.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | .info(format!("Request was successfully decoded as HTTP")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Request was successfully decoded as HTTP".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response/tcp/mod.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | .info(format!("Found non-empty HTTP response to TCP stream")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Found non-empty HTTP response to TCP stream".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response/tcp/mod.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | .info(format!("Request could not be decoded as HTTP")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Request could not be decoded as HTTP".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_canonical_root(root_path: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `milstian-internet-framework`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/mime.rs:13:48 [INFO] [stderr] | [INFO] [stderr] 13 | let parts: Vec<&str> = filename.rsplitn(2, ".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::error::Responder` [INFO] [stderr] --> src/response/tcp/http/error.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Responder { [INFO] [stderr] 18 | | Responder {} [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::file_not_found::Responder` [INFO] [stderr] --> src/response/tcp/http/file_not_found.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Responder { [INFO] [stderr] 21 | | Responder { filename: None } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::filesystem::Responder` [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Responder { [INFO] [stderr] 34 | | Responder { filename: None } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:42:48 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn get_rfc7231_as_systemtime(modified: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | filename: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/response/tcp/http/filesystem.rs:218:52 [INFO] [stderr] | [INFO] [stderr] 218 | if duration.as_secs() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using duration.as_secs() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `response::tcp::http::Dispatcher` [INFO] [stderr] --> src/response/tcp/http/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Dispatcher { [INFO] [stderr] 21 | | Dispatcher { [INFO] [stderr] 22 | | request_message: None, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | _overflow_bytes: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | overflow_bytes: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:88:73 [INFO] [stderr] | [INFO] [stderr] 88 | fn matches(&mut self, &request::Message, &Application, &SocketAddr, &u8) -> bool; [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response/tcp/http/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/response/tcp/mod.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | acc_read_size = acc_read_size + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `acc_read_size += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/response/tcp/mod.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | overflow_bytes = overflow_bytes + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overflow_bytes += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/response/tcp/mod.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if buffer.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response/tcp/mod.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | .info(format!("Request was successfully decoded as HTTP")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Request was successfully decoded as HTTP".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response/tcp/mod.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | .info(format!("Found non-empty HTTP response to TCP stream")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Found non-empty HTTP response to TCP stream".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/response/tcp/mod.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | .info(format!("Request could not be decoded as HTTP")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Request could not be decoded as HTTP".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_canonical_root(root_path: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `milstian-internet-framework`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6e5dca1472454a367c0b618a845ae824fb510d803b16c907db17551148384928"` [INFO] running `"docker" "rm" "-f" "6e5dca1472454a367c0b618a845ae824fb510d803b16c907db17551148384928"` [INFO] [stdout] 6e5dca1472454a367c0b618a845ae824fb510d803b16c907db17551148384928