[INFO] crate migrant_lib 0.21.0 is already in cache [INFO] extracting crate migrant_lib 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/migrant_lib/0.21.0 [INFO] extracting crate migrant_lib 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/migrant_lib/0.21.0 [INFO] validating manifest of migrant_lib-0.21.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of migrant_lib-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing migrant_lib-0.21.0 [INFO] finished frobbing migrant_lib-0.21.0 [INFO] frobbed toml for migrant_lib-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/migrant_lib/0.21.0/Cargo.toml [INFO] started frobbing migrant_lib-0.21.0 [INFO] finished frobbing migrant_lib-0.21.0 [INFO] frobbed toml for migrant_lib-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/migrant_lib/0.21.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting migrant_lib-0.21.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/migrant_lib/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34e49714be7c03895306dec95fc67d42445a0c94261f32c100530797d174ccb7 [INFO] running `"docker" "start" "-a" "34e49714be7c03895306dec95fc67d42445a0c94261f32c100530797d174ccb7"` [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking migrant_lib v0.21.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:603:13 [INFO] [stderr] | [INFO] [stderr] 603 | up: up, [INFO] [stderr] | ^^^^^^ help: replace it with: `up` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | down: down, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:603:13 [INFO] [stderr] | [INFO] [stderr] 603 | up: up, [INFO] [stderr] | ^^^^^^ help: replace it with: `up` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | down: down, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/drivers/mysql.rs:74:42 [INFO] [stderr] | [INFO] [stderr] 74 | let mut s = s.trim_right_matches(",").to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | let kind = match options { [INFO] [stderr] | ________________________^ [INFO] [stderr] 177 | | &DatabaseConfigOptions::Sqlite(_) => DbKind::Sqlite, [INFO] [stderr] 178 | | &DatabaseConfigOptions::Postgres(_) => DbKind::Postgres, [INFO] [stderr] 179 | | &DatabaseConfigOptions::MySql(_) => DbKind::MySql, [INFO] [stderr] 180 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | let kind = match *options { [INFO] [stderr] 177 | DatabaseConfigOptions::Sqlite(_) => DbKind::Sqlite, [INFO] [stderr] 178 | DatabaseConfigOptions::Postgres(_) => DbKind::Postgres, [INFO] [stderr] 179 | DatabaseConfigOptions::MySql(_) => DbKind::MySql, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | let _ = prompt(&format!(" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/config.rs:1169:5 [INFO] [stderr] | [INFO] [stderr] 1169 | / pub fn setup(&self) -> Result { [INFO] [stderr] 1170 | | debug!(" ** Confirming database credentials..."); [INFO] [stderr] 1171 | | match &self.settings.inner { [INFO] [stderr] 1172 | | &ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] ... | [INFO] [stderr] 1245 | | } [INFO] [stderr] 1246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:1171:9 [INFO] [stderr] | [INFO] [stderr] 1171 | / match &self.settings.inner { [INFO] [stderr] 1172 | | &ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1173 | | let created = drivers::sqlite::create_file_if_missing(&self.database_path()?)?; [INFO] [stderr] 1174 | | debug!(" - checking if db file already exists..."); [INFO] [stderr] ... | [INFO] [stderr] 1220 | | } [INFO] [stderr] 1221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1171 | match self.settings.inner { [INFO] [stderr] 1172 | ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1173 | let created = drivers::sqlite::create_file_if_missing(&self.database_path()?)?; [INFO] [stderr] 1174 | debug!(" - checking if db file already exists..."); [INFO] [stderr] 1175 | if created { [INFO] [stderr] 1176 | debug!(" - db not found... creating now... ✓") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:1224:29 [INFO] [stderr] | [INFO] [stderr] 1224 | let table_created = match &self.settings.inner { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 1225 | | &ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1226 | | drivers::sqlite::migration_setup(&self.database_path()?)? [INFO] [stderr] 1227 | | } [INFO] [stderr] ... | [INFO] [stderr] 1235 | | } [INFO] [stderr] 1236 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1224 | let table_created = match self.settings.inner { [INFO] [stderr] 1225 | ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1226 | drivers::sqlite::migration_setup(&self.database_path()?)? [INFO] [stderr] 1227 | } [INFO] [stderr] 1228 | ConfigurableSettings::Postgres(ref s) => { [INFO] [stderr] 1229 | let conn_str = s.connect_string()?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/drivers/mysql.rs:74:42 [INFO] [stderr] | [INFO] [stderr] 74 | let mut s = s.trim_right_matches(",").to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:400:16 [INFO] [stderr] | [INFO] [stderr] 400 | Ok(match res { [INFO] [stderr] | ________________^ [INFO] [stderr] 401 | | Ok(_) => (), [INFO] [stderr] 402 | | Err(ref e) if e.is_migration_complete() => (), [INFO] [stderr] 403 | | Err(e) => return Err(e), [INFO] [stderr] 404 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 400 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:412:64 [INFO] [stderr] | [INFO] [stderr] 412 | applied: &[String]) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&'a Migratable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | let kind = match options { [INFO] [stderr] | ________________________^ [INFO] [stderr] 177 | | &DatabaseConfigOptions::Sqlite(_) => DbKind::Sqlite, [INFO] [stderr] 178 | | &DatabaseConfigOptions::Postgres(_) => DbKind::Postgres, [INFO] [stderr] 179 | | &DatabaseConfigOptions::MySql(_) => DbKind::MySql, [INFO] [stderr] 180 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | let kind = match *options { [INFO] [stderr] 177 | DatabaseConfigOptions::Sqlite(_) => DbKind::Sqlite, [INFO] [stderr] 178 | DatabaseConfigOptions::Postgres(_) => DbKind::Postgres, [INFO] [stderr] 179 | DatabaseConfigOptions::MySql(_) => DbKind::MySql, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:440:33 [INFO] [stderr] | [INFO] [stderr] 440 | migration: &Box) -> std::result::Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&Migratable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:442:12 [INFO] [stderr] | [INFO] [stderr] 442 | Ok(match *direction { [INFO] [stderr] | ____________^ [INFO] [stderr] 443 | | Direction::Up => { [INFO] [stderr] 444 | | migration.apply_up(db_kind, config)?; [INFO] [stderr] 445 | | } [INFO] [stderr] ... | [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 442 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | let _ = prompt(&format!(" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:710:8 [INFO] [stderr] | [INFO] [stderr] 710 | Ok(match config.settings.inner.db_kind() { [INFO] [stderr] | ________^ [INFO] [stderr] 711 | | DbKind::Sqlite => { [INFO] [stderr] 712 | | let db_path = config.database_path()?; [INFO] [stderr] 713 | | let _ = Command::new("sqlite3") [INFO] [stderr] ... | [INFO] [stderr] 739 | | } [INFO] [stderr] 740 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 710 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:812:21 [INFO] [stderr] | [INFO] [stderr] 812 | let _ = prompt(&format!(" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/config.rs:1169:5 [INFO] [stderr] | [INFO] [stderr] 1169 | / pub fn setup(&self) -> Result { [INFO] [stderr] 1170 | | debug!(" ** Confirming database credentials..."); [INFO] [stderr] 1171 | | match &self.settings.inner { [INFO] [stderr] 1172 | | &ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] ... | [INFO] [stderr] 1245 | | } [INFO] [stderr] 1246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:1171:9 [INFO] [stderr] | [INFO] [stderr] 1171 | / match &self.settings.inner { [INFO] [stderr] 1172 | | &ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1173 | | let created = drivers::sqlite::create_file_if_missing(&self.database_path()?)?; [INFO] [stderr] 1174 | | debug!(" - checking if db file already exists..."); [INFO] [stderr] ... | [INFO] [stderr] 1220 | | } [INFO] [stderr] 1221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1171 | match self.settings.inner { [INFO] [stderr] 1172 | ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1173 | let created = drivers::sqlite::create_file_if_missing(&self.database_path()?)?; [INFO] [stderr] 1174 | debug!(" - checking if db file already exists..."); [INFO] [stderr] 1175 | if created { [INFO] [stderr] 1176 | debug!(" - db not found... creating now... ✓") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:1224:29 [INFO] [stderr] | [INFO] [stderr] 1224 | let table_created = match &self.settings.inner { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 1225 | | &ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1226 | | drivers::sqlite::migration_setup(&self.database_path()?)? [INFO] [stderr] 1227 | | } [INFO] [stderr] ... | [INFO] [stderr] 1235 | | } [INFO] [stderr] 1236 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1224 | let table_created = match self.settings.inner { [INFO] [stderr] 1225 | ConfigurableSettings::Sqlite(_) => { [INFO] [stderr] 1226 | drivers::sqlite::migration_setup(&self.database_path()?)? [INFO] [stderr] 1227 | } [INFO] [stderr] 1228 | ConfigurableSettings::Postgres(ref s) => { [INFO] [stderr] 1229 | let conn_str = s.connect_string()?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:400:16 [INFO] [stderr] | [INFO] [stderr] 400 | Ok(match res { [INFO] [stderr] | ________________^ [INFO] [stderr] 401 | | Ok(_) => (), [INFO] [stderr] 402 | | Err(ref e) if e.is_migration_complete() => (), [INFO] [stderr] 403 | | Err(e) => return Err(e), [INFO] [stderr] 404 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 400 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:412:64 [INFO] [stderr] | [INFO] [stderr] 412 | applied: &[String]) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&'a Migratable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:440:33 [INFO] [stderr] | [INFO] [stderr] 440 | migration: &Box) -> std::result::Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&Migratable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:442:12 [INFO] [stderr] | [INFO] [stderr] 442 | Ok(match *direction { [INFO] [stderr] | ____________^ [INFO] [stderr] 443 | | Direction::Up => { [INFO] [stderr] 444 | | migration.apply_up(db_kind, config)?; [INFO] [stderr] 445 | | } [INFO] [stderr] ... | [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 442 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:710:8 [INFO] [stderr] | [INFO] [stderr] 710 | Ok(match config.settings.inner.db_kind() { [INFO] [stderr] | ________^ [INFO] [stderr] 711 | | DbKind::Sqlite => { [INFO] [stderr] 712 | | let db_path = config.database_path()?; [INFO] [stderr] 713 | | let _ = Command::new("sqlite3") [INFO] [stderr] ... | [INFO] [stderr] 739 | | } [INFO] [stderr] 740 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 710 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:812:21 [INFO] [stderr] | [INFO] [stderr] 812 | let _ = prompt(&format!(" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" -- Press [ENTER] to open now or [CTRL+C] to exit and edit manually".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.06s [INFO] running `"docker" "inspect" "34e49714be7c03895306dec95fc67d42445a0c94261f32c100530797d174ccb7"` [INFO] running `"docker" "rm" "-f" "34e49714be7c03895306dec95fc67d42445a0c94261f32c100530797d174ccb7"` [INFO] [stdout] 34e49714be7c03895306dec95fc67d42445a0c94261f32c100530797d174ccb7