[INFO] crate midly 0.1.3 is already in cache [INFO] extracting crate midly 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/midly/0.1.3 [INFO] extracting crate midly 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/midly/0.1.3 [INFO] validating manifest of midly-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of midly-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing midly-0.1.3 [INFO] finished frobbing midly-0.1.3 [INFO] frobbed toml for midly-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/midly/0.1.3/Cargo.toml [INFO] started frobbing midly-0.1.3 [INFO] finished frobbing midly-0.1.3 [INFO] frobbed toml for midly-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/midly/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting midly-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/midly/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 789c8c412ee796900ef197d036ae69f77da12355ac4983023c1220f924abcd42 [INFO] running `"docker" "start" "-a" "789c8c412ee796900ef197d036ae69f77da12355ac4983023c1220f924abcd42"` [INFO] [stderr] Checking midly v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/smf.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn parse_collect_bytes<'a>(&'a self)->Result)>>> {self.parse()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/smf.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | if raw.len()==0 {return Ok(None)} [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/smf.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | if id=="MThd".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"MThd"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/smf.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | }else if id=="MTrk".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"MTrk"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/smf.rs:191:8 [INFO] [stderr] | [INFO] [stderr] 191 | if self.raw.len()>0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/event.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | 0x2F=>{ensure!(data.len()==0,"invalid data len"); MetaMessage::EndOfTrack}, [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | acc|=*byte as $int; [INFO] [stderr] | ^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] ... [INFO] [stderr] 48 | impl_read_int! {u8,u16,u32} [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | acc|=*byte as $int; [INFO] [stderr] | ^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] ... [INFO] [stderr] 48 | impl_read_int! {u8,u16,u32} [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | acc|=*byte as $inner; [INFO] [stderr] | ^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] ... [INFO] [stderr] 106 | restricted_int!{u14: u16 => 14; read read_u7} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:117:12 [INFO] [stderr] | [INFO] [stderr] 117 | acc|=*byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | int|=byte.bit_range(0..7) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte.bit_range(0..7))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:222:15 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn hour(&self)->u8 {self.hour} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn minute(&self)->u8 {self.minute} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | pub fn second(&self)->u8 {self.second} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn frame(&self)->u8 {self.frame} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:226:19 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn subframe(&self)->u8 {self.subframe} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:227:14 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn fps(&self)->Fps {self.fps} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn second_f32(&self)->f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | self.second as f32+((self.frame as f32+self.subframe as f32/100.0)/self.fps.as_f32()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:229:26 [INFO] [stderr] | [INFO] [stderr] 229 | self.second as f32+((self.frame as f32+self.subframe as f32/100.0)/self.fps.as_f32()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.frame)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:229:44 [INFO] [stderr] | [INFO] [stderr] 229 | self.second as f32+((self.frame as f32+self.subframe as f32/100.0)/self.fps.as_f32()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.subframe)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/smf.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn parse_collect_bytes<'a>(&'a self)->Result)>>> {self.parse()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/smf.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | if raw.len()==0 {return Ok(None)} [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/smf.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | if id=="MThd".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"MThd"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/smf.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | }else if id=="MTrk".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"MTrk"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/smf.rs:191:8 [INFO] [stderr] | [INFO] [stderr] 191 | if self.raw.len()>0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/event.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | 0x2F=>{ensure!(data.len()==0,"invalid data len"); MetaMessage::EndOfTrack}, [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | acc|=*byte as $int; [INFO] [stderr] | ^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] ... [INFO] [stderr] 48 | impl_read_int! {u8,u16,u32} [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | acc|=*byte as $int; [INFO] [stderr] | ^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] ... [INFO] [stderr] 48 | impl_read_int! {u8,u16,u32} [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | acc|=*byte as $inner; [INFO] [stderr] | ^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] ... [INFO] [stderr] 106 | restricted_int!{u14: u16 => 14; read read_u7} [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:117:12 [INFO] [stderr] | [INFO] [stderr] 117 | acc|=*byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | int|=byte.bit_range(0..7) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte.bit_range(0..7))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:222:15 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn hour(&self)->u8 {self.hour} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn minute(&self)->u8 {self.minute} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | pub fn second(&self)->u8 {self.second} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn frame(&self)->u8 {self.frame} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:226:19 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn subframe(&self)->u8 {self.subframe} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:227:14 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn fps(&self)->Fps {self.fps} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn second_f32(&self)->f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | self.second as f32+((self.frame as f32+self.subframe as f32/100.0)/self.fps.as_f32()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:229:26 [INFO] [stderr] | [INFO] [stderr] 229 | self.second as f32+((self.frame as f32+self.subframe as f32/100.0)/self.fps.as_f32()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.frame)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/primitive.rs:229:44 [INFO] [stderr] | [INFO] [stderr] 229 | self.second as f32+((self.frame as f32+self.subframe as f32/100.0)/self.fps.as_f32()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.subframe)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.27s [INFO] running `"docker" "inspect" "789c8c412ee796900ef197d036ae69f77da12355ac4983023c1220f924abcd42"` [INFO] running `"docker" "rm" "-f" "789c8c412ee796900ef197d036ae69f77da12355ac4983023c1220f924abcd42"` [INFO] [stdout] 789c8c412ee796900ef197d036ae69f77da12355ac4983023c1220f924abcd42