[INFO] crate middleman 0.3.1 is already in cache [INFO] extracting crate middleman 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/middleman/0.3.1 [INFO] extracting crate middleman 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/middleman/0.3.1 [INFO] validating manifest of middleman-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of middleman-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing middleman-0.3.1 [INFO] finished frobbing middleman-0.3.1 [INFO] frobbed toml for middleman-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/middleman/0.3.1/Cargo.toml [INFO] started frobbing middleman-0.3.1 [INFO] finished frobbing middleman-0.3.1 [INFO] frobbed toml for middleman-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/middleman/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting middleman-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/middleman/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c65b5bb552548b64c9ae01c6f4f22f0aecd23dad54283036f05f7a288dcc51a [INFO] running `"docker" "start" "-a" "1c65b5bb552548b64c9ae01c6f4f22f0aecd23dad54283036f05f7a288dcc51a"` [INFO] [stderr] Checking middleman v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structs.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structs.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/structs.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 364 | let mut vec = Vec::with_capacity(tot_len); [INFO] [stderr] | --------------------------- help: consider replace allocation with: `vec![0; tot_len]` [INFO] [stderr] 365 | vec.resize(tot_len, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/structs.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 364 | let mut vec = Vec::with_capacity(tot_len); [INFO] [stderr] | --------------------------- help: consider replace allocation with: `vec![0; tot_len]` [INFO] [stderr] 365 | vec.resize(tot_len, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:245:32 [INFO] [stderr] | [INFO] [stderr] 245 | let bogus = Msg::Greetings(format!("What shall we do with the drunken sailor?")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"What shall we do with the drunken sailor?".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:285:30 [INFO] [stderr] | [INFO] [stderr] 285 | let msg = Msg::Greetings(format!("Lorem Ipsum is simply dummy text of the printing and typesetting industry.\ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 286 | | Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took\ [INFO] [stderr] 287 | | a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries,\ [INFO] [stderr] 288 | | but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the\ [INFO] [stderr] 289 | | 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop\ [INFO] [stderr] 290 | | publishing software like Aldus PageMaker including versions of Lorem Ipsum.")); [INFO] [stderr] | |_____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 285 | let msg = Msg::Greetings("Lorem Ipsum is simply dummy text of the printing and typesetting industry.\ [INFO] [stderr] 286 | Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took\ [INFO] [stderr] 287 | a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries,\ [INFO] [stderr] 288 | but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the\ [INFO] [stderr] 289 | 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop\ [INFO] [stderr] 290 | publishing software like Aldus PageMaker including versions of Lorem Ipsum.".to_string()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tests.rs:293:14 [INFO] [stderr] | [INFO] [stderr] 293 | for _ in 1..total+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=total` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | (5, format!("whatever, really")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"whatever, really".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tests.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | (5, format!("whatever, really")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"whatever, really".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tests.rs:407:7 [INFO] [stderr] | [INFO] [stderr] 407 | + dur.subsec_nanos() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/tests.rs:433:92 [INFO] [stderr] | [INFO] [stderr] 433 | if clients.get_mut(&token).unwrap().recv_all_packed_map(|this, packed| { [INFO] [stderr] | ____________________________________________________________________________________________^ [INFO] [stderr] 434 | | this.send_packed(& packed).unwrap(); [INFO] [stderr] 435 | | }).1.is_err() { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tests.rs:436:41 [INFO] [stderr] | [INFO] [stderr] 436 | poll.deregister(clients.get(&token).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&clients[&token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/tests.rs:454:58 [INFO] [stderr] | [INFO] [stderr] 454 | if mm.recv_all_packed_map(|this, packed| { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 455 | | this.send_packed(& packed).unwrap(); [INFO] [stderr] 456 | | }).1.is_err() { return } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tests.rs:492:44 [INFO] [stderr] | [INFO] [stderr] 492 | for token in (0..l).chain((l+1)..).map(|x| Token(x)) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `Token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/tests.rs:543:56 [INFO] [stderr] | [INFO] [stderr] 543 | if let Err(_) = stream.write_all(&buf[..bytes]) { [INFO] [stderr] | _________________________________________________- ^^^^^^ [INFO] [stderr] 544 | | remove = true; [INFO] [stderr] 545 | | poll.deregister(stream).unwrap(); [INFO] [stderr] 546 | | break; [INFO] [stderr] 547 | | } [INFO] [stderr] | |_________________________________________________- help: try this: `if stream.write_all(&buf[..bytes]).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.01s [INFO] running `"docker" "inspect" "1c65b5bb552548b64c9ae01c6f4f22f0aecd23dad54283036f05f7a288dcc51a"` [INFO] running `"docker" "rm" "-f" "1c65b5bb552548b64c9ae01c6f4f22f0aecd23dad54283036f05f7a288dcc51a"` [INFO] [stdout] 1c65b5bb552548b64c9ae01c6f4f22f0aecd23dad54283036f05f7a288dcc51a