[INFO] crate microsalt 0.2.21 is already in cache [INFO] extracting crate microsalt 0.2.21 into work/ex/clippy-test-run/sources/stable/reg/microsalt/0.2.21 [INFO] extracting crate microsalt 0.2.21 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/microsalt/0.2.21 [INFO] validating manifest of microsalt-0.2.21 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of microsalt-0.2.21 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing microsalt-0.2.21 [INFO] finished frobbing microsalt-0.2.21 [INFO] frobbed toml for microsalt-0.2.21 written to work/ex/clippy-test-run/sources/stable/reg/microsalt/0.2.21/Cargo.toml [INFO] started frobbing microsalt-0.2.21 [INFO] finished frobbing microsalt-0.2.21 [INFO] frobbed toml for microsalt-0.2.21 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/microsalt/0.2.21/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting microsalt-0.2.21 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/microsalt/0.2.21:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e51e9230b43ea946839f22f40dafbc6a79059713dfdafedb0a42d5eed3ef8fdf [INFO] running `"docker" "start" "-a" "e51e9230b43ea946839f22f40dafbc6a79059713dfdafedb0a42d5eed3ef8fdf"` [INFO] [stderr] Compiling memsec v0.3.4 [INFO] [stderr] Checking index-fixed v0.0.2 [INFO] [stderr] Checking microsalt v0.2.21 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | let mut a = [W(0u64);8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut w = [W(0u64);16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let v = dl64(index_fixed!(&x[8 * i..];..8)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | let t = a[7] + upper_sigma1(a[4]) + ch(a[4],a[5],a[6]) + W(K[i]) + w[i%16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let mut x = [0u8;256]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | let l = x.len() - 9; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let mut c = [0u32;17]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let mut x = [0u32;17]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | let mut u = 0u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let g = h; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let s : u32 = (-((h[16] >> 7) as i32)) as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | let mut c = [0u32;17]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/shared.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let t = c & (p[i]^q[i]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/shared.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | let b : isize = ((m[15]>>16)&1) as isize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let mut x = [W(0u32); 16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut y = [W(0u32); 16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let mut t = [W(0u32); 4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let mut z = [0u8;16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | let mut x = [0u8;64]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let mut u : u32= 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let mut s = [0u8; 32]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let mut c = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let mut d = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut t = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let mut e = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let mut f = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let mut g = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let mut h = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | let mut p = [GF0; 4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | let mut x = [0i64; 64]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | let mut q = p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:448:9 [INFO] [stderr] | [INFO] [stderr] 448 | let n = sm.len() - 64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign/mod.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | SignedData {public_key: public_key, signed: signed} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `public_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign/mod.rs:81:45 [INFO] [stderr] | [INFO] [stderr] 81 | SignedData {public_key: public_key, signed: signed} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | let mut a = [W(0u64);8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut w = [W(0u64);16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let v = dl64(index_fixed!(&x[8 * i..];..8)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | let t = a[7] + upper_sigma1(a[4]) + ch(a[4],a[5],a[6]) + W(K[i]) + w[i%16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let mut x = [0u8;256]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash/sha512.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | let l = x.len() - 9; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let mut c = [0u32;17]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let mut x = [0u32;17]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | let mut u = 0u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let g = h; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let s : u32 = (-((h[16] >> 7) as i32)) as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/onetimeauth/poly1305.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | let mut c = [0u32;17]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/shared.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let t = c & (p[i]^q[i]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/shared.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | let b : isize = ((m[15]>>16)&1) as isize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let mut x = [W(0u32); 16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut y = [W(0u32); 16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let mut t = [W(0u32); 4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let mut z = [0u8;16]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | let mut x = [0u8;64]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let mut u : u32= 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/stream/xsalsa20.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let mut s = [0u8; 32]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let mut c = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let mut d = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut t = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let mut e = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let mut f = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let mut g = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let mut h = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | let mut p = [GF0; 4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | let mut x = [0i64; 64]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:422:13 [INFO] [stderr] | [INFO] [stderr] 422 | let mut q = p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign/ed25519.rs:448:9 [INFO] [stderr] | [INFO] [stderr] 448 | let n = sm.len() - 64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign/mod.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | SignedData {public_key: public_key, signed: signed} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `public_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign/mod.rs:81:45 [INFO] [stderr] | [INFO] [stderr] 81 | SignedData {public_key: public_key, signed: signed} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secretbox/mod.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | Box{nonce: nonce, cipher: cipher} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secretbox/mod.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | Box{nonce: nonce, cipher: cipher} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let mut x = [0i64;80]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut a = GF0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let mut c = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let mut d = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secretbox/mod.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | Box{nonce: nonce, cipher: cipher} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secretbox/mod.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | Box{nonce: nonce, cipher: cipher} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let mut x = [0i64;80]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut a = GF0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let mut c = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:36:13 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 36 | let mut e = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | let mut f = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let mut b = GF0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | let r: u8 = (z[i>>3]>>(i&7))&1; //might be i64 not u8 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boxy/mod.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | Box { nonce: nonce, cipher: cipher } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boxy/mod.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | Box { nonce: nonce, cipher: cipher } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let mut d = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut e = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | let mut f = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let mut b = GF0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | let r: u8 = (z[i>>3]>>(i&7))&1; //might be i64 not u8 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boxy/mod.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | Box { nonce: nonce, cipher: cipher } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boxy/mod.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | Box { nonce: nonce, cipher: cipher } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x428a_2f98_d728_ae22` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7137_4491_23ef_65cd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb5c0_fbcf_ec4d_3b2f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:65 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xe9b5_dba5_8189_dbbc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3956_c25b_f348_b538` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x59f1_11f1_b605_d019` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x923f_82a4_af19_4f9b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:65 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xab1c_5ed5_da6d_8118` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd807_aa98_a303_0242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1283_5b01_4570_6fbe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:45 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2431_85be_4ee4_b28c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:65 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x550c_7dc3_d5ff_b4e2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x72be_5d74_f27b_896f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x80de_b1fe_3b16_96b1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9bdc_06a7_25c7_1235` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:65 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc19b_f174_cf69_2694` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xe49b_69c1_9ef1_4ad2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xefbe_4786_384f_25e3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:45 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0fc1_9dc6_8b8c_d5b5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:65 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x240c_a1cc_77ac_9c65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2de9_2c6f_592b_0275` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4a74_84aa_6ea6_e483` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5cb0_a9dc_bd41_fbd4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:65 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x76f9_88da_8311_53b5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x983e_5152_ee66_dfab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa831_c66d_2db4_3210` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb003_27c8_98fb_213f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:65 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbf59_7fc7_beef_0ee4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc6e0_0bf3_3da8_8fc2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd5a7_9147_930a_a725` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:45 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x06ca_6351_e003_826f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1429_2967_0a0e_6e70` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x27b7_0a85_46d2_2ffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2e1b_2138_5c26_c926` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4d2c_6dfc_5ac4_2aed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:65 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5338_0d13_9d95_b3df` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x650a_7354_8baf_63de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x766a_0abb_3c77_b2a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:45 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x81c2_c92e_47ed_aee6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:65 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9272_2c85_1482_353b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa2bf_e8a1_4cf1_0364` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa81a_664b_bc42_3001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:45 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc24b_8b70_d0f8_9791` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:65 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc76c_51a3_0654_be30` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd192_e819_d6ef_5218` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd699_0624_5565_a910` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:45 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf40e_3585_5771_202a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:65 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x106a_a070_32bb_d1b8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x19a4_c116_b8d2_d0c8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1e37_6c08_5141_ab53` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:45 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2748_774c_df8e_eb99` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:65 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x34b0_bcb5_e19b_48a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x391c_0cb3_c5c9_5a63` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4ed8_aa4a_e341_8acb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5b9c_ca4f_7763_e373` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:65 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x682e_6ff3_d6b2_b8a3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x748f_82ee_5def_b2fc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x78a5_636f_4317_2f60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:45 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x84c8_7814_a1f0_ab72` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:65 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8cc7_0208_1a64_39ec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x90be_fffa_2363_1e28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa450_6ceb_de82_bde9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:45 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbef9_a3f7_b2c6_7915` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc671_78f2_e372_532b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xca27_3ece_ea26_619c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd186_b8c7_21c0_c207` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:45 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xeada_7dd6_cde0_eb1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:65 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf57d_4f7f_ee6e_d178` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x06f0_67aa_7217_6fba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0a63_7dc5_a2c8_98a6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x113f_9804_bef9_0dae` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:65 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1b71_0b35_131c_471b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x28db_77f5_2304_7d84` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x32ca_ab7b_40c7_2493` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3c9e_be0a_15c9_bebc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:65 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x431d_67c4_9c10_0d4c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4cc5_d4be_cb3e_42b6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x597f_299c_fc65_7e2a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5fcb_6fab_3ad6_faec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:65 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x6c44_198c_4a47_5817` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Hash`, `Hasher` [INFO] [stderr] --> src/hash/mod.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cmp` [INFO] [stderr] --> src/shared.rs:202:11 [INFO] [stderr] | [INFO] [stderr] 202 | use std::{cmp, mem}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/xsalsa20.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | (x << c) | ((x & W(0xffffffff)) >> (32 - c)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sign/ed25519.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | return d[0]&1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `d[0]&1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sign/ed25519.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `shared` [INFO] [stderr] --> src/sign/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use shared; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sign/mod.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | tmp1 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sign/mod.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | let tmp1 = tmp.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `shared` [INFO] [stderr] --> src/secretbox/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use shared; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `shared` [INFO] [stderr] --> src/boxy/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use shared; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let v = seed.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x428a_2f98_d728_ae22` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7137_4491_23ef_65cd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb5c0_fbcf_ec4d_3b2f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:18:65 [INFO] [stderr] | [INFO] [stderr] 18 | 0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xe9b5_dba5_8189_dbbc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3956_c25b_f348_b538` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x59f1_11f1_b605_d019` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x923f_82a4_af19_4f9b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:19:65 [INFO] [stderr] | [INFO] [stderr] 19 | 0x3956c25bf348b538, 0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xab1c_5ed5_da6d_8118` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd807_aa98_a303_0242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1283_5b01_4570_6fbe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:45 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2431_85be_4ee4_b28c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:20:65 [INFO] [stderr] | [INFO] [stderr] 20 | 0xd807aa98a3030242, 0x12835b0145706fbe, 0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x550c_7dc3_d5ff_b4e2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x72be_5d74_f27b_896f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x80de_b1fe_3b16_96b1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9bdc_06a7_25c7_1235` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:21:65 [INFO] [stderr] | [INFO] [stderr] 21 | 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235, 0xc19bf174cf692694, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc19b_f174_cf69_2694` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xe49b_69c1_9ef1_4ad2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xefbe_4786_384f_25e3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:45 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0fc1_9dc6_8b8c_d5b5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:22:65 [INFO] [stderr] | [INFO] [stderr] 22 | 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x240c_a1cc_77ac_9c65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2de9_2c6f_592b_0275` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4a74_84aa_6ea6_e483` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5cb0_a9dc_bd41_fbd4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:23:65 [INFO] [stderr] | [INFO] [stderr] 23 | 0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x76f9_88da_8311_53b5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x983e_5152_ee66_dfab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa831_c66d_2db4_3210` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb003_27c8_98fb_213f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:24:65 [INFO] [stderr] | [INFO] [stderr] 24 | 0x983e5152ee66dfab, 0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbf59_7fc7_beef_0ee4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc6e0_0bf3_3da8_8fc2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd5a7_9147_930a_a725` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:45 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x06ca_6351_e003_826f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | 0xc6e00bf33da88fc2, 0xd5a79147930aa725, 0x06ca6351e003826f, 0x142929670a0e6e70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1429_2967_0a0e_6e70` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x27b7_0a85_46d2_2ffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2e1b_2138_5c26_c926` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4d2c_6dfc_5ac4_2aed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:26:65 [INFO] [stderr] | [INFO] [stderr] 26 | 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed, 0x53380d139d95b3df, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5338_0d13_9d95_b3df` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x650a_7354_8baf_63de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x766a_0abb_3c77_b2a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:45 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x81c2_c92e_47ed_aee6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:27:65 [INFO] [stderr] | [INFO] [stderr] 27 | 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9272_2c85_1482_353b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa2bf_e8a1_4cf1_0364` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa81a_664b_bc42_3001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:45 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc24b_8b70_d0f8_9791` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:28:65 [INFO] [stderr] | [INFO] [stderr] 28 | 0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc76c_51a3_0654_be30` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd192_e819_d6ef_5218` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd699_0624_5565_a910` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:45 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf40e_3585_5771_202a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:29:65 [INFO] [stderr] | [INFO] [stderr] 29 | 0xd192e819d6ef5218, 0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x106a_a070_32bb_d1b8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x19a4_c116_b8d2_d0c8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1e37_6c08_5141_ab53` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:45 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2748_774c_df8e_eb99` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:30:65 [INFO] [stderr] | [INFO] [stderr] 30 | 0x19a4c116b8d2d0c8, 0x1e376c085141ab53, 0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x34b0_bcb5_e19b_48a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x391c_0cb3_c5c9_5a63` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4ed8_aa4a_e341_8acb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5b9c_ca4f_7763_e373` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:31:65 [INFO] [stderr] | [INFO] [stderr] 31 | 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373, 0x682e6ff3d6b2b8a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x682e_6ff3_d6b2_b8a3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x748f_82ee_5def_b2fc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x78a5_636f_4317_2f60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:45 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x84c8_7814_a1f0_ab72` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:32:65 [INFO] [stderr] | [INFO] [stderr] 32 | 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8cc7_0208_1a64_39ec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x90be_fffa_2363_1e28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa450_6ceb_de82_bde9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:45 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbef9_a3f7_b2c6_7915` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 33 | 0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xc671_78f2_e372_532b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xca27_3ece_ea26_619c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd186_b8c7_21c0_c207` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:45 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xeada_7dd6_cde0_eb1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:34:65 [INFO] [stderr] | [INFO] [stderr] 34 | 0xca273eceea26619c, 0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf57d_4f7f_ee6e_d178` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x06f0_67aa_7217_6fba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0a63_7dc5_a2c8_98a6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x113f_9804_bef9_0dae` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:35:65 [INFO] [stderr] | [INFO] [stderr] 35 | 0x06f067aa72176fba, 0x0a637dc5a2c898a6, 0x113f9804bef90dae, 0x1b710b35131c471b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1b71_0b35_131c_471b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x28db_77f5_2304_7d84` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x32ca_ab7b_40c7_2493` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3c9e_be0a_15c9_bebc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:36:65 [INFO] [stderr] | [INFO] [stderr] 36 | 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc, 0x431d67c49c100d4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x431d_67c4_9c10_0d4c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4cc5_d4be_cb3e_42b6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x597f_299c_fc65_7e2a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5fcb_6fab_3ad6_faec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/sha512.rs:37:65 [INFO] [stderr] | [INFO] [stderr] 37 | 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x6c44_198c_4a47_5817` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Hash`, `Hasher` [INFO] [stderr] --> src/hash/mod.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `cmp` [INFO] [stderr] --> src/shared.rs:202:11 [INFO] [stderr] | [INFO] [stderr] 202 | use std::{cmp, mem}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/xsalsa20.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | (x << c) | ((x & W(0xffffffff)) >> (32 - c)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sign/ed25519.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | return d[0]&1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `d[0]&1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sign/ed25519.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sign/mod.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | tmp1 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sign/mod.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | let tmp1 = tmp.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `shared` [INFO] [stderr] --> src/boxy/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use shared; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let v = seed.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/hash/sha512.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let mut x = &mut x[..new_len]; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sign/ed25519.rs:396:16 [INFO] [stderr] | [INFO] [stderr] 396 | let (init, mut rest) = r.split_at_mut(3); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_data_test_helper` [INFO] [stderr] --> src/shared.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | pub fn random_data_test_helper(len: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SIGN_BYTES` [INFO] [stderr] --> src/sign/ed25519.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub const SIGN_BYTES: usize = 64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hash/sha512.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | fn dl64(x: &[u8;8]) -> W{ [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/sha512.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | u = u << 8 | (*v as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | let v = dl64(index_fixed!(&x[8 * i..];..8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | w[i] = dl64(index_fixed!(&m[8 * i..];..8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/sha512.rs:74:22 [INFO] [stderr] | [INFO] [stderr] 74 | for j in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `b[..8].clone_from_slice(&a[..8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash/sha512.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | b[3] = b[3] + t; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `b[3] += t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash/sha512.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | a[i] = a[i] + z[i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `a[i] += z[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | ts64(index_fixed!(&mut x[8*i..];..8),z[i].0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/sha512.rs:131:14 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0..m.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `x[..m.len()].clone_from_slice(&m[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:142:10 [INFO] [stderr] | [INFO] [stderr] 142 | ts64(index_fixed!(&mut x[l..];..8), (b<<3) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/sha512.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | for i in 0..64 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `out[..64].clone_from_slice(&h[..64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/onetimeauth/poly1305.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | r[j] = k[j] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(k[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/onetimeauth/poly1305.rs:40:11 [INFO] [stderr] | [INFO] [stderr] 40 | while m.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!m.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/onetimeauth/poly1305.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | c[j] = m[j] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(m[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/onetimeauth/poly1305.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..17 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `h[..17].clone_from_slice(&x[..17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `h`. [INFO] [stderr] --> src/onetimeauth/poly1305.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for j in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for in h.iter_mut().take(16) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `h`. [INFO] [stderr] --> src/onetimeauth/poly1305.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | for j in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for in h.iter_mut().take(16) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/onetimeauth/poly1305.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | c[j] = k[j + 16] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(k[j + 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | d |= (x[i] ^ y[i]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(x[i] ^ y[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | o[i]=n[2*i] as i64+((n[2*i+1] as i64)<<8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(n[2*i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | o[i]=n[2*i] as i64+((n[2*i+1] as i64)<<8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(n[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `o[..16].clone_from_slice(&t[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `c[..16].clone_from_slice(&i[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `o[..16].clone_from_slice(&c[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..16 { t[i] = n[i]; } [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `t[..16].clone_from_slice(&n[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream/xsalsa20.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | fn ld32(x: &[u8;4]) -> W { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | let mut u = x[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | u = (u << 8) | (x[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | u = (u << 8) | (x[1] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | W((u << 8) | (x[0] as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | u = u >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `u >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | x[5*i] = ld32(index_fixed!(&c[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | x[1+i] = ld32(index_fixed!(&k[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | x[6+i] = ld32(index_fixed!(&inx[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | x[11+i] = ld32(index_fixed!(&k[16+4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/stream/xsalsa20.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `y[..16].clone_from_slice(&x[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | t[1] = t[1] ^ l32(t[0]+t[3], 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[1] ^= l32(t[0]+t[3], 7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | t[2] = t[2] ^ l32(t[1]+t[0], 9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[2] ^= l32(t[1]+t[0], 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | t[3] = t[3] ^ l32(t[2]+t[1],13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[3] ^= l32(t[2]+t[1],13)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | t[0] = t[0] ^ l32(t[3]+t[2],18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[0] ^= l32(t[3]+t[2],18)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/stream/xsalsa20.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for m in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `x[..16].clone_from_slice(&w[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | x[i] = x[i] + y[i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `x[i] += y[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | x[5*i] = x[5*i] - ld32(index_fixed!(&c[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[5*i] -= ld32(index_fixed!(&c[4*i..];..4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | x[5*i] = x[5*i] - ld32(index_fixed!(&c[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | x[6+i] = x[6+i] - ld32(index_fixed!(&inx[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[6+i] -= ld32(index_fixed!(&inx[4*i..];..4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | x[6+i] = x[6+i] - ld32(index_fixed!(&inx[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | st32(index_fixed!(&mut out[4*i..];..4), x[5*i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | st32(index_fixed!(&mut out[16+4*i..];..4), x[6+i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | st32(index_fixed!(&mut out[4 * i..];..4), x[i] + y[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream/xsalsa20.rs:94:66 [INFO] [stderr] | [INFO] [stderr] 94 | fn stream_salsa20_xor(mut c: &mut [u8], mut m: Option<&[u8]>, n: &[u8;8], k: &[u8;32]) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/stream/xsalsa20.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | m.map(|x| assert_eq!(x.len(), c.len())); //HANDLE ERROR PROPAGATION !!! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = m { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stream/xsalsa20.rs:101:8 [INFO] [stderr] | [INFO] [stderr] 101 | if c.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/stream/xsalsa20.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `z[..8].clone_from_slice(&n[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: The function/method `core_salsa20` doesn't need a mutable reference [INFO] [stderr] --> src/stream/xsalsa20.rs:110:30 [INFO] [stderr] | [INFO] [stderr] 110 | core_salsa20(&mut x, &mut z,k,SIGMA); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `z`. [INFO] [stderr] --> src/stream/xsalsa20.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | for i in 8..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 120 | for in z.iter_mut().skip(8) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | u += z[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(z[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stream/xsalsa20.rs:134:8 [INFO] [stderr] | [INFO] [stderr] 134 | if c.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `core_salsa20` doesn't need a mutable reference [INFO] [stderr] --> src/stream/xsalsa20.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | core_salsa20(&mut x, &mut z,k,SIGMA); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream/xsalsa20.rs:145:37 [INFO] [stderr] | [INFO] [stderr] 145 | fn stream_salsa20(c: &mut [u8], n : &[u8;8], k: &[u8;32]) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | core_hsalsa20(&mut s,index_fixed!(&n[..];..16),k,SIGMA); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | stream_salsa20(c,index_fixed!(&n[16..];..8),&s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:163:26 [INFO] [stderr] | [INFO] [stderr] 163 | core_hsalsa20(&mut s,index_fixed!(&n[..];..16),k,SIGMA); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:164:34 [INFO] [stderr] | [INFO] [stderr] 164 | stream_salsa20_xor(c,Some(m),index_fixed!(&n[16..];..8), &s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `r[..16].clone_from_slice(&a[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:162:6 [INFO] [stderr] | [INFO] [stderr] 162 | *index_fixed!(&mut secret_key;..32) = *seed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | scalarbase(&mut p, index_fixed!(&d;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:171:14 [INFO] [stderr] | [INFO] [stderr] 171 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `secret_key[32..(32 + 32)].clone_from_slice(&public_key[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | x[i] = (r[i] as u64) as i64; // FOR(i,64) x[i] = (u64) r[i]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(r[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `r`. [INFO] [stderr] --> src/sign/ed25519.rs:230:14 [INFO] [stderr] | [INFO] [stderr] 230 | for i in 0..64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 230 | for in r.iter_mut().take(64) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:233:11 [INFO] [stderr] | [INFO] [stderr] 233 | mod_l(index_fixed!(&mut r;..32), &mut x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:265:14 [INFO] [stderr] | [INFO] [stderr] 265 | for i in 0..m.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `sm[64..(m.len() + 64)].clone_from_slice(&m[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:269:14 [INFO] [stderr] | [INFO] [stderr] 269 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `sm[32..(32 + 32)].clone_from_slice(&d[32..(32 + 32)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:275:24 [INFO] [stderr] | [INFO] [stderr] 275 | scalarbase(&mut p, index_fixed!(&r;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:276:10 [INFO] [stderr] | [INFO] [stderr] 276 | pack(index_fixed!(&mut sm;..32), &p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:278:14 [INFO] [stderr] | [INFO] [stderr] 278 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `sm[32..(32 + 32)].clone_from_slice(&sk[32..(32 + 32)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:288:14 [INFO] [stderr] | [INFO] [stderr] 288 | x[i] = r[i] as u64 as i64; //FOR(i,32) x[i] = (u64) r[i]; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(r[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:294:22 [INFO] [stderr] | [INFO] [stderr] 294 | x[i+j] += ((h[i] as u64) * (d[j] as u64)) as i64; //FOR(i,32) FOR(j,32) x[i+j] += h[i] * (u64) d[j]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(h[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:294:38 [INFO] [stderr] | [INFO] [stderr] 294 | x[i+j] += ((h[i] as u64) * (d[j] as u64)) as i64; //FOR(i,32) FOR(j,32) x[i+j] += h[i] * (u64) d[j]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(d[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:298:11 [INFO] [stderr] | [INFO] [stderr] 298 | mod_l(index_fixed!(&mut sm[32..];..32), &mut x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:305:14 [INFO] [stderr] | [INFO] [stderr] 305 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `c[..16].clone_from_slice(&i[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `o[..16].clone_from_slice(&c[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:433:14 [INFO] [stderr] | [INFO] [stderr] 433 | for i in 0..sm.len() { [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `m[..sm.len()].clone_from_slice(&sm[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:436:14 [INFO] [stderr] | [INFO] [stderr] 436 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `m[32..(32 + 32)].clone_from_slice(&pk[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:441:32 [INFO] [stderr] | [INFO] [stderr] 441 | scalarmult(&mut p, &mut q, index_fixed!(&h;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:443:24 [INFO] [stderr] | [INFO] [stderr] 443 | scalarbase(&mut q, index_fixed!(&sm[32..];..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:450:26 [INFO] [stderr] | [INFO] [stderr] 450 | if shared::verify_32(index_fixed!(&sm;..32), &t) != true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `m`. [INFO] [stderr] --> src/sign/ed25519.rs:451:18 [INFO] [stderr] | [INFO] [stderr] 451 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 451 | for in m.iter_mut().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:457:14 [INFO] [stderr] | [INFO] [stderr] 457 | for i in 0..n { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `m[..n].clone_from_slice(&sm[64..(n + 64)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sign::Keypair` [INFO] [stderr] --> src/sign/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> Keypair { [INFO] [stderr] 64 | | let mut pk = [0u8; PUBLIC_KEY_BYTES]; [INFO] [stderr] 65 | | let mut sk = [0u8; SECRET_KEY_BYTES]; [INFO] [stderr] 66 | | [INFO] [stderr] ... | [INFO] [stderr] 69 | | Keypair { public: PublicKey(pk), secret: SecretKey(sk) } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for sign::Keypair { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign/mod.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let public_key = self.public.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.public` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/sign/mod.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / match ed25519::crypto_sign_open(&mut msg, &signed, &key.0) { [INFO] [stderr] 142 | | Some(_) => true, [INFO] [stderr] 143 | | None => false [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ help: try this: `ed25519::crypto_sign_open(&mut msg, &signed, &key.0).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:28:57 [INFO] [stderr] | [INFO] [stderr] 28 | onetimeauth::poly1305::onetimeauth(&mut o, c_m, index_fixed!(&c_k;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | *index_fixed!(&mut out[16..32];..16) = o; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | *index_fixed!(&mut out;..16) = [0u8;16]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | if !onetimeauth::poly1305::onetimeauth_verify(index_fixed!(&c[16..];..16), &c[32..], &x) { // [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `m`. [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in m.iter_mut().take(32) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/secretbox/mod.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | xsalsa20poly1305::secretbox(&mut cipher, &m, &nonce, &key.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | shared::unpack25519(index_fixed!(&mut x;..16),p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `b[..16].clone_from_slice(&x[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:80:40 [INFO] [stderr] | [INFO] [stderr] 80 | shared::gf_multiply(&mut d,b, *index_fixed!(&x;..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] help: try replacing the loop by [INFO] [stderr] | [INFO] [stderr] 85 | for i in x[16..(16 + 16)].clone_from_slice(&a[..16]) [INFO] [stderr] 86 | x[32..(16 + 32)].clone_from_slice(&c[..16]) [INFO] [stderr] 87 | x[48..(16 + 48)].clone_from_slice(&b[..16]) [INFO] [stderr] 88 | x[64..(16 + 64)].clone_from_slice(&d[..16]) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | shared::inv25519(&mut tmp, *index_fixed!(&x[32..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | *index_fixed!(&mut x[32..];..16) = tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | shared::gf_multiply(&mut tmp, *index_fixed!(&x[16..];..16), *index_fixed!(&x[32..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:97:66 [INFO] [stderr] | [INFO] [stderr] 97 | shared::gf_multiply(&mut tmp, *index_fixed!(&x[16..];..16), *index_fixed!(&x[32..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:98:6 [INFO] [stderr] | [INFO] [stderr] 98 | *index_fixed!(&mut x[16..];..16) = tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:99:27 [INFO] [stderr] | [INFO] [stderr] 99 | shared::pack25519(q, *index_fixed!(&x[16..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:123:8 [INFO] [stderr] | [INFO] [stderr] 123 | if secretbox::xsalsa20poly1305::secretbox_open(m,c,n,k) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!secretbox::xsalsa20poly1305::secretbox_open(m,c,n,k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `boxy::Keypair` [INFO] [stderr] --> src/boxy/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Keypair { [INFO] [stderr] 29 | | let mut pk = [0u8; curve25519xsalsa20poly1305::PUBLIC_KEY_LEN]; [INFO] [stderr] 30 | | let mut sk = [0u8; curve25519xsalsa20poly1305::SECRET_KEY_LEN]; [INFO] [stderr] 31 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | Keypair { public: PublicKey(pk), secret: SecretKey(sk) } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for boxy::Keypair { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/boxy/mod.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | curve25519xsalsa20poly1305::box_(&mut cipher, &m, &nonce, &pk.0, &sk.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/hash/sha512.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let mut x = &mut x[..new_len]; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sign/ed25519.rs:396:16 [INFO] [stderr] | [INFO] [stderr] 396 | let (init, mut rest) = r.split_at_mut(3); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SIGN_BYTES` [INFO] [stderr] --> src/sign/ed25519.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub const SIGN_BYTES: usize = 64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hash/sha512.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | fn dl64(x: &[u8;8]) -> W{ [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/sha512.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | u = u << 8 | (*v as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | let v = dl64(index_fixed!(&x[8 * i..];..8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | w[i] = dl64(index_fixed!(&m[8 * i..];..8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/sha512.rs:74:22 [INFO] [stderr] | [INFO] [stderr] 74 | for j in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `b[..8].clone_from_slice(&a[..8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash/sha512.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | b[3] = b[3] + t; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `b[3] += t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash/sha512.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | a[i] = a[i] + z[i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `a[i] += z[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | ts64(index_fixed!(&mut x[8*i..];..8),z[i].0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/sha512.rs:131:14 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0..m.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `x[..m.len()].clone_from_slice(&m[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 8]`) [INFO] [stderr] --> src/hash/sha512.rs:142:10 [INFO] [stderr] | [INFO] [stderr] 142 | ts64(index_fixed!(&mut x[l..];..8), (b<<3) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/sha512.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | for i in 0..64 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `out[..64].clone_from_slice(&h[..64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hash/mod.rs:131:20 [INFO] [stderr] | [INFO] [stderr] 131 | let copy = expected.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/onetimeauth/poly1305.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | r[j] = k[j] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(k[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/onetimeauth/poly1305.rs:40:11 [INFO] [stderr] | [INFO] [stderr] 40 | while m.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!m.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/onetimeauth/poly1305.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | c[j] = m[j] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(m[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/onetimeauth/poly1305.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..17 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `h[..17].clone_from_slice(&x[..17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `h`. [INFO] [stderr] --> src/onetimeauth/poly1305.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for j in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for in h.iter_mut().take(16) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `h`. [INFO] [stderr] --> src/onetimeauth/poly1305.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | for j in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for in h.iter_mut().take(16) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/onetimeauth/poly1305.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | c[j] = k[j + 16] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(k[j + 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | d |= (x[i] ^ y[i]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(x[i] ^ y[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | o[i]=n[2*i] as i64+((n[2*i+1] as i64)<<8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(n[2*i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | o[i]=n[2*i] as i64+((n[2*i+1] as i64)<<8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(n[2*i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `o[..16].clone_from_slice(&t[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `c[..16].clone_from_slice(&i[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `o[..16].clone_from_slice(&c[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/shared.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | for i in 0..16 { t[i] = n[i]; } [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `t[..16].clone_from_slice(&n[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream/xsalsa20.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | fn ld32(x: &[u8;4]) -> W { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | let mut u = x[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | u = (u << 8) | (x[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | u = (u << 8) | (x[1] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | W((u << 8) | (x[0] as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | u = u >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `u >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | x[5*i] = ld32(index_fixed!(&c[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | x[1+i] = ld32(index_fixed!(&k[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | x[6+i] = ld32(index_fixed!(&inx[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | x[11+i] = ld32(index_fixed!(&k[16+4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/stream/xsalsa20.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `y[..16].clone_from_slice(&x[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | t[1] = t[1] ^ l32(t[0]+t[3], 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[1] ^= l32(t[0]+t[3], 7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | t[2] = t[2] ^ l32(t[1]+t[0], 9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[2] ^= l32(t[1]+t[0], 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | t[3] = t[3] ^ l32(t[2]+t[1],13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[3] ^= l32(t[2]+t[1],13)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | t[0] = t[0] ^ l32(t[3]+t[2],18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t[0] ^= l32(t[3]+t[2],18)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/stream/xsalsa20.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for m in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `x[..16].clone_from_slice(&w[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | x[i] = x[i] + y[i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `x[i] += y[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | x[5*i] = x[5*i] - ld32(index_fixed!(&c[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[5*i] -= ld32(index_fixed!(&c[4*i..];..4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | x[5*i] = x[5*i] - ld32(index_fixed!(&c[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/xsalsa20.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | x[6+i] = x[6+i] - ld32(index_fixed!(&inx[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[6+i] -= ld32(index_fixed!(&inx[4*i..];..4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | x[6+i] = x[6+i] - ld32(index_fixed!(&inx[4*i..];..4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | st32(index_fixed!(&mut out[4*i..];..4), x[5*i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | st32(index_fixed!(&mut out[16+4*i..];..4), x[6+i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 4]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | st32(index_fixed!(&mut out[4 * i..];..4), x[i] + y[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream/xsalsa20.rs:94:66 [INFO] [stderr] | [INFO] [stderr] 94 | fn stream_salsa20_xor(mut c: &mut [u8], mut m: Option<&[u8]>, n: &[u8;8], k: &[u8;32]) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/stream/xsalsa20.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | m.map(|x| assert_eq!(x.len(), c.len())); //HANDLE ERROR PROPAGATION !!! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = m { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stream/xsalsa20.rs:101:8 [INFO] [stderr] | [INFO] [stderr] 101 | if c.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/stream/xsalsa20.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `z[..8].clone_from_slice(&n[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: The function/method `core_salsa20` doesn't need a mutable reference [INFO] [stderr] --> src/stream/xsalsa20.rs:110:30 [INFO] [stderr] | [INFO] [stderr] 110 | core_salsa20(&mut x, &mut z,k,SIGMA); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `z`. [INFO] [stderr] --> src/stream/xsalsa20.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | for i in 8..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 120 | for in z.iter_mut().skip(8) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream/xsalsa20.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | u += z[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(z[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stream/xsalsa20.rs:134:8 [INFO] [stderr] | [INFO] [stderr] 134 | if c.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `core_salsa20` doesn't need a mutable reference [INFO] [stderr] --> src/stream/xsalsa20.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | core_salsa20(&mut x, &mut z,k,SIGMA); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream/xsalsa20.rs:145:37 [INFO] [stderr] | [INFO] [stderr] 145 | fn stream_salsa20(c: &mut [u8], n : &[u8;8], k: &[u8;32]) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `[u8;8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | core_hsalsa20(&mut s,index_fixed!(&n[..];..16),k,SIGMA); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | stream_salsa20(c,index_fixed!(&n[16..];..8),&s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:163:26 [INFO] [stderr] | [INFO] [stderr] 163 | core_hsalsa20(&mut s,index_fixed!(&n[..];..16),k,SIGMA); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 8]`) [INFO] [stderr] --> src/stream/xsalsa20.rs:164:34 [INFO] [stderr] | [INFO] [stderr] 164 | stream_salsa20_xor(c,Some(m),index_fixed!(&n[16..];..8), &s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/stream/mod.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | assert!(&c[32..] == &c_expected[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 90 | assert!(c[32..] == c_expected[..]); [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `r[..16].clone_from_slice(&a[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:162:6 [INFO] [stderr] | [INFO] [stderr] 162 | *index_fixed!(&mut secret_key;..32) = *seed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | scalarbase(&mut p, index_fixed!(&d;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:171:14 [INFO] [stderr] | [INFO] [stderr] 171 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `secret_key[32..(32 + 32)].clone_from_slice(&public_key[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | x[i] = (r[i] as u64) as i64; // FOR(i,64) x[i] = (u64) r[i]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(r[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `r`. [INFO] [stderr] --> src/sign/ed25519.rs:230:14 [INFO] [stderr] | [INFO] [stderr] 230 | for i in 0..64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 230 | for in r.iter_mut().take(64) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:233:11 [INFO] [stderr] | [INFO] [stderr] 233 | mod_l(index_fixed!(&mut r;..32), &mut x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:265:14 [INFO] [stderr] | [INFO] [stderr] 265 | for i in 0..m.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `sm[64..(m.len() + 64)].clone_from_slice(&m[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:269:14 [INFO] [stderr] | [INFO] [stderr] 269 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `sm[32..(32 + 32)].clone_from_slice(&d[32..(32 + 32)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:275:24 [INFO] [stderr] | [INFO] [stderr] 275 | scalarbase(&mut p, index_fixed!(&r;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:276:10 [INFO] [stderr] | [INFO] [stderr] 276 | pack(index_fixed!(&mut sm;..32), &p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:278:14 [INFO] [stderr] | [INFO] [stderr] 278 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `sm[32..(32 + 32)].clone_from_slice(&sk[32..(32 + 32)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:288:14 [INFO] [stderr] | [INFO] [stderr] 288 | x[i] = r[i] as u64 as i64; //FOR(i,32) x[i] = (u64) r[i]; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(r[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:294:22 [INFO] [stderr] | [INFO] [stderr] 294 | x[i+j] += ((h[i] as u64) * (d[j] as u64)) as i64; //FOR(i,32) FOR(j,32) x[i+j] += h[i] * (u64) d[j]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(h[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sign/ed25519.rs:294:38 [INFO] [stderr] | [INFO] [stderr] 294 | x[i+j] += ((h[i] as u64) * (d[j] as u64)) as i64; //FOR(i,32) FOR(j,32) x[i+j] += h[i] * (u64) d[j]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(d[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:298:11 [INFO] [stderr] | [INFO] [stderr] 298 | mod_l(index_fixed!(&mut sm[32..];..32), &mut x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:305:14 [INFO] [stderr] | [INFO] [stderr] 305 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `c[..16].clone_from_slice(&i[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | for a in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `o[..16].clone_from_slice(&c[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:433:14 [INFO] [stderr] | [INFO] [stderr] 433 | for i in 0..sm.len() { [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `m[..sm.len()].clone_from_slice(&sm[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:436:14 [INFO] [stderr] | [INFO] [stderr] 436 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `m[32..(32 + 32)].clone_from_slice(&pk[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:441:32 [INFO] [stderr] | [INFO] [stderr] 441 | scalarmult(&mut p, &mut q, index_fixed!(&h;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:443:24 [INFO] [stderr] | [INFO] [stderr] 443 | scalarbase(&mut q, index_fixed!(&sm[32..];..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/sign/ed25519.rs:450:26 [INFO] [stderr] | [INFO] [stderr] 450 | if shared::verify_32(index_fixed!(&sm;..32), &t) != true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `m`. [INFO] [stderr] --> src/sign/ed25519.rs:451:18 [INFO] [stderr] | [INFO] [stderr] 451 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 451 | for in m.iter_mut().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/sign/ed25519.rs:457:14 [INFO] [stderr] | [INFO] [stderr] 457 | for i in 0..n { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `m[..n].clone_from_slice(&sm[64..(n + 64)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sign::Keypair` [INFO] [stderr] --> src/sign/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> Keypair { [INFO] [stderr] 64 | | let mut pk = [0u8; PUBLIC_KEY_BYTES]; [INFO] [stderr] 65 | | let mut sk = [0u8; SECRET_KEY_BYTES]; [INFO] [stderr] 66 | | [INFO] [stderr] ... | [INFO] [stderr] 69 | | Keypair { public: PublicKey(pk), secret: SecretKey(sk) } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for sign::Keypair { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign/mod.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let public_key = self.public.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.public` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/sign/mod.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / match ed25519::crypto_sign_open(&mut msg, &signed, &key.0) { [INFO] [stderr] 142 | | Some(_) => true, [INFO] [stderr] 143 | | None => false [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ help: try this: `ed25519::crypto_sign_open(&mut msg, &signed, &key.0).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 32]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:28:57 [INFO] [stderr] | [INFO] [stderr] 28 | onetimeauth::poly1305::onetimeauth(&mut o, c_m, index_fixed!(&c_k;..32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | *index_fixed!(&mut out[16..32];..16) = o; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | *index_fixed!(&mut out;..16) = [0u8;16]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | if !onetimeauth::poly1305::onetimeauth_verify(index_fixed!(&c[16..];..16), &c[32..], &x) { // [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `m`. [INFO] [stderr] --> src/secretbox/xsalsa20poly1305.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in m.iter_mut().take(32) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/secretbox/mod.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | xsalsa20poly1305::secretbox(&mut cipher, &m, &nonce, &key.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | shared::unpack25519(index_fixed!(&mut x;..16),p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `b[..16].clone_from_slice(&x[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:80:40 [INFO] [stderr] | [INFO] [stderr] 80 | shared::gf_multiply(&mut d,b, *index_fixed!(&x;..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] help: try replacing the loop by [INFO] [stderr] | [INFO] [stderr] 85 | for i in x[16..(16 + 16)].clone_from_slice(&a[..16]) [INFO] [stderr] 86 | x[32..(16 + 32)].clone_from_slice(&c[..16]) [INFO] [stderr] 87 | x[48..(16 + 48)].clone_from_slice(&b[..16]) [INFO] [stderr] 88 | x[64..(16 + 64)].clone_from_slice(&d[..16]) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | shared::inv25519(&mut tmp, *index_fixed!(&x[32..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | *index_fixed!(&mut x[32..];..16) = tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | shared::gf_multiply(&mut tmp, *index_fixed!(&x[16..];..16), *index_fixed!(&x[32..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:97:66 [INFO] [stderr] | [INFO] [stderr] 97 | shared::gf_multiply(&mut tmp, *index_fixed!(&x[16..];..16), *index_fixed!(&x[32..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:98:6 [INFO] [stderr] | [INFO] [stderr] 98 | *index_fixed!(&mut x[16..];..16) = tmp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&[T; 16]`) [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:99:27 [INFO] [stderr] | [INFO] [stderr] 99 | shared::pack25519(q, *index_fixed!(&x[16..];..16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/boxy/curve25519xsalsa20poly1305.rs:123:8 [INFO] [stderr] | [INFO] [stderr] 123 | if secretbox::xsalsa20poly1305::secretbox_open(m,c,n,k) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!secretbox::xsalsa20poly1305::secretbox_open(m,c,n,k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `boxy::Keypair` [INFO] [stderr] --> src/boxy/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Keypair { [INFO] [stderr] 29 | | let mut pk = [0u8; curve25519xsalsa20poly1305::PUBLIC_KEY_LEN]; [INFO] [stderr] 30 | | let mut sk = [0u8; curve25519xsalsa20poly1305::SECRET_KEY_LEN]; [INFO] [stderr] 31 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | Keypair { public: PublicKey(pk), secret: SecretKey(sk) } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for boxy::Keypair { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/boxy/mod.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | curve25519xsalsa20poly1305::box_(&mut cipher, &m, &nonce, &pk.0, &sk.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.42s [INFO] running `"docker" "inspect" "e51e9230b43ea946839f22f40dafbc6a79059713dfdafedb0a42d5eed3ef8fdf"` [INFO] running `"docker" "rm" "-f" "e51e9230b43ea946839f22f40dafbc6a79059713dfdafedb0a42d5eed3ef8fdf"` [INFO] [stdout] e51e9230b43ea946839f22f40dafbc6a79059713dfdafedb0a42d5eed3ef8fdf