[INFO] crate mhash 0.3.0 is already in cache [INFO] extracting crate mhash 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/mhash/0.3.0 [INFO] extracting crate mhash 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mhash/0.3.0 [INFO] validating manifest of mhash-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mhash-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mhash-0.3.0 [INFO] finished frobbing mhash-0.3.0 [INFO] frobbed toml for mhash-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/mhash/0.3.0/Cargo.toml [INFO] started frobbing mhash-0.3.0 [INFO] finished frobbing mhash-0.3.0 [INFO] frobbed toml for mhash-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mhash/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mhash-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mhash/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8649859f1cfa6d6c68591c4dc37651b2bb955aa3b598c7947fb8d5d956f446f3 [INFO] running `"docker" "start" "-a" "8649859f1cfa6d6c68591c4dc37651b2bb955aa3b598c7947fb8d5d956f446f3"` [INFO] [stderr] Checking varmint v0.1.3 [INFO] [stderr] Checking mhash v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `fat_ptr_transmutes` has been removed: `was accidentally removed back in 2014` [INFO] [stderr] --> src/lib.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![warn(fat_ptr_transmutes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #![allow(redundant_closure)] // Caused by error_chain! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/multihash.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multihash.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | Ok(MultiHash { variant: variant, digest: digest.into() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variant.rs:88:56 [INFO] [stderr] | [INFO] [stderr] 88 | 0x0400 ... 0x040f => ApplicationSpecific { code: code }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `fat_ptr_transmutes` has been removed: `was accidentally removed back in 2014` [INFO] [stderr] --> src/lib.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![warn(fat_ptr_transmutes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #![allow(redundant_closure)] // Caused by error_chain! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/multihash.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multihash.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | Ok(MultiHash { variant: variant, digest: digest.into() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variant.rs:88:56 [INFO] [stderr] | [INFO] [stderr] 88 | 0x0400 ... 0x040f => ApplicationSpecific { code: code }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/multihash_vec.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let mut writer = &mut bytes; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/multihash_vec.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let mut writer = &mut bytes; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/read.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | buffer.read_multihash().is_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | #![warn(unused_results)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/read.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | buffer.read_multihash().is_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/read.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | buffer.read_multihash().is_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/read.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | buffer.read_multihash().is_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused result [INFO] [stderr] --> src/read.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | buffer.read_multihash().is_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "8649859f1cfa6d6c68591c4dc37651b2bb955aa3b598c7947fb8d5d956f446f3"` [INFO] running `"docker" "rm" "-f" "8649859f1cfa6d6c68591c4dc37651b2bb955aa3b598c7947fb8d5d956f446f3"` [INFO] [stdout] 8649859f1cfa6d6c68591c4dc37651b2bb955aa3b598c7947fb8d5d956f446f3