[INFO] crate mexprp 0.3.0 is already in cache [INFO] extracting crate mexprp 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/mexprp/0.3.0 [INFO] extracting crate mexprp 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mexprp/0.3.0 [INFO] validating manifest of mexprp-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mexprp-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mexprp-0.3.0 [INFO] finished frobbing mexprp-0.3.0 [INFO] frobbed toml for mexprp-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/mexprp/0.3.0/Cargo.toml [INFO] started frobbing mexprp-0.3.0 [INFO] finished frobbing mexprp-0.3.0 [INFO] frobbed toml for mexprp-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mexprp/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mexprp-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mexprp/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] affc53ae767ce121cee4ce784130a1e26ebf9c1c813a63221b4b6bf04ddfd080 [INFO] running `"docker" "start" "-a" "affc53ae767ce121cee4ce784130a1e26ebf9c1c813a63221b4b6bf04ddfd080"` [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.10 [INFO] [stderr] Compiling rug v1.3.0 [INFO] [stderr] Checking mexprp v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/expr.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `op::*` [INFO] [stderr] --> src/expr.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use op::*; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `parse::*` [INFO] [stderr] --> src/expr.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use parse::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `answer::*` [INFO] [stderr] --> src/expr.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use answer::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/term.rs:233:44 [INFO] [stderr] | [INFO] [stderr] 233 | #[cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] [INFO] [stderr] warning: unused import: `rug` [INFO] [stderr] --> src/num/rugcomplex.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rug; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num/float64.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return Err(MathError::CmpError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MathError::CmpError)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/expr.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `op::*` [INFO] [stderr] --> src/expr.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use op::*; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `parse::*` [INFO] [stderr] --> src/expr.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use parse::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `answer::*` [INFO] [stderr] --> src/expr.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use answer::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/term.rs:233:44 [INFO] [stderr] | [INFO] [stderr] 233 | #[cfg_attr(feature = "cargo-clippy", allow(redundant_closure))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure` [INFO] [stderr] [INFO] [stderr] warning: unused import: `rug` [INFO] [stderr] --> src/num/rugcomplex.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rug; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num/float64.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return Err(MathError::CmpError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MathError::CmpError)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ComplexRugRat` [INFO] [stderr] --> src/tests.rs:2:25 [INFO] [stderr] | [INFO] [stderr] 2 | use num::{ComplexFloat, ComplexRugRat}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | assert!((expr.eval().unwrap().unwrap_single() - 81.61714285714285).abs() < 0.001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `81.617_142_857_142_85` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:27:58 [INFO] [stderr] | [INFO] [stderr] 27 | assert!((expr.eval_ctx(&ctx).unwrap().unwrap_single() - 2.995526705934608).abs() < 0.001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2.995_526_705_934_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | 5000000.0 [INFO] [stderr] | ^^^^^^^^^ help: consider: `5_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:91:30 [INFO] [stderr] | [INFO] [stderr] 91 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | fn pow(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | fn pow(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | fn sqrt(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:115:16 [INFO] [stderr] | [INFO] [stderr] 115 | fn nrt(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | fn nrt(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | fn abs(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | fn sin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | fn cos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | fn tan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | fn asin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | fn acos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | fn atan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | fn atan2(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:163:32 [INFO] [stderr] | [INFO] [stderr] 163 | fn atan2(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | fn floor(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | fn ceil(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:181:18 [INFO] [stderr] | [INFO] [stderr] 181 | fn round(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:187:16 [INFO] [stderr] | [INFO] [stderr] 187 | fn log(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:187:30 [INFO] [stderr] | [INFO] [stderr] 187 | fn log(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/opers.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | fn eval(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:35:42 [INFO] [stderr] | [INFO] [stderr] 35 | fn from_f64_complex((r, i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:76:30 [INFO] [stderr] | [INFO] [stderr] 76 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | fn from_f64_complex((r, _i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugcomplex.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | fn from_f64_complex((r, i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | fn from_f64_complex((r, _i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | fn pow(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:83:16 [INFO] [stderr] | [INFO] [stderr] 83 | fn abs(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | fn sin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | fn cos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | fn tan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | fn asin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | fn acos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | fn atan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | fn atan2(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:115:18 [INFO] [stderr] | [INFO] [stderr] 115 | fn floor(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | fn ceil(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | fn round(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:127:30 [INFO] [stderr] | [INFO] [stderr] 127 | fn log(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Ceil` [INFO] [stderr] --> src/context.rs:435:2 [INFO] [stderr] | [INFO] [stderr] 435 | pub struct Ceil; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/op.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | if (other.precedence() > self.precedence()) || (other.precedence() == self.precedence() && other.is_left_associative()) { [INFO] [stderr] | _________^ [INFO] [stderr] 99 | | true [INFO] [stderr] 100 | | } else { [INFO] [stderr] 101 | | false [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `(other.precedence() > self.precedence()) || (other.precedence() == self.precedence() && other.is_left_associative())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | Term::Operation(ref op) => format!("{}", op.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `op.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | Term::Var(ref name) => format!("{}", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:91:30 [INFO] [stderr] | [INFO] [stderr] 91 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/num/mod.rs:103:16 [INFO] [stderr] --> src/term.rs:246:4 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 103 | fn pow(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] 246 | match raw[i] { [INFO] [stderr] | _____________^ [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] 247 | | Expr::Op(Op::Post(_)) => { [INFO] [stderr] 248 | | if raw[i + 1].is_operand() { [INFO] [stderr] 249 | | raw.insert(i + 1, Expr::Op(Op::In(In::Mul))); [INFO] [stderr] ... | [INFO] [stderr] 252 | | _ => {} [INFO] [stderr] 253 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | fn pow(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | fn sqrt(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:115:16 [INFO] [stderr] | [INFO] [stderr] 115 | fn nrt(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | fn nrt(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | if let Expr::Op(Op::Post(_)) = raw[i] { [INFO] [stderr] 247 | if raw[i + 1].is_operand() { [INFO] [stderr] 248 | raw.insert(i + 1, Expr::Op(Op::In(In::Mul))); [INFO] [stderr] 249 | } [INFO] [stderr] 250 | } [INFO] [stderr] | [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | fn abs(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | fn sin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | fn cos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | fn tan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | fn asin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | fn acos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | fn atan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | fn atan2(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:163:32 [INFO] [stderr] | [INFO] [stderr] 163 | fn atan2(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | fn floor(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | fn ceil(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:181:18 [INFO] [stderr] | [INFO] [stderr] 181 | fn round(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/num/mod.rs:187:16 [INFO] [stderr] | [INFO] [stderr] 187 | fn log(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/mod.rs:187:30 [INFO] [stderr] | [INFO] [stderr] 187 | fn log(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/opers.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | fn eval(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:35:42 [INFO] [stderr] | [INFO] [stderr] 35 | fn from_f64_complex((r, i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexrugrat.rs:76:30 [INFO] [stderr] | [INFO] [stderr] 76 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | fn from_f64_complex((r, _i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugrat.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/rugcomplex.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | fn from_f64_complex((r, i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | fn tryord(&self, other: &Self, ctx: &Context) -> Result { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/complexfloat.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | fn from_f64(t: f64, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | fn from_f64_complex((r, _i): (f64, f64), ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | fn add(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | fn sub(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | fn mul(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | fn div(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | fn pow(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:83:16 [INFO] [stderr] | [INFO] [stderr] 83 | fn abs(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | fn sin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | fn cos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | fn tan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | fn asin(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | fn acos(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | fn atan(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | fn atan2(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:115:18 [INFO] [stderr] | [INFO] [stderr] 115 | fn floor(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | fn ceil(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | fn round(&self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/num/float64.rs:127:30 [INFO] [stderr] | [INFO] [stderr] 127 | fn log(&self, other: &Self, ctx: &Context) -> Calculation { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/answer.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn to_vec(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(expr.eval_ctx(&ctx).unwrap().unwrap_single().r, -48.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(expr.eval_ctx(&ctx).unwrap().unwrap_single().r, -48.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(expr.eval_ctx(&ctx).unwrap().unwrap_single().r, -24.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(expr.eval_ctx(&ctx).unwrap().unwrap_single().r, -24.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mexprp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: struct is never constructed: `Ceil` [INFO] [stderr] --> src/context.rs:435:2 [INFO] [stderr] | [INFO] [stderr] 435 | pub struct Ceil; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/op.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | if (other.precedence() > self.precedence()) || (other.precedence() == self.precedence() && other.is_left_associative()) { [INFO] [stderr] | _________^ [INFO] [stderr] 99 | | true [INFO] [stderr] 100 | | } else { [INFO] [stderr] 101 | | false [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `(other.precedence() > self.precedence()) || (other.precedence() == self.precedence() && other.is_left_associative())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | Term::Operation(ref op) => format!("{}", op.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `op.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | Term::Var(ref name) => format!("{}", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/term.rs:246:4 [INFO] [stderr] | [INFO] [stderr] 246 | match raw[i] { [INFO] [stderr] | _____________^ [INFO] [stderr] 247 | | Expr::Op(Op::Post(_)) => { [INFO] [stderr] 248 | | if raw[i + 1].is_operand() { [INFO] [stderr] 249 | | raw.insert(i + 1, Expr::Op(Op::In(In::Mul))); [INFO] [stderr] ... | [INFO] [stderr] 252 | | _ => {} [INFO] [stderr] 253 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | if let Expr::Op(Op::Post(_)) = raw[i] { [INFO] [stderr] 247 | if raw[i + 1].is_operand() { [INFO] [stderr] 248 | raw.insert(i + 1, Expr::Op(Op::In(In::Mul))); [INFO] [stderr] 249 | } [INFO] [stderr] 250 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/answer.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn to_vec(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "affc53ae767ce121cee4ce784130a1e26ebf9c1c813a63221b4b6bf04ddfd080"` [INFO] running `"docker" "rm" "-f" "affc53ae767ce121cee4ce784130a1e26ebf9c1c813a63221b4b6bf04ddfd080"` [INFO] [stdout] affc53ae767ce121cee4ce784130a1e26ebf9c1c813a63221b4b6bf04ddfd080