[INFO] crate mex 0.1.0 is already in cache
[INFO] extracting crate mex 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mex/0.1.0
[INFO] extracting crate mex 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mex/0.1.0
[INFO] validating manifest of mex-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mex-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mex-0.1.0
[INFO] finished frobbing mex-0.1.0
[INFO] frobbed toml for mex-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mex/0.1.0/Cargo.toml
[INFO] started frobbing mex-0.1.0
[INFO] finished frobbing mex-0.1.0
[INFO] frobbed toml for mex-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mex/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mex-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mex/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e0afc2363d8dee5bd1fc143c8ad1c14164fbf4ba765b29b3be3bf48213b41b30
[INFO] running `"docker" "start" "-a" "e0afc2363d8dee5bd1fc143c8ad1c14164fbf4ba765b29b3be3bf48213b41b30"`
[INFO] [stderr] warning: only one of `license` or `license-file` is necessary
[INFO] [stderr]     Checking mex v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/evaluator/context.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             store: store,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `store`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/evaluator/context.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             store: store,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `store`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/evaluator/context.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             store: store,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `store`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/evaluator/context.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             store: store,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `store`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stderr]   --> src/scanner/mod.rs:18:36
[INFO] [stderr]    |
[INFO] [stderr] 18 |         if self.next_index == 0 || self.next_index >= self.chars.len() + 1 {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::int_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stderr] help: change `>= y + 1` to `> y` as shown
[INFO] [stderr]    |
[INFO] [stderr] 18 |         if self.next_index == 0 || self.next_index > self.chars.len() {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/scanner/mod.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         loop {
[INFO] [stderr] 43 | |             if let Some(next) = self.peek() {
[INFO] [stderr] 44 | |                 if !pred(next) {
[INFO] [stderr] 45 | |                     break
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |             }
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(next) = self.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator/object.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         match self {
[INFO] [stderr] 12 | |             &Object::Number(val) => write!(f, "{}", val),
[INFO] [stderr] 13 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 11 |         match *self {
[INFO] [stderr] 12 |             Object::Number(val) => write!(f, "{}", val),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `evaluator::context::Context<'a>`
[INFO] [stderr]   --> src/evaluator/context.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Context<'a> {
[INFO] [stderr] 11 | |         let store = HashMap::new();
[INFO] [stderr] 12 | |
[INFO] [stderr] 13 | |         Context{
[INFO] [stderr] ...  |
[INFO] [stderr] 16 | |         }
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 4  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator/context.rs:28:29
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn has(&self, name: &String) -> bool {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator/context.rs:32:33
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn set(&mut self, name: &String, value: object::Object) {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator/context.rs:42:37
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn declare(&mut self, name: &String, value: object::Object) {
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/evaluator/context.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn get<'b>(&'b self, name: String) -> Option<&'b object::Object> {
[INFO] [stderr] 47 | |         if self.store.contains_key(&name) {
[INFO] [stderr] 48 | |             self.store.get(&name)
[INFO] [stderr] 49 | |         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         }
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/evaluator/mod.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let ref mut ctx = context::Context::new();
[INFO] [stderr]    |     ----^^^^^^^^^^^--------------------------- help: try: `let ctx = &mut context::Context::new();`
[INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stderr]   --> src/scanner/mod.rs:18:36
[INFO] [stderr]    |
[INFO] [stderr] 18 |         if self.next_index == 0 || self.next_index >= self.chars.len() + 1 {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::int_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stderr] help: change `>= y + 1` to `> y` as shown
[INFO] [stderr]    |
[INFO] [stderr] 18 |         if self.next_index == 0 || self.next_index > self.chars.len() {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/scanner/mod.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         loop {
[INFO] [stderr] 43 | |             if let Some(next) = self.peek() {
[INFO] [stderr] 44 | |                 if !pred(next) {
[INFO] [stderr] 45 | |                     break
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |             }
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(next) = self.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator/object.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         match self {
[INFO] [stderr] 12 | |             &Object::Number(val) => write!(f, "{}", val),
[INFO] [stderr] 13 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 11 |         match *self {
[INFO] [stderr] 12 |             Object::Number(val) => write!(f, "{}", val),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `evaluator::context::Context<'a>`
[INFO] [stderr]   --> src/evaluator/context.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Context<'a> {
[INFO] [stderr] 11 | |         let store = HashMap::new();
[INFO] [stderr] 12 | |
[INFO] [stderr] 13 | |         Context{
[INFO] [stderr] ...  |
[INFO] [stderr] 16 | |         }
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 4  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator/context.rs:28:29
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn has(&self, name: &String) -> bool {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator/context.rs:32:33
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn set(&mut self, name: &String, value: object::Object) {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator/context.rs:42:37
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn declare(&mut self, name: &String, value: object::Object) {
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/evaluator/context.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn get<'b>(&'b self, name: String) -> Option<&'b object::Object> {
[INFO] [stderr] 47 | |         if self.store.contains_key(&name) {
[INFO] [stderr] 48 | |             self.store.get(&name)
[INFO] [stderr] 49 | |         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         }
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/evaluator/mod.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let ref mut ctx = context::Context::new();
[INFO] [stderr]    |     ----^^^^^^^^^^^--------------------------- help: try: `let ctx = &mut context::Context::new();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.75s
[INFO] running `"docker" "inspect" "e0afc2363d8dee5bd1fc143c8ad1c14164fbf4ba765b29b3be3bf48213b41b30"`
[INFO] running `"docker" "rm" "-f" "e0afc2363d8dee5bd1fc143c8ad1c14164fbf4ba765b29b3be3bf48213b41b30"`
[INFO] [stdout] e0afc2363d8dee5bd1fc143c8ad1c14164fbf4ba765b29b3be3bf48213b41b30