[INFO] crate metrics_distributor 0.5.1 is already in cache [INFO] extracting crate metrics_distributor 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/metrics_distributor/0.5.1 [INFO] extracting crate metrics_distributor 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metrics_distributor/0.5.1 [INFO] validating manifest of metrics_distributor-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of metrics_distributor-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing metrics_distributor-0.5.1 [INFO] removed 2 missing examples [INFO] finished frobbing metrics_distributor-0.5.1 [INFO] frobbed toml for metrics_distributor-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/metrics_distributor/0.5.1/Cargo.toml [INFO] started frobbing metrics_distributor-0.5.1 [INFO] removed 2 missing examples [INFO] finished frobbing metrics_distributor-0.5.1 [INFO] frobbed toml for metrics_distributor-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metrics_distributor/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting metrics_distributor-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/metrics_distributor/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 574d52f57430f441426ea4f0763390084f5608c39f7c9d986fd34299332074ef [INFO] running `"docker" "start" "-a" "574d52f57430f441426ea4f0763390084f5608c39f7c9d986fd34299332074ef"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/http_server.rs [INFO] [stderr] * /opt/crater/workdir/examples/statsd_server.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking metrics_distributor v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/http.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/http.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | readers: readers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `readers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/statsd.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/statsd.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metrics.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | metrics: metrics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/http.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/http.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | readers: readers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `readers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/statsd.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collectors/statsd.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metrics.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | metrics: metrics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/collectors/http.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Response::with((Status::Created))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/collectors/http.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Response::with((Status::Created))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/collectors/http.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Response::with((Status::Created))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/collectors/http.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Response::with((Status::Created))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/collectors/http.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let ref readers = self.readers; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let readers = &self.readers;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parsers/statsd.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Counter(ref name, value) => Metric::Count(Dimension::with_name(name), value), [INFO] [stderr] 31 | | &Gauge(ref name, value) => Metric::Sample(Dimension::with_name(name), value as f64), [INFO] [stderr] 32 | | &Timer(ref name, value) => Metric::Measure(Dimension::with_name(name), value as f64), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Counter(ref name, value) => Metric::Count(Dimension::with_name(name), value), [INFO] [stderr] 31 | Gauge(ref name, value) => Metric::Sample(Dimension::with_name(name), value as f64), [INFO] [stderr] 32 | Timer(ref name, value) => Metric::Measure(Dimension::with_name(name), value as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/statsd.rs:127:32 [INFO] [stderr] | [INFO] [stderr] 127 | let c = char::from_u32(i as u32).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parsers/log_line.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / fn parse_source<'a>(line: &'a str) -> Option<&'a str> { [INFO] [stderr] 33 | | SOURCE_REGEX.captures(line) [INFO] [stderr] 34 | | .and_then(|c| c.get(1)) [INFO] [stderr] 35 | | .map(|m| m.as_str()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/parsers/log_line.rs:150:97 [INFO] [stderr] | [INFO] [stderr] 150 | metrics.push(Measure(Dimension::with_name_and_source(service_time_name, dyno_type), service as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(service)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/parsers/log_line.rs:155:93 [INFO] [stderr] | [INFO] [stderr] 155 | metrics.push(Measure(Dimension::with_name_and_source(connect_time_name, dyno_type), connect as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(connect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `metrics::AggregatedMetrics` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/metrics.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / impl AggregatedMetrics { [INFO] [stderr] 67 | | pub fn new() -> AggregatedMetrics { [INFO] [stderr] 68 | | AggregatedMetrics { [INFO] [stderr] 69 | | metrics: vec![], [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `metrics::AggregatedMetrics` [INFO] [stderr] --> src/metrics.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn new() -> AggregatedMetrics { [INFO] [stderr] 68 | | AggregatedMetrics { [INFO] [stderr] 69 | | metrics: vec![], [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `store::BaseStore` [INFO] [stderr] --> src/store.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> BaseStore { [INFO] [stderr] 19 | | BaseStore { [INFO] [stderr] 20 | | counts: HashMap::new(), [INFO] [stderr] 21 | | measures: HashMap::new(), [INFO] [stderr] 22 | | samples: HashMap::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/store.rs:34:59 [INFO] [stderr] | [INFO] [stderr] 34 | let values = self.measures.entry(dim).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `store::SharedStore` [INFO] [stderr] --> src/store.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> SharedStore { [INFO] [stderr] 70 | | SharedStore { [INFO] [stderr] 71 | | shared: Arc::new(Mutex::new(BaseStore::new())), [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | impl Default for store::SharedStore { [INFO] [stderr] 69 | fn default() -> Self { [INFO] [stderr] 70 | Self::new() [INFO] [stderr] 71 | } [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/collectors/http.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let ref readers = self.readers; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let readers = &self.readers;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/forwarders/datadog.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let ref value = point[1]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let value = &point[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/forwarders/datadog.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | let ref tag = tags[0]; [INFO] [stderr] | ----^^^^^^^----------- help: try: `let tag = &tags[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parsers/statsd.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Counter(ref name, value) => Metric::Count(Dimension::with_name(name), value), [INFO] [stderr] 31 | | &Gauge(ref name, value) => Metric::Sample(Dimension::with_name(name), value as f64), [INFO] [stderr] 32 | | &Timer(ref name, value) => Metric::Measure(Dimension::with_name(name), value as f64), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Counter(ref name, value) => Metric::Count(Dimension::with_name(name), value), [INFO] [stderr] 31 | Gauge(ref name, value) => Metric::Sample(Dimension::with_name(name), value as f64), [INFO] [stderr] 32 | Timer(ref name, value) => Metric::Measure(Dimension::with_name(name), value as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parsers/statsd.rs:127:32 [INFO] [stderr] | [INFO] [stderr] 127 | let c = char::from_u32(i as u32).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parsers/log_line.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / fn parse_source<'a>(line: &'a str) -> Option<&'a str> { [INFO] [stderr] 33 | | SOURCE_REGEX.captures(line) [INFO] [stderr] 34 | | .and_then(|c| c.get(1)) [INFO] [stderr] 35 | | .map(|m| m.as_str()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/parsers/log_line.rs:150:97 [INFO] [stderr] | [INFO] [stderr] 150 | metrics.push(Measure(Dimension::with_name_and_source(service_time_name, dyno_type), service as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(service)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/parsers/log_line.rs:155:93 [INFO] [stderr] | [INFO] [stderr] 155 | metrics.push(Measure(Dimension::with_name_and_source(connect_time_name, dyno_type), connect as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(connect)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `metrics::AggregatedMetrics` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/metrics.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / impl AggregatedMetrics { [INFO] [stderr] 67 | | pub fn new() -> AggregatedMetrics { [INFO] [stderr] 68 | | AggregatedMetrics { [INFO] [stderr] 69 | | metrics: vec![], [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `metrics::AggregatedMetrics` [INFO] [stderr] --> src/metrics.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn new() -> AggregatedMetrics { [INFO] [stderr] 68 | | AggregatedMetrics { [INFO] [stderr] 69 | | metrics: vec![], [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `store::BaseStore` [INFO] [stderr] --> src/store.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> BaseStore { [INFO] [stderr] 19 | | BaseStore { [INFO] [stderr] 20 | | counts: HashMap::new(), [INFO] [stderr] 21 | | measures: HashMap::new(), [INFO] [stderr] 22 | | samples: HashMap::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/store.rs:34:59 [INFO] [stderr] | [INFO] [stderr] 34 | let values = self.measures.entry(dim).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `store::SharedStore` [INFO] [stderr] --> src/store.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> SharedStore { [INFO] [stderr] 70 | | SharedStore { [INFO] [stderr] 71 | | shared: Arc::new(Mutex::new(BaseStore::new())), [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | impl Default for store::SharedStore { [INFO] [stderr] 69 | fn default() -> Self { [INFO] [stderr] 70 | Self::new() [INFO] [stderr] 71 | } [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `metrics_distributor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "574d52f57430f441426ea4f0763390084f5608c39f7c9d986fd34299332074ef"` [INFO] running `"docker" "rm" "-f" "574d52f57430f441426ea4f0763390084f5608c39f7c9d986fd34299332074ef"` [INFO] [stdout] 574d52f57430f441426ea4f0763390084f5608c39f7c9d986fd34299332074ef